From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00C11C861D for ; Tue, 28 Oct 2025 05:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761629076; cv=none; b=t5ofMQEEU5Ly6M8uoP+BmCzlrPXAPtlRRX2Ju3bkhbyhJf3o9ZsGCRQndnCzq3FNJvRn8i9OY8JsOXNryM3UUXtmxckw5yRKDwhHVt5LOhnr+MLj9FvW/NH1nFwCD/XvVy6/x++kewMhGWdK3cCCwyZmAAzBUORVaFlnhTAf6yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761629076; c=relaxed/simple; bh=I89tJGzHcfRbnf+TZbfEmL4g1nkwlHvwalRd1egTt7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bt3NcH88ofzfOQ4esURLHajjyDD5yABBGSYiWmRD42XsOSr8WElWeA1lDgfJ8GSZ2aXHBNdWFVnK7QdaylSZs+FqKDPAeLCrLtuuBRIpZU1zFh5/xScQz0BvJ31RYJ8aMDsilbnlWwqVUVHL43kw8AiyZ7lWYPGaJJBwdAA7+So= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ddQtWmgl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ddQtWmgl" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59S32Bsw353736 for ; Tue, 28 Oct 2025 05:24:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U687IvC9NqsMop9catDTnZXFwDB7Yeaf6lB08LXZaaU=; b=ddQtWmglEv+Qg02H WwTdPjapZd9oG1lqimcFQrUS3zyxjvpY7kpBFSXptJrgPp0DOKHu3TS8dJpMLkwJ PV+BMIMS5bzTXGlCuGuz6IsYMUampX0kjkzoohs9XOcFRn7kRXFlgxRjp4v3ld4m GbvdX0WRjTue9xxkfu59f24MqtFXhyHCNObeWC005rOF+hCoR/daq0oHyqFAMQhk aRHFJoQE8H4F9qoOU1irvZHFUa0Y6Q6WqttMk997NH5alIqIegMkV7HagpTj7I53 HVqqxqH94RbK3VEtADsDtYVVxgdMlnZrUohz9VTMHjbT8fBR9SyAtH4p+DkTVQuY P81Lkw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a2njrras3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Oct 2025 05:24:34 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-294a938fa37so55581415ad.2 for ; Mon, 27 Oct 2025 22:24:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761629073; x=1762233873; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U687IvC9NqsMop9catDTnZXFwDB7Yeaf6lB08LXZaaU=; b=G2diTkvPZURsEMS7xOurW+iuMzNexb766phZv9oSQfWGqPFK7kjNyYN3rW5ZfBTssv ePrOixyyrEEbIbGrwBVSY9PsayEUGnrEUVnLZIEvWvqNa9UXo+m2t4hU5GA+FLGHDLw3 aq/rr14YUwYuxSQj1sZf+l2H31nisUEJVAj9kdZSpMEYAGa+4at6ttDJLOApmsLUHYCe ySfQgtmswuV1ZTE4OvaBU3M4RcR7HAtPRj0+arlA4pwNJt4QOeac5pOuGyEPiqRjaz/C kIxJj6dbacSHh52XAw091OXkknZ0eXGVzyNApNjcBMrbEmsAxF2NrG18skx1i/uRqUQV qb3Q== X-Forwarded-Encrypted: i=1; AJvYcCUqgCI3VmKDpUDUgPnD4/fNwvj7RcxPsFyf8GqdcUghOMEY5JHHyQc9LOMtn7om1E6FwucLTGDjxx8YtDE=@vger.kernel.org X-Gm-Message-State: AOJu0YyaKvmDx2vxgkeULLyKoUJ0xGr9M+FIRwu2EtBkQoXIdnoMgEhl ik3v3Mb/BtCbympFbH1iB6PbgL5ZbWjbDCzyqPtAP/+V3xLEeegCEDJG9pIfdAYk7xgsCzUem7K FokvZX7tJSi2Jf9hwefeFsLeqkuSK6U9HVjMk5VTjIY0PCm4NpFjM+PRHhxyoBezfQdz1pbMw8o 4= X-Gm-Gg: ASbGncu76Hmh2hgoLDW8XASTpAusn3Lhb/rvX2g+To968noBCeFEME0S53PHm/bg26Q 23tZfu/sha63VE4y4DdBY+v/OD5Wx/xpSNpLAk85FWY5exAmm6rHVZ9rXfGmubzLHdnRIRI2GpQ zRy0xCyS4lyKmjaXcLCkzgNH/splyLmAUNVckLeuVhl76KpQex6yviVB0hdsSGQ4hujN+UOcPk3 G08FvK7SHpGjuXlhF1E7ypmxH+cEKKIc4rFB/Kld8LvxL1a3qcV5W0G+2BoTqXSkK9i4zXIWSc/ FvXiwabA8pFEjt5xeq8VWzV403pP9+1mGTl0pjV2h5Yw3/XTcJGRGe9tnoVQoNLV+uQsuTKYT45 GqMVjdwSudWXYUrbHsV4ad0+zm9D5154= X-Received: by 2002:a17:902:e746:b0:290:cd9c:1229 with SMTP id d9443c01a7336-294cb3baf4cmr25543365ad.19.1761629073157; Mon, 27 Oct 2025 22:24:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoDxeTAbDgjbaa5VLkv2GSbMcsl42sVjQq0NOWa2O/1phRcDcCRPSBpWF/Z6IVKKlq6l2h+w== X-Received: by 2002:a17:902:e746:b0:290:cd9c:1229 with SMTP id d9443c01a7336-294cb3baf4cmr25543095ad.19.1761629072624; Mon, 27 Oct 2025 22:24:32 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d23226sm103101915ad.49.2025.10.27.22.24.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 22:24:32 -0700 (PDT) Message-ID: Date: Tue, 28 Oct 2025 10:54:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 6/6] media: iris: enable support for SC7280 platform Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251027-iris-sc7280-v5-0-5eeab5670e4b@oss.qualcomm.com> <20251027-iris-sc7280-v5-6-5eeab5670e4b@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20251027-iris-sc7280-v5-6-5eeab5670e4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dqvWylg4 c=1 sm=1 tr=0 ts=69005392 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=L4UNg9I9cQSOxNpRiiGXlA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=53nKSqg9CZMqh-_UtzYA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: fOh-vaAHA_qXh1Ra9V5HT9BAuvxklqBU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDA0NSBTYWx0ZWRfX6mrzmv9EeFB1 6HK70yJhQgq5jMGCImK1O9DQyvEHqVvDRHVA2Jba8ImGaK8Y+MpPZjjYNl/J0JG7dr/cQXCDudZ yD79xWqTwijoYwcDNUy8H1CevxO7ACQa4dWjgapzVVBQZVCHn0WTst0U2MN8m0QB2IgXkzyqr5n fln5DF+85XkAZZ/JbkPBv2BHD7f+KGRM6rKn/h9GV6FqMZ7CkZv2AHxmxsg4E+QChm3NkGL1Mjb bOYax8gLATxauvf80v323JTs3AwKl8h/v3yq2AQqt8dkX8gi6V62Xd0rrml4OWOROs6sjK7Z394 6gfdAg2gYnCyK1Cyv0nS/APAXA2QMThHqOkw/e6iflZxW9QjSOQGlpbDr/nMBGwTbQkhbzmZmwa 7FMV2IJphw1GQ6UOF1rphQH/r2pXXA== X-Proofpoint-ORIG-GUID: fOh-vaAHA_qXh1Ra9V5HT9BAuvxklqBU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_02,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510280045 On 10/27/2025 5:57 PM, Dmitry Baryshkov wrote: > As a part of migrating code from the old Venus driver to the new Iris > one, add support for the SC7280 platform. It is very similar to SM8250, > but it (currently) uses no reset controls (there is an optional > GCC-generated reset, it will be added later) and no AON registers > region. Extend the VPU ops to support optional clocks and skip the AON > shutdown for this platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../platform/qcom/iris/iris_platform_common.h | 4 ++ > .../media/platform/qcom/iris/iris_platform_gen1.c | 53 ++++++++++++++++++++++ > .../platform/qcom/iris/iris_platform_sc7280.h | 27 +++++++++++ > drivers/media/platform/qcom/iris/iris_probe.c | 4 ++ > drivers/media/platform/qcom/iris/iris_resources.c | 2 +- > drivers/media/platform/qcom/iris/iris_vpu2.c | 6 +++ > drivers/media/platform/qcom/iris/iris_vpu_common.c | 34 ++++++++++---- > 7 files changed, 120 insertions(+), 10 deletions(-) > > + > +const struct iris_platform_data sc7280_data = { > + .get_instance = iris_hfi_gen1_get_instance, > + .init_hfi_command_ops = &iris_hfi_gen1_command_ops_init, > + .init_hfi_response_ops = iris_hfi_gen1_response_ops_init, > + .get_vpu_buffer_size = iris_vpu_buf_size, > + .vpu_ops = &iris_vpu2_ops, > + .set_preset_registers = iris_set_sm8250_preset_registers, > + .icc_tbl = sm8250_icc_table, > + .icc_tbl_size = ARRAY_SIZE(sm8250_icc_table), > + .bw_tbl_dec = sc7280_bw_table_dec, > + .bw_tbl_dec_size = ARRAY_SIZE(sc7280_bw_table_dec), > + .pmdomain_tbl = sm8250_pmdomain_table, > + .pmdomain_tbl_size = ARRAY_SIZE(sm8250_pmdomain_table), > + .opp_pd_tbl = sc7280_opp_pd_table, > + .opp_pd_tbl_size = ARRAY_SIZE(sc7280_opp_pd_table), > + .clk_tbl = sc7280_clk_table, > + .clk_tbl_size = ARRAY_SIZE(sc7280_clk_table), > + /* Upper bound of DMA address range */ > + .dma_mask = 0xe0000000 - 1, > + .fwname = "qcom/vpu/vpu20_p1.mbn", > + .pas_id = IRIS_PAS_ID, > + .inst_caps = &platform_inst_cap_sm8250, > + .inst_fw_caps_dec = inst_fw_cap_sm8250_dec, > + .inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8250_dec), > + .inst_fw_caps_enc = inst_fw_cap_sm8250_enc, > + .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_sm8250_enc), > + .tz_cp_config_data = &tz_cp_config_sm8250, > + .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > + .num_vpp_pipe = 1, > + .no_aon = true, > + .max_session_count = 16, > + .max_core_mbpf = NUM_MBS_8K, May be I wasn't clear in previous comments, what I menat was. max_core_mbpf = ((4096x2176)/256) x 2 + (1920x1088)/256 > + /* max spec for SC7280 is 4096x2176@60fps */ > + .max_core_mbps = (4096 * 2176 * 2 + 1920 * 1088) / 256 * 60, max_core_mbps = ((4096x2176)/256 ) * 60 fps > + .dec_input_config_params_default = > + sm8250_vdec_input_config_param_default, > + .dec_input_config_params_default_size = > + ARRAY_SIZE(sm8250_vdec_input_config_param_default), > + .enc_input_config_params = sm8250_venc_input_config_param, > + .enc_input_config_params_size = > + ARRAY_SIZE(sm8250_venc_input_config_param), > + > + .dec_ip_int_buf_tbl = sm8250_dec_ip_int_buf_tbl, > + .dec_ip_int_buf_tbl_size = ARRAY_SIZE(sm8250_dec_ip_int_buf_tbl), > + .dec_op_int_buf_tbl = sm8250_dec_op_int_buf_tbl, > + .dec_op_int_buf_tbl_size = ARRAY_SIZE(sm8250_dec_op_int_buf_tbl), > + > + .enc_ip_int_buf_tbl = sm8250_enc_ip_int_buf_tbl, > + .enc_ip_int_buf_tbl_size = ARRAY_SIZE(sm8250_enc_ip_int_buf_tbl), > +}; > @@ -318,13 +328,19 @@ int iris_vpu_power_on_hw(struct iris_core *core) > if (ret) > goto err_disable_power; > > + ret = iris_prepare_enable_clock(core, IRIS_HW_AHB_CLK); > + if (ret && ret != -ENOENT) > + goto err_disable_hw_clock; > + > ret = dev_pm_genpd_set_hwmode(core->pmdomain_tbl->pd_devs[IRIS_HW_POWER_DOMAIN], true); > if (ret) > - goto err_disable_clock; > + goto err_disable_hw_axi_clock; > > return 0; > > -err_disable_clock: > +err_disable_hw_axi_clock: Seems you missed this comment, This label needs an update s/err_disable_hw_axi_clock/err_disable_hw_ahb_clock Thanks, Dikshita > + iris_disable_unprepare_clock(core, IRIS_HW_AHB_CLK);> +err_disable_hw_clock: > iris_disable_unprepare_clock(core, IRIS_HW_CLK); > err_disable_power: > iris_disable_power_domains(core, core->pmdomain_tbl->pd_devs[IRIS_HW_POWER_DOMAIN]); >