From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: cadence: Add error handling for a platform_get_irq() call in cdns_i2c_probe()
Date: Wed, 20 May 2020 13:52:33 +0200 [thread overview]
Message-ID: <b5bf30bd-e630-beb6-e860-44311204c264@web.de> (raw)
> The driver initialization should be end immediately after found
> the platform_get_irq() function return an error.
I suggest to improve also this change description.
How do you think about a wording variant like the following?
Return an error code after a call of the function “platform_get_irq” failed.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
reply other threads:[~2020-05-20 11:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5bf30bd-e630-beb6-e860-44311204c264@web.de \
--to=markus.elfring@web.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=wsa@the-dreams.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome