mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 01/21] arch/cris: Remove unnecessary kmalloc casts
Date: Mon, 31 May 2010 20:23:03 -0700	[thread overview]
Message-ID: <b5c0dbc56b63f55bbfd019a3fbca456816e1130b.1275360951.git.joe@perches.com> (raw)
In-Reply-To: <cover.1275360951.git.joe@perches.com>

And separate declaration from allocation
Still no error checking on failure, but it probably doesn't matter.

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/cris/arch-v32/mm/intmem.c |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/cris/arch-v32/mm/intmem.c b/arch/cris/arch-v32/mm/intmem.c
index 9e8b69c..1b17d92 100644
--- a/arch/cris/arch-v32/mm/intmem.c
+++ b/arch/cris/arch-v32/mm/intmem.c
@@ -33,8 +33,8 @@ static void crisv32_intmem_init(void)
 {
 	static int initiated = 0;
 	if (!initiated) {
-		struct intmem_allocation* alloc =
-		  (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL);
+		struct intmem_allocation* alloc;
+		alloc = kmalloc(sizeof *alloc, GFP_KERNEL);
 		INIT_LIST_HEAD(&intmem_allocations);
 		intmem_virtual = ioremap(MEM_INTMEM_START + RESERVED_SIZE,
 					 MEM_INTMEM_SIZE - RESERVED_SIZE);
@@ -62,9 +62,8 @@ void* crisv32_intmem_alloc(unsigned size, unsigned align)
 		if (allocation->status == STATUS_FREE &&
 		    allocation->size >= size + alignment) {
 			if (allocation->size > size + alignment) {
-				struct intmem_allocation* alloc =
-					(struct intmem_allocation*)
-					kmalloc(sizeof *alloc, GFP_ATOMIC);
+				struct intmem_allocation* alloc;
+				alloc = kmalloc(sizeof *alloc, GFP_ATOMIC);
 				alloc->status = STATUS_FREE;
 				alloc->size = allocation->size - size -
 					alignment;
@@ -74,9 +73,7 @@ void* crisv32_intmem_alloc(unsigned size, unsigned align)
 
 				if (alignment) {
 					struct intmem_allocation *tmp;
-					tmp = (struct intmem_allocation *)
-						kmalloc(sizeof *tmp,
-							GFP_ATOMIC);
+					tmp = kmalloc(sizeof *tmp, GFP_ATOMIC);
 					tmp->offset = allocation->offset;
 					tmp->size = alignment;
 					tmp->status = STATUS_FREE;
-- 
1.7.0.3.311.g6a6955


  reply	other threads:[~2010-06-01  3:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  3:23 [PATCH 00/21] " Joe Perches
2010-06-01  3:23 ` Joe Perches [this message]
2010-06-01  3:23 ` [PATCH 02/21] arch/powerpc: " Joe Perches
2010-06-01  3:23 ` [PATCH 03/21] arch/x86/kernel/tlb_uv.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 04/21] drivers/block/cciss_scsi.c: " Joe Perches
2010-06-01 15:26   ` Miller, Mike (OS Dev)
2010-06-01  3:23 ` [PATCH 05/21] drivers/gpu/drm: " Joe Perches
2010-06-01  3:23 ` [PATCH 06/21] drivers/i2c/i2c-dev.c: " Joe Perches
2010-06-01 10:57   ` Jean Delvare
2010-06-01  3:23 ` [PATCH 07/21] drivers/isdn/capi/capidrv.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 08/21] drivers/media: Remove unnecesary " Joe Perches
2010-06-01  3:23 ` [PATCH 09/21] drivers/message/i2o/i20_config.c: Remove unnecessary " Joe Perches
2010-06-01  3:23 ` [PATCH 10/21] drivers/net/gianfar.c: " Joe Perches
2010-06-01  7:17   ` David Miller
2010-06-01  3:23 ` [PATCH 11/21] drivers/net/tulip/eeprom.c: " Joe Perches
2010-06-01  7:17   ` David Miller
2010-06-01  3:23 ` [PATCH 12/21] drivers/net/vxge/vxge-main.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 13/21] drivers/net/wireless/ipw2x00/ipw2100.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary kzalloc cast Joe Perches
2010-06-01 21:02   ` Grant Grundler
2010-06-01  3:23 ` [PATCH 15/21] drivers/s390: Remove unnecessary kmalloc casts Joe Perches
2010-06-01  3:23 ` [PATCH 16/21] drivers/serial/icom.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 17/21] drivers/usb/storage/isd200.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 18/21] fs/ufs/util.c: " Joe Perches
2010-06-01  3:23 ` [PATCH 19/21] net/ipv4/igmp.c: " Joe Perches
2010-06-01  7:17   ` David Miller
2010-06-01  3:23 ` [PATCH 20/21] net/ipv6/mcast.c: " Joe Perches
2010-06-01  7:17   ` David Miller
2010-06-01  3:23 ` [PATCH 21/21] net/sctp/protocol.c: " Joe Perches
2010-06-02 17:30   ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5c0dbc56b63f55bbfd019a3fbca456816e1130b.1275360951.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®