From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9BAAEEB9 for ; Mon, 17 Jun 2024 16:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718640132; cv=none; b=Zr8GBAXuU0CQgRXufmJWTSkez2WbjEBhJ3yaSVncEpuCi9QLWPZ/pz/JPNoRBWJ5VixkVsI6UNzxgsSxQwjbtmr8p6gRUumAh7/KmbpMrXt9saO8ev3g1/VjT14TaBi5Oej2pHN0aFu3Rb9Mtcgt5RdY8qJBUWRR6PX3ryivmS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718640132; c=relaxed/simple; bh=gwlCe5hnY/gJ427a2/G0fbAq5zBR1zIpQ1yQroB/i0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nb6i/3kH3R6v5+sMXMI1ukFbscGi3ep1K2hqRocq9/3kqhHGqc5mz9O9khi1PDT7+ew+bm5MED7N8vT4NfVW1IQ9fCTu+7nIeytNVh4FC6vMMsOT+wp2phk6M1GANVBOB/aPU7Slf8sV47tLtKRbjveFk4KE3Io9SCoaqv0BVdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=Ij/cvxVB; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Ij/cvxVB" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7eb01106015so201703139f.1 for ; Mon, 17 Jun 2024 09:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1718640130; x=1719244930; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uqgkhvJDnWklw/NEi6lAiqs+H2Sv/nOzZyxuIfPIpJo=; b=Ij/cvxVBaVc+QhymuhVt3l4g+zK3N2/kHLst6DbgkxgCfBN+snDN50Qxf3LDGKnVk6 aOcSYUGUIcvTimmzSmb8LaoB+avthiOz44uNNV4voSZLAz4SlA1rxOaXtlgdRb13h3Gm oKoTu+SZdAQ+YjURLAGglzIct4S3DJTTlQjvlgihPJ1jf2U6LYBEO03cTJ7FUbuXInVz fklcFYDAWYnpdaoba4nGjVt/vv5OcbqWfDSylzwyp5fg3bqPQnzJPQpMPkqDZIM7/y09 4z6wwoWW0LZ264j5f7JDJX31gwndsLKscOHvKwA8BrpvFST+2XgOtI56EV+449iEN/S1 fRAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718640130; x=1719244930; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uqgkhvJDnWklw/NEi6lAiqs+H2Sv/nOzZyxuIfPIpJo=; b=uNv+gXKSHN1/MFdgftc0k4Y3U5ACPqqd2PHM9sLDJM9oK9x2BvuYJ3W6ZtNGNnGBea qaFaM/vD4ic4eDGOIgJ8XN+nEIYF6tZxB37vC3OE67pb1h/mpi8PcdTEdf6Dmj/v70Wv LOXOLgtFG/N4c62MNEUs3OHSb5N716JnB/hPqQqwP2Z74Zhw8fO5jK9wVKpgOdmn4CN+ 54vXeQzkzMRvPl5Sy3sqwJtXWSSfxtGhszgXJ6e8JHr9n5lRD09h2c0Dti0wGJLDRh5l 5mljh1z6Vl2to9uwkV0zBbGWbPg1U8CtIY+KShOb54ttFL9EaQgNIZ5syra2kgum0pEI 180A== X-Forwarded-Encrypted: i=1; AJvYcCWA6LUObCNqawIBqzQNEOY+jUVargZh0g2ok+w2u+woeKL6um0+2YZi6cfAhZ37oglHTMYzJKiELoys9CMHBnSQ1VXsNtBnF+LuBssI X-Gm-Message-State: AOJu0YwA+q+FbFMaLG92MaazpBXqcpYMzX8uKMIeasyIhqGHOVVafkGt ktq/bmFIYMhphAKUDRpKeIPJcMo1yi6m99SEBooyP+zgDme2uE9TS7iGwZ4HzQ8= X-Google-Smtp-Source: AGHT+IGKbQLdD/JERZVBeB2s/YJiMwN6RbVW3XS9jI0ypwFKcJ3JZH9gjestGTkJCAXWkeSpQzy60w== X-Received: by 2002:a05:6602:6c07:b0:7eb:7ebd:1fa4 with SMTP id ca18e2360f4ac-7ebeb4921e2mr1182859539f.1.1718640100005; Mon, 17 Jun 2024 09:01:40 -0700 (PDT) Received: from [100.64.0.1] ([147.124.94.167]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b9569ef011sm2720523173.103.2024.06.17.09.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 09:01:39 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 11:01:37 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] riscv: dts: sophgo: Add initial SG2002 SoC device tree To: Thomas Bonnefille Cc: Albert Ou , Palmer Dabbelt , Thomas Gleixner , Daniel Lezcano , Thomas Petazzoni , =?UTF-8?Q?Miqu=C3=A8l_Raynal?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Chen Wang , Inochi Amaoto , Chao Wei References: <20240612-sg2002-v2-0-19a585af6846@bootlin.com> <20240612-sg2002-v2-5-19a585af6846@bootlin.com> From: Samuel Holland Content-Language: en-US In-Reply-To: <20240612-sg2002-v2-5-19a585af6846@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Thomas, On 2024-06-12 3:02 AM, Thomas Bonnefille wrote: > Add initial device tree for the SG2002 RISC-V SoC by SOPHGO. > > Signed-off-by: Thomas Bonnefille > --- > arch/riscv/boot/dts/sophgo/sg2002.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/riscv/boot/dts/sophgo/sg2002.dtsi b/arch/riscv/boot/dts/sophgo/sg2002.dtsi > new file mode 100644 > index 000000000000..0fc80da7c139 > --- /dev/null > +++ b/arch/riscv/boot/dts/sophgo/sg2002.dtsi > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2024 Thomas Bonnefille > + */ > + > +/dts-v1/; While it doesn't hurt, you don't need this directive in both the .dtsi and each .dts file. It looks like it usually goes in the board .dts file only. Regards, Samuel > + > +#include > +#include "cv18xx.dtsi" > + > +/ { > + compatible = "sophgo,sg2002"; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x10000000>; > + }; > +}; > + > +&plic { > + compatible = "sophgo,sg2002-plic", "thead,c900-plic"; > +}; > + > +&clint { > + compatible = "sophgo,sg2002-clint", "thead,c900-clint"; > +}; > + > +&clk { > + compatible = "sophgo,sg2000-clk"; > +}; > + > +&sdhci0 { > + compatible = "sophgo,sg2002-dwcmshc"; > +}; >