From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/privcmd: remove privcmd_ioctl_mmap()
Date: Thu, 15 Sep 2022 13:40:15 +0200 [thread overview]
Message-ID: <b5c83169-0b92-1ebe-ae5f-fc7bd4e19b99@suse.com> (raw)
In-Reply-To: <4a95c3d1-d4e8-9b59-8db8-231b59cdb8f5@suse.com>
On 15.09.2022 12:20, Juergen Gross wrote:
> On 15.09.22 11:32, Jan Beulich wrote:
>> On 15.09.2022 10:39, Juergen Gross wrote:
>>> The IOCTL_PRIVCMD_MMAP isn't in use by Xen since at least Xen 4.0.
>>>
>>> Remove it from the privcmd driver.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> Can we reasonably remove an IOCTL, without being entirely certain that
>> no users exist outside of xen.git?
>
> This is a valid question. I'm not sure how probable it is that such a user
> is existing. Are there any Xen tool stacks not using the Xen libraries?
>
> If so, why? Do we want to support those use cases?
I'm afraid I have no answers to these questions, and hence would generally
want to be conservative with removal of functionality.
Jan
>> Even if so, shouldn't there be a
>> staged deprecation process?
>
> Depends on the answer to above questions.
>
>
> Juergen
next prev parent reply other threads:[~2022-09-15 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 8:39 Juergen Gross
2022-09-15 9:32 ` Jan Beulich
2022-09-15 10:20 ` Juergen Gross
2022-09-15 11:40 ` Jan Beulich [this message]
2022-09-16 0:11 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c83169-0b92-1ebe-ae5f-fc7bd4e19b99@suse.com \
--to=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®