mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Seyfried <stefan.seyfried@googlemail.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Linux kernel regressions list <regressions@lists.linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	"Kandpal, Suraj" <suraj.kandpal@intel.com>
Subject: Re: [REGRESSION] bisected: 7.1rc1 breaks backlight control on Thinkpad T480
Date: Fri, 15 May 2026 15:20:44 +0200	[thread overview]
Message-ID: <b5c9390d-e365-4a99-acc0-11d9fde8f17d@message-id.googlemail.com> (raw)
In-Reply-To: <233da598-4172-4f16-9fd5-67590984616a@leemhuis.info>

Am 15.05.26 um 14:13 schrieb Thorsten Leemhuis:
> On 5/15/26 13:47, Stefan Seyfried wrote:
>>
>> I found that 7.1rc1 broke the backlight control on my Thinkpad T480.
>> Bisected it to
>>
>>> 40d2f5820951dee818d05c14677277048bd85f9f is the first bad commit
>>> commit 40d2f5820951dee818d05c14677277048bd85f9f
>>> Author: Suraj Kandpal <suraj.kandpal@intel.com>
>>> Date:   Tue Feb 24 08:43:22 2026 +0530
>>>
>>>      drm/i915/backlight: Remove try_vesa_interface
> 
> FWIW: Here are two bug reports that contain proposed fixes for what
> might or might not be the issue your face:
> 
> https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16043
> https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16015

Thanks, will look into testing the patches floating around there.

For now, this

  diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c 
b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
  index a8d56ebf06a2..c4ac46559669 100644
  --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
  +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
  @@ -745,7 +745,7 @@ int intel_dp_aux_init_backlight_funcs(struct 
intel_connector *connector)
                  return 0;
          }

  -       if (intel_dp_aux_supports_vesa_backlight(connector)) {
  +       if (0 && intel_dp_aux_supports_vesa_backlight(connector)) {
                  drm_dbg_kms(dev, "[CONNECTOR:%d:%s] Using VESA eDP 
backlight controls\n",
                              connector->base.base.id, 
connector->base.name);
                  panel->backlight.funcs = &intel_dp_vesa_bl_funcs;

is enough to get the backlight control on the T480 going again.

I know nothing about that code (obviously), but maybe 
"intel_dp_aux_supports_vesa_backlight()" is wrongly determining VESA 
backlight support on my machine?

-- 
Stefan Seyfried

"For a successful technology, reality must take precedence over
  public relations, for nature cannot be fooled." -- Richard Feynman

      reply	other threads:[~2026-05-15 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 11:47 Stefan Seyfried
2026-05-15 12:13 ` Thorsten Leemhuis
2026-05-15 13:20   ` Stefan Seyfried [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5c9390d-e365-4a99-acc0-11d9fde8f17d@message-id.googlemail.com \
    --to=stefan.seyfried@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®