From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdHLQwi (ORCPT ); Sat, 12 Aug 2017 12:52:38 -0400 Received: from mout.web.de ([212.227.17.11]:54605 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdHLQwh (ORCPT ); Sat, 12 Aug 2017 12:52:37 -0400 To: alsa-devel@alsa-project.org, Arnd Bergmann , Jaroslav Kysela , Julia Lawall , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() Message-ID: Date: Sat, 12 Aug 2017 18:51:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:mKA2DedtSGuJhASqLoz29XwguirSmBE9H5XeFA73GlRgYjb1rat 5z7UNtbcmQCKcWeKDeiFSmcP3Zybvz+kpxZxaOXAlJlweV6tndFJg+zUV2MqT8exnOCWoo8 kp2BL92uz2MGztfWgohmuUNwlrsU3A+QtfKyxjLb5QNB9KGEDQ8aC9ApQ8qxah426CeuQy5 GGOpOS7O4bMp/mCwBuY5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:SIp/ZDHmzR4=:+ynmid6TVDC33ggEv72o/K 27tb8j8V1I90GD4FsJ1PwN31SLcSvbzqVLWbeV32bFbpDSg/DQB43qdxqFpJpoKh+zJfgV5H5 jEre8YuqmHWbvoBBiVAvXACheloQw2Z2Zls/XVqni9xQ0tNgJ7QijvzPMrk62WuVIUnYyOgq3 YHX3pw2UIHWe7vL2asC3yOzRB4ywy6OdajSCWxK0m+1GLuGnXUckHlM1AgBFy0nnIQWIMUKgG jaqMq671vDnZnt7K0x+7RgnKKlnHjaOstX13li4GjS1jmIsvp9FfnsrgANAF30/GXJne+Lpib xab+AVSX0I9//PZNx5nwyvNHskAFPLAH9CzBDsQ9WAbzlgUCYAf6d9kj1p/VFQ4LectisHCy+ 0ExofLc2t+LMAodhhD3sGgVlNsFSZtG9/a6Nn6/a/hGYWJgUAr+IFCQ2dkGkYItjcY62LEpV1 86sd3BtPbKn5X8hhLi1E3YCJ9XOyOCLnsL49NYS7cMSG0KEcQ6AvxCSUdga+AiORsBUKM97HO 9vVi2CHm1ZWXUBp/aV85L5YaOrs/sopqYpbKcCqrECiA6rXT0FfhMH4sl9c6UoxRnww4D1BpJ wzW2Q3FGugsUlAcSi1a7vnrh3s2qUCXxju9hoerp7v7VzHOjGUhhyEX+UeyTGlT/iPKMO5nyi 1V71okmyt0xSXZ/wPv2zGiph7UFs5fpFvyWP0GMnkoMmsSqbXaT8W4V+yo/K8uO50hyLVX6pf 9Kr5mqh/prqR3cbd1JaXSockVqRZ7mjVGu+MJK8MnItfVpdh/xbe08y7ff8hLTvndYzaOtXjP 5vlrxe2/if3MpDfcHjuOy2f1yjorxHJAGzTOuGDB9UskA6TwFM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 12 Aug 2017 18:45:42 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/mixart/mixart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c index 6d7fbf30618b..84f6b2651bf3 100644 --- a/sound/pci/mixart/mixart.c +++ b/sound/pci/mixart/mixart.c @@ -1052,10 +1052,8 @@ static int snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *card, int }; chip = kzalloc(sizeof(*chip), GFP_KERNEL); - if (! chip) { - dev_err(card->dev, "cannot allocate chip\n"); + if (!chip) return -ENOMEM; - } chip->card = card; chip->chip_idx = idx; -- 2.14.0