From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757501AbbEVPMH (ORCPT ); Fri, 22 May 2015 11:12:07 -0400 Received: from mta02.ornl.gov ([128.219.177.12]:11090 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757309AbbEVPMF convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 11:12:05 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,476,1427774400"; d="scan'208";a="80648342" From: "Simmons, James A." To: "'Dan Carpenter'" , James Simmons CC: "devel@driverdev.osuosl.org" , James Simmons , James Simmons , Greg Kroah-Hartman , Linux Kernel Mailing List , Oleg Drokin , "HPDD-discuss@ml01.01.org" , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH 2/3] staging:lustre: remove kernel defines in userland headers Thread-Topic: [lustre-devel] [PATCH 2/3] staging:lustre: remove kernel defines in userland headers Thread-Index: AQHQlI+gYKYZI2jpJ0G7FSY1NyjLUJ2IGVcw Date: Fri, 22 May 2015 15:12:02 +0000 Message-ID: References: <1432248378-28912-3-git-send-email-jsimmons@infradead.org> <20150522130019.GN4150@mwanda> In-Reply-To: <20150522130019.GN4150@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> typedef struct lnet_peer { >> - struct list_head lp_hashlist; /* chain on peer hash */ >> - struct list_head lp_txq; /* messages blocking for tx credits */ >> - struct list_head lp_rtrq; /* messages blocking for router credits */ >> - struct list_head lp_rtr_list; /* chain on router list */ >> - int lp_txcredits; /* # tx credits available */ >> - int lp_mintxcredits; /* low water mark */ >> - int lp_rtrcredits; /* # router credits */ >> - int lp_minrtrcredits; /* low water mark */ >> - unsigned int lp_alive:1; /* alive/dead? */ >> - unsigned int lp_notify:1; /* notification outstanding? */ >> - unsigned int lp_notifylnd:1; /* outstanding notification for LND? */ >> - unsigned int lp_notifying:1; /* some thread is handling notification */ >> - unsigned int lp_ping_notsent; /* SEND event outstanding from ping */ >> - int lp_alive_count; /* # times router went dead<->alive */ >> - long lp_txqnob; /* bytes queued for sending */ >> - unsigned long lp_timestamp; /* time of last aliveness news */ >> - unsigned long lp_ping_timestamp; /* time of last ping attempt */ >> - unsigned long lp_ping_deadline; /* != 0 if ping reply expected */ >> - unsigned long lp_last_alive; /* when I was last alive */ >> - unsigned long lp_last_query; /* when lp_ni was queried last time */ >> - lnet_ni_t *lp_ni; /* interface peer is on */ >> - lnet_nid_t lp_nid; /* peer's NID */ >> - int lp_refcount; /* # refs */ >> - int lp_cpt; /* CPT this peer attached on */ >> + /* chain on peer hash */ >> + struct list_head lp_hashlist; >> + /* messages blocking for tx credits */ >> + struct list_head lp_txq; >> + /* messages blocking for router credits */ >> + struct list_head lp_rtrq; >> + /* chain on router list */ >> + struct list_head lp_rtr_list; >> + /* # tx credits available */ >> + int lp_txcredits; >> + /* low water mark */ >> + int lp_mintxcredits; >> + /* # router credits */ >> + int lp_rtrcredits; >> + /* low water mark */ >> + int lp_minrtrcredits; >> + /* alive/dead? */ >> + unsigned int lp_alive:1; >> + /* notification outstanding? */ >> + unsigned int lp_notify:1; >> + /* outstanding notification for LND? */ >> + unsigned int lp_notifylnd:1; > >This new block of declarations is uglier than the original. Don't make >things uglier. Might be ugly but it makes checkpatch.pl happy. So it is a choice between making checkpatch.pl happy about staying in the 80 character limit or looking nice and chekpatch.pl being unhappy.