From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363C7199385 for ; Fri, 26 Sep 2025 13:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758894940; cv=none; b=rRvMHZV44nQ/H6Xhmgf6xnyXn8cUibHnOzlszMcMkJ9KSZDHquwMbjcnqd0OD7vTera74FK4xd/Ycs8Svw6buZ9XGLpKduhCLP5J+kvV+0v6aKxMMAeg4PPXR6Ht6KtxFhGk3vyt01WuxiRaQAxe+rUj1zOFweLVyRnbQE9AXkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758894940; c=relaxed/simple; bh=LJ+ueTE0bDWUCWdc4ScZPk1W991TIS8P7+CZKeVEoAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rLjvRGTqdW+6smpP1lA5aEEHAW2G+Y9Yfn6tNUlX+clm+nh6b9Gpp6HW+rmZ9HlzFKS2DXZp1ElavXIMqmEDVafcDze/25vme41YGoFnVmILgFXNG8Qdw6tfM5Mh430gYZsgJThQHkawH9/Nrq8AbaQfBUHQKIGjC46omVwwglw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kpp4eoz7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kpp4eoz7" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q9k7ct025875 for ; Fri, 26 Sep 2025 13:55:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t/0WdPEeGFmFc2UEt2SE4Y9yd1OQcuTfJccTLwtozas=; b=kpp4eoz7wkAJpTiY w3yfFTh+Bpv9NrC+mwKmIufcC4wgRwEh4Rp/91KmFbSwub5F3gR5G8Cgf4vLupMV WWSEAna2qAB4KH1Ki0WdK6Yd/qvaWssNCr9utyk3p/XR/AEEna9LMubNb9cJo63M xzRuN48GwZ5WCO8Y70MU4j7NBoPKWuz1/m6hfTp9cxIusrHNm+sAYeJEbhxs2/Gr SedeS38rpCMEEKHZrGiC+93p9bNpj/ILJR7qoNCfMcc/qe3gLJgpO6KcKRrY5zBg cH6udCIlvXwNWbqOM8UoBitCikQX3bkWZNDEZ+ogwR4AmdpboAlvlRgAj8mKxa9F NQnEmg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49drfwgp6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 13:55:38 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b56ae0c8226so1612090a12.2 for ; Fri, 26 Sep 2025 06:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758894937; x=1759499737; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t/0WdPEeGFmFc2UEt2SE4Y9yd1OQcuTfJccTLwtozas=; b=NaCt1K2uxMGRw+wmtAUhG+zQIKCHoK0IsWFZAShKPwvmZXuZNMl22yEnLcAOlgSqJh glH3CygazeeCqcIA6j1MU+Q5t+GdyLx4I7d+es0GldBrnjVVv42Hae0VhCUy0nxrY3uW WWBkEaUz+/HeugtzE13FA0VWzZ8WJ5l+zi3S+hnu0aRSm4Xhw04SJ4MsUEc79gJIpAR1 pvxSZP4iMrPmUEbOVUeuqQd9cC0NjsfJVgvJS34/II5td+a6mGqNX1lGZxrSKk7FtF+P vIhiapuTuTb0UffaF+1jdgSG+brZwWkEFyKueJN5jWzjHereBSI712WJbstYiNDq2t3w bHXw== X-Forwarded-Encrypted: i=1; AJvYcCUPw5THtgUO+/Zd8Tm1Cc/PVTUokuiS/Y2XLcIWWtZagBU1ikjFI6a1ZzQPv3sNJtEXrRGYgb5quE1YL+c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx02gkFif0dvCzOwXZRIzQALgjC+JOk7R1J+iVOOsLIwAqv88uN w2R2GzEGdD8NaoKuPwKLrOZySDtv2jy+5vjeVNPgl4UyLnOQDV8saYfiX8O5ie+mayA7oRHaZQ7 62K1lvqUcws3i2huUKhME13eMuOfTel7w8ZndO5cRiAgDm7NJ2veo8JVUKMcxWdD2txk= X-Gm-Gg: ASbGncs4imAH5IG2J7+YxM0cSsu3ogoi0MD1CrPk9kVXPvP9h+uZ+2mXzmORgrKRvLy qOuccOi0qMzbNurgG+wlIzcvHWDBL1ZTRxnJ/rTb06LErPbAZAVKP4klbz03p4ofJbJQ53gS7aE SXf3DbZbrc5RkrFHBSu0/WcN05eh0T+QXcgpiOyiFE5uf1mrrj+aZD/FX89qMUAGnwuV4TSM4WW BrGJntpBaJS0VCle5mUmhKdq5Il1v3IAyukSc1/TvojPtP5R5nECJrcmbO9pkBA3w1kMvEAwVQE dWn4q30JEvpX0kHL0U8ygJ6DIKwtdaw+GbTEU9aIh4McNBXGA+9O5etgSbes+Z7CYgF7vG0h X-Received: by 2002:a05:6a20:3d88:b0:2e6:a01e:f229 with SMTP id adf61e73a8af0-2e7cdda13b7mr9392158637.30.1758894937578; Fri, 26 Sep 2025 06:55:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQn3apaZplc6IpGFkileVv3rgMceoNRvwTZIfdt27hxJke1P6Jas/4sFLWPbGfnXSZUbQ8VQ== X-Received: by 2002:a05:6a20:3d88:b0:2e6:a01e:f229 with SMTP id adf61e73a8af0-2e7cdda13b7mr9392141637.30.1758894937131; Fri, 26 Sep 2025 06:55:37 -0700 (PDT) Received: from [10.204.100.85] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78102c057ecsm4478394b3a.80.2025.09.26.06.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Sep 2025 06:55:36 -0700 (PDT) Message-ID: Date: Fri, 26 Sep 2025 19:25:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Content-Language: en-US To: Konrad Dybcio , Dmitry Baryshkov Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20250925-knp_video-v1-0-e323c0b3c0cd@oss.qualcomm.com> <20250925-knp_video-v1-1-e323c0b3c0cd@oss.qualcomm.com> <522d7244-0003-a42e-9be0-1d353df8d5bd@oss.qualcomm.com> <7c6ab647-0c54-4480-9eb2-5c2bbf5f857d@oss.qualcomm.com> From: Vikash Garodia In-Reply-To: <7c6ab647-0c54-4480-9eb2-5c2bbf5f857d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: O9FKGfOqmyHYfueYIdWqDJnYoQOeRhIP X-Authority-Analysis: v=2.4 cv=JKA2csKb c=1 sm=1 tr=0 ts=68d69b5a cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=WMJ26Vy-SEQUeRUQdDoA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: O9FKGfOqmyHYfueYIdWqDJnYoQOeRhIP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI2MDA4OSBTYWx0ZWRfX3rH4RcrYAF5g fFlxGqhX/6LVRkj4xisL8TKIwk4p/Md9HRfdvW5ze+jJWHxxkAIGQ1n3ZHAHNfJu6BRH8tA+l+k cb7RCGanzRJE1lfMTBpx3ET6yQjMKzVvvZ2p/nZN+anYJK+zP1ydUYVXL7FpGdV8HPYEjeta6Jq d3OXat9roldx4BStG/e4unhgQEzlKFpzVj8RvkY93ZNBwa7CpVKjB8642/YxBwTPN6NCDJkjrFi XivqwVUYkoGgOG5qypOMaS3gFrSVNYiOSJU9MWkSb9soKJ+8S4daw+6+Zjsh5diOBOv083DVAQo oNII9jpWQloTTjbsH0XTfsnfAo2yfgpOkTALy/VGcs6oTel7X32Uz8XCcq/EtX+WJcoEt6wX5kN 7Kc2uVgreaAxQrcqVLUJJ1XWw15nXQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_04,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509260089 On 9/26/2025 5:17 PM, Konrad Dybcio wrote: > On 9/25/25 9:38 PM, Dmitry Baryshkov wrote: >> On Fri, Sep 26, 2025 at 01:01:29AM +0530, Vikash Garodia wrote: >>> >>> On 9/26/2025 12:55 AM, Dmitry Baryshkov wrote: >>>> On Thu, Sep 25, 2025 at 04:44:39AM +0530, Vikash Garodia wrote: > > > [...] > >>>>> + power-domains: >>>>> + minItems: 5 >>>>> + maxItems: 7 >>>> >>>> You are sending bindings for a single device on a single platform. How >>>> comes that it has min != max? >>> >>> I was planning to reuse this binding for the variant SOCs of kaanapali/vpu4. If >>> we do not have min interface, then for those variants, we have to either have >>> separate bindings or add if/else conditions(?). Introducing min now can make it >>> easily usable for upcoming vpu4 variants. >> >> No, it makes it harder to follow the changes. This platform has >> this-and-that requirements. Then you add another platform and it's clear >> that the changes are for that platform. Now you have mixed two different >> patches into a single one. > > Vikash, preparing for future submissions is a very good thing, > however "a binding" can be thought of as a tuple of > > (compatible, allowed_properties, required_properties) > > which needs(asterisk) to remain immutable > > You can make changes to this file later, when introducing said > platforms and it will be fine, so long as you preserve the same allowed > and required properties that you're trying to associate with Kanaapali > here Let say, we have a kaanapali hardware (calling it as kaanapali_next) with 6 power domains, instead of 7, given that one of the pipe is malfunctional or fused out in that hardware distrubution, should the binding be extended for such variant like below ? power-domains: maxItems: 7 - if: properties: compatible: enum: - qcom,kaanapali_next-iris then: properties: power-domains: maxItems: 6 else: properties: power-domains: maxItems: 7 Also, what is the downside in existing approach where we say that the hardware can be functional with 5 pds, and 2 are optional based on hardware having them or not ? So all combinations of [5, 6, 7] pds are valid. IIUC, the optional entries are made for such cases where some hardware parts are variable, please correct my understanding. Regards, Vikash > (i.e. YAML refactors are OK but the result must come out identical) > > Konrad