From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdBUKTn (ORCPT ); Tue, 21 Feb 2017 05:19:43 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:54860 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbdBUKT0 (ORCPT ); Tue, 21 Feb 2017 05:19:26 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-48-58ac14233c2c Subject: Re: [PATCH v4 4/4] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt To: Thibault Saunier , linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , Mauro Carvalho Chehab , Nicolas Dufresne , Andi Shyti , linux-media@vger.kernel.org, Shuah Khan , Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Ulf Hansson , Jeongtae Park , Kyungmin Park , Kamil Debski From: Andrzej Hajda Message-id: Date: Tue, 21 Feb 2017 11:19:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170213190836.26972-5-thibault.saunier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SWUhUURzGOXeZe53mxmmc6t8OEwUKuYQPBwoxyLpFDz1ESg/VkNctt2ZU LIimUssaVKzMxMjAokalmlEbps1ldLQoc20dJYacckFxzAoy8no1fPud833f+Z/vcHha62VX 80lpmZIxzZCiV6mZhrbfb7Zs1NXEhnWbI8hj1xBLSgaLGTI6VkMRV20fRW60X2BJkXeEJp2d Dzny+twoR2zefpb0OCtUxPKwniVlnc8pUuvycOSu7Q9FBqtOEOfUgIq0jM5Gr01NMMTfWEIT d21MlE50eKqQaLMWqMTP/U9Vor3qjFhX5OFE26SHFQvrrEj029aLva6z3P6AQ+rtcVJKUrZk DI08qk6s+laryrAIOYV1PsqMutWXUAAPOAIsJR0qhVfA24EHs6zmtfgugrzvpawsaLEfwQuH ZiHgcN3i/pvuFVTQymIIgavj5azC84FYgrzhYDmgwzEw/S6PkT009rJQfclMy4IKB8GM/cPc aAFHQlv+FyQzgzfB9IU7nMzLcSw43lvmPcvg15UBRj4/AO8C/2de3qZxGJRdbaEU3gD2mrG5 +wC+yUP7+R5a9gNeB7ZGWimwE/q9FYzCgTDsruMUXgsFF5soJXsZwWRRO6csriL4O1E2n94G Le4uVpm2FEoars8PEOBivlaxiPCz2IIU3gGVnX2M8kB9CD753HQx2lC+qE/5ohLli0pUItqK dFKWKTVBMoWHmAyppqy0hJBj6ak2NPv1Xv11jzvQ1/MHmhHmkV4jHJ22xmpZQ7bpZGozAp7W 64RkbU2sVogznDwlGdOPGLNSJFMzWsMz+pXCs8reGC1OMGRKxyUpQzIuqBQfsNqMzFPDZb3J kcIOz5GkJateZs54QtN1gS9GM6Kap/auux7aZN38vnTsub+p/vQhL7Fbh6KNGk1PL/Xt0Y/7 KMiqWT9ub6UZITrn4L6b8V3ZjYdvz+zJP5aLkzOyC32txfoEs3NseMI94osP2f1q7cHJH4NP NDs/anKrnZ577sytSXrGlGgID6aNJsM/n9H0WXYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42I5/e/4Vd0SkTURBtObrSy2H3nGajHp/gQW izdv1zBZHFl7lcli5ol2Vov+x6+ZLc6f38BucbbpDbvFpsfXWC0u75rDZtGzYSurxYzz+5gs 1h65y26xbNMfJov7Swotdn25x2Zx+A1Q69QvH1gsPh+YxGxxfG24g4jHjrtLGD02repk87hz bQ+bx+Yl9R5b+u+ye2z6dJfVo2/LKkaPz5vkPK4caWQP4Ixys8lITUxJLVJIzUvOT8nMS7dV Cg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8aSF2vZCnp4K/q2PGdq YLzE1cXIySEhYCKx48h8dghbTOLCvfVsXYxcHEICSxglTvyZwQLhPGOUWNL1GCjDwSEskCrR +koLpEFEIFzi2L1GqIarjBK33/5nBXGYBZ6ySux5sJsRpIpNQFPi7+abbCA2r4CdxLG2h2Bx FgFViW/tS8FWiwpESMx/uooJokZQ4sfkeywgyzgF3CQ+3+EAMZkF9CTuXwTbyywgL7F5zVvm CYwCs5A0zEKomoWkagEj8ypGkdTS4tz03GJDveLE3OLSvHS95PzcTYzA6N927OfmHYyXNgYf YhTgYFTi4d3xY1WEEGtiWXFl7iFGCQ5mJRHeLKE1EUK8KYmVValF+fFFpTmpxYcYTYE+mMgs JZqcD0xMeSXxhiaG5paGRsYWFuZGRkrivCUfroQLCaQnlqRmp6YWpBbB9DFxcEo1MCrsbXV/ v4Xxg2ea/oxCZ6sQ7ZLKzTc23qvbOmmXaZ0oS+86uZfXHkXx7Fos95B5I7dgvWZffm2/idT0 /sPTHswJEtG7eeRXV7GRmPiLsgB7/bCp8p+cDnzYrrrg/rQLWvpTyxM2HJy0IjKzJlyd9dY/ sel5RpsX/evZ1/Xyg5g3t+SET9UxlUosxRmJhlrMRcWJAPv8FYsUAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170221101912eucas1p15f38b0304bcea3d064a432a849417df7 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170213190920epcas2p4fb3f3c683f559cc2d5d9606130d85b55 X-RootMTR: 20170213190920epcas2p4fb3f3c683f559cc2d5d9606130d85b55 References: <20170213190836.26972-1-thibault.saunier@osg.samsung.com> <20170213190836.26972-5-thibault.saunier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.02.2017 20:08, Thibault Saunier wrote: > It is required by the standard that the field order is set by the > driver. > > Signed-off-by: Thibault Saunier > > --- > > Changes in v4: None > Changes in v3: > - Do not check values in the g_fmt functions as Andrzej explained in previous review > > Changes in v2: > - Fix a silly build error that slipped in while rebasing the patches > > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > index 0976c3e0a5ce..c954b34cb988 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > @@ -385,6 +385,20 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f) > struct s5p_mfc_dev *dev = video_drvdata(file); > struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp; > struct s5p_mfc_fmt *fmt; > + enum v4l2_field field; > + > + field = f->fmt.pix.field; > + if (field == V4L2_FIELD_ANY) { > + field = V4L2_FIELD_NONE; > + } else if (field != V4L2_FIELD_NONE) { > + mfc_debug(2, "Not supported field order(%d)\n", pix_mp->field); > + return -EINVAL; > + } > + > + /* V4L2 specification suggests the driver corrects the format struct > + * if any of the dimensions is unsupported > + */ > + f->fmt.pix.field = field; It looks like you missed my previous comment. -- Regards Andrzej > > mfc_debug(2, "Type is %d\n", f->type); > if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {