From: Jens Axboe <axboe@fb.com>
To: Wen Yang <wenyang@linux.alibaba.com>,
Paolo Valente <paolo.valente@linaro.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block, bfq: improve arithmetic division in bfq_delta()
Date: Wed, 22 Jan 2020 17:34:21 +0000 [thread overview]
Message-ID: <b5d9c9a6-2678-6256-0e21-ec88dfc115b3@fb.com> (raw)
In-Reply-To: <20200120100443.45563-1-wenyang@linux.alibaba.com>
On 1/20/20 3:04 AM, Wen Yang wrote:
> do_div() does a 64-by-32 division. Use div64_ul() instead of it
> if the divisor is unsigned long, to avoid truncation to 32-bit.
> And as a nice side effect also cleans up the function a bit.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-01-22 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 10:04 Wen Yang
2020-01-22 17:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d9c9a6-2678-6256-0e21-ec88dfc115b3@fb.com \
--to=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=wenyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®