From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF56C04AB6 for ; Wed, 29 May 2019 02:38:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A54D21019 for ; Wed, 29 May 2019 02:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbfE2Ci5 (ORCPT ); Tue, 28 May 2019 22:38:57 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54558 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfE2Ci5 (ORCPT ); Tue, 28 May 2019 22:38:57 -0400 Received: by mail-wm1-f65.google.com with SMTP id i3so444898wml.4 for ; Tue, 28 May 2019 19:38:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pP3fYcLgKNcn4ZGi02aByM6WGyk5AzcIbGUQ+cLa/MU=; b=aV7svqWPdVPrvme5LITbLeWiK6I3ZePWOZa3QtXfdsWXBMgWhpYkl07TxvqwYOMZTX 2lCB3L8GvbPYlslgWXBZ/x+iDIl82d1JePQJxYyDhKHs0R0SKr4EgQrU1jQ6OcCqOfRb 1Qq+pLSmP5UrTL7AToJUomU/hFrKN2Tz4agYwlW4XT4DdSGtShgu8GZ81i3KkLCk8urn 7OAt100CDKHYD4Z7KEqSGlLpYoInbH5M0qK+MxLz+0ltaoGePWIc+BYjtzPU5lyNN0Tw nm0dhnK/ySdpEv8o+tZFp8sMQiTUvfqUlnq4Z8QM4l4o/KTMaSENiwEwpToG5lnPZib+ ptPQ== X-Gm-Message-State: APjAAAVy89+5AolfsMDMRsA7VXkDG/kaXG9PUAEVjV84Puc5Gr4I6ZXP sVfSAfIHapQKLSTbZrH96QV65w== X-Google-Smtp-Source: APXvYqwWFZgfUA/y6b7pztK6v2VYoXi6rFrIYAUoQFJJ01BZd4wPg7v9e3QmiJigMbe2sIgRafm9ew== X-Received: by 2002:a05:600c:214d:: with SMTP id v13mr4998628wml.12.1559097534873; Tue, 28 May 2019 19:38:54 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c43e:46a8:e962:cee8? ([2001:b07:6468:f312:c43e:46a8:e962:cee8]) by smtp.gmail.com with ESMTPSA id q9sm3063089wmq.9.2019.05.28.19.38.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 19:38:54 -0700 (PDT) Subject: Re: [PATCH v2 1/3] KVM: x86: add support for user wait instructions To: Tao Xu Cc: rkrcmar@redhat.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, sean.j.christopherson@intel.com, x86@kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jingqi.liu@intel.com References: <20190524075637.29496-1-tao3.xu@intel.com> <20190524075637.29496-2-tao3.xu@intel.com> <419f62f3-69a8-7ec0-5eeb-20bed69925f2@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 29 May 2019 04:38:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/05/19 04:05, Tao Xu wrote: >> > > Thank you Paolo, but I have another question. I was wondering if it is > appropriate to enable X86_FEATURE_WAITPKG when QEMU uses "-overcommit > cpu-pm=on"? "-overcommit" only establishes the behavior of KVM, it doesn't change the cpuid bits. So you'd need "-cpu" as well. Paolo > Or just enable X86_FEATURE_WAITPKG when QEMU add the feature > "-cpu host,+waitpkg"? User wait instructions is the wait or pause > instructions may be executed at any privilege level, but can use > IA32_UMWAIT_CONTROL to set the maximum time.