From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC29025A359; Fri, 22 May 2026 21:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779485869; cv=none; b=YEvNYGAW0HmLdcHPQxIKQgVHjztrDxOcZUdmWFgvt3ZGttbPQvb3zRg13SnLaFZi3CWsr5YrhAPJHgsJsQ8aHEXoYc1OYSWbIx+G8D1bOadPLi/pLm+4F4bbIgqg9DHtv4Gvws1JvyTkY5nningKiV5M7nqqgRtkvGJXJTSCStk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779485869; c=relaxed/simple; bh=Irdpboga0e94lwhHZfmTpX7EMC+HzUaMewhmh6K9zP8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZAjghX2zOec8cm7H9C+YXKVfFHEB1Ms535YJuKrI1Ju/FJ9+hgA70wqRBvyB2tf2gn/sRYi8hnl2HsxnSsyANGfRPJ5biVNlsKDEIpj1mFNRYJrY95aeHdbZUQdUhNvtNZeKET61AshRQ5TL4IWO3CsaJeOjrr2FcnBocp0LGTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bfU8jLI2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bfU8jLI2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D4D1F000E9; Fri, 22 May 2026 21:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779485868; bh=rKySuRH7zxmKCkRj+vsH6WLK86VeQbARbGCmHU+Y/HI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=bfU8jLI2yGgJ3S8yrF4rdgC5styfISFtbqUQutRoKEdI6SnhOTpvbwhLfdrndcTsa +bfIF8AAU0aOQ4Pk7SAfasWZTu0J//QGjMm+0Mw0YB8p+UO2PdO/mFGahGimEqKJx7 Z19tzRTKvAefScpofcsg1goggwxVwonn1DOpcfBm403OGjEXxzigt7hy09yItg4y48 5grJVQcaY3fJpC6I4rsmmJvQbAlGt1Uklz7Fetg1MQaBskuPcKc8A7PcW7oPRBM1me bGrkadhxfZ3g74ZO1eRP4pDSPL0UVo+Kxr6iwZlwoHdZU8lWjEELBA1iIEi+M+to9C jiIjbyCsEraBw== Message-ID: Date: Fri, 22 May 2026 22:37:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: "Rob Herring (Arm)" , Bryan O'Donoghue Cc: linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Neil Armstrong , linux-phy@lists.infradead.org, linux-media@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, Vinod Koul , devicetree@vger.kernel.org, Vladimir Zapolskiy References: <20260522-x1e-csi2-phy-v7-0-79cb1280fad6@linaro.org> <20260522-x1e-csi2-phy-v7-1-79cb1280fad6@linaro.org> <177946855028.3571140.11988520251406266072.robh@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <177946855028.3571140.11988520251406266072.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/05/2026 17:49, Rob Herring (Arm) wrote: > > On Fri, 22 May 2026 15:45:09 +0100, Bryan O'Donoghue wrote: >> Add a base schema initially compatible with x1e80100 to describe MIPI CSI2 >> PHY devices. >> >> The hardware can support both CPHY, DPHY and a special split-mode DPHY. >> >> The schema here defines three ports: >> >> port@0: >> The first input port where a sensor is always required. >> >> port@1: >> A second optional input port which if present implies DPHY split-mode. >> >> port@2: >> A third always required output port which connects to the controller. >> >> The CSIPHY devices have their own pinouts on the SoC as well as their own >> individual voltage rails. >> >> The need to model voltage rails on a per-PHY basis leads us to define >> CSIPHY devices as individual nodes. >> >> Two nice outcomes in terms of schema and DT arise from this change. >> >> 1. The ability to define on a per-PHY basis voltage rails. >> 2. The ability to require those voltage. >> >> We have had a complete bodge upstream for this where a single set of >> voltage rail for all CSIPHYs has been buried inside of CAMSS. >> >> Much like the I2C bus which is dedicated to Camera sensors - the CCI bus in >> CAMSS parlance, the CSIPHY devices should be individually modelled. >> >> Signed-off-by: Bryan O'Donoghue >> --- >> .../bindings/phy/qcom,x1e80100-csi2-phy.yaml | 208 +++++++++++++++++++++ >> 1 file changed, 208 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml: port@0: Missing additionalProperties/unevaluatedProperties constraint > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml: port@1: Missing additionalProperties/unevaluatedProperties constraint > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml: port@2: Missing additionalProperties/unevaluatedProperties constraint > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.example.dtb: csiphy@ace4000 (qcom,x1e80100-csi2-phy): ports:port@2:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes' were unexpected) > from schema $id: http://devicetree.org/schemas/phy/qcom,x1e80100-csi2-phy.yaml Frustratingly dtbs_do_check2 phy/qcom,x1e80100-mipi-csi2-combo-phy.yaml qcom/x1e80100-crd.dtb dtbs_do_check2 () { echo "checking " $1 " and " $2 make dtbs_check ARCH=$ARCH CROSS_COMPILE=$CROSS_COMPILE O=$BUILDDIR DT_DOC_CHECKER=$DT_DOC_CHECKER DT_EXTRACT_EX=$DT_EXTRACT_EX DT_MK_SCHEMA=$DT_MK_SCHEMA DT_SCHEMA_FILES=$1 CHECK_DTBS=y $2 make dt_binding_check O=$BUILDDIR DT_CHECKER_FLAGS=-m DT_DOC_CHECKER=$DT_DOC_CHECKER DT_EXTRACT_EX=$DT_EXTRACT_EX DT_MK_SCHEMA=$DT_MK_SCHEMA DT_SCHEMA_FILES=$1 CHECK_DTBS=y $2 } Neither my script nor the Makefile throw an error when the yaml name doesn't exist i.e. when it changes. I really did run the checker - just for a file that doesn't exist. Feels like a bug I should blame on AI enslopification but, it was me.. meh --- bod phy/qcom,x1e80100-mipi-csi2-combo-phy.yaml