From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Joe Damato <jdamato@fastly.com>,
"x86@kernel.org" <x86@kernel.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
"bp@suse.de" <bp@suse.de>,
"brgerst@gmail.com" <brgerst@gmail.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Re: 5.19-rc1 x86 build failure
Date: Wed, 8 Jun 2022 09:24:25 +0000 [thread overview]
Message-ID: <b5e11680-9101-24ec-0977-c5d0ff8c98c2@citrix.com> (raw)
In-Reply-To: <20220608005956.hzvx3fapdmp25oun@treble>
On 08/06/2022 01:59, Josh Poimboeuf wrote:
> @@ -133,12 +125,16 @@ asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
>
> #endif /* __i386__ */
> #endif /* _SETUP */
> -#else
> -#define RESERVE_BRK(name,sz) \
> - .pushsection .brk_reservation,"aw",@nobits; \
> -.brk.name: \
> -1: .skip sz; \
> - .size .brk.name,.-1b; \
> +
> +#else /* __ASSEMBLY */
> +
> +#define RESERVE_BRK(name, size) \
> + .pushsection .brk_reservation, "aw"; \
> +__brk_##name: \
> +1: .skip size; \
> + .size __brk_##name, . - 1b; \
> .popsection
While I think about it before you write the patch properly, you ought to
have a .type in here too, seeing as the C side now gets one.
~Andrew
next prev parent reply other threads:[~2022-06-08 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 12:19 Joe Damato
2022-06-07 12:42 ` Andrew Cooper
2022-06-08 0:59 ` Josh Poimboeuf
2022-06-08 9:10 ` Joe Damato
2022-06-08 9:24 ` Andrew Cooper [this message]
2022-06-08 15:00 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e11680-9101-24ec-0977-c5d0ff8c98c2@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=jdamato@fastly.com \
--cc=jiangshanlai@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®