mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: mingo@kernel.org, x86@kernel.org,
	Tiantian Feng <fengtiantian@huawei.com>,
	Xishi Qiu <qiuxishi@huawei.com>
Subject: Re: [PATCH v5] x86: call smp vmxoff in smp stop
Date: Thu, 20 Apr 2017 12:01:33 +0200	[thread overview]
Message-ID: <b5e340a1-c3de-6a44-50ce-68388c89febc@redhat.com> (raw)
In-Reply-To: <20170419161839.30550-1-pbonzini@redhat.com>

On 19.04.2017 18:18, Paolo Bonzini wrote:
> From: Tiantian Feng <fengtiantian@huawei.com>
> 
> A CPU in VMX root mode will ignore INIT signals and fail to bring
> up the APs after reboot.  Therefore, on a panic we disable VMX on all
> CPUs before rebooting or triggering kdump.
> 
> Do this when halting the machine as well, in case a firmware-level reboot
> does not perform a cold reset for all processors.  Without doing this,
> rebooting the host may hang.

Guess this make sense, just wonder if something like that is actually
expected to work? Not doing a cold reset feels like leaving a lot of
stuff in an uninitialized state. Shouldn't that specific firmware then
care about performing any necessary resets?

-- 

Thanks,

David

  reply	other threads:[~2017-04-20 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 16:18 Paolo Bonzini
2017-04-20 10:01 ` David Hildenbrand [this message]
2017-04-20 10:13   ` Paolo Bonzini
2017-04-20 11:09     ` David Hildenbrand
2017-04-20 11:16 ` [tip:x86/boot] x86/reboot: Turn off KVM when halting a CPU tip-bot for Tiantian Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5e340a1-c3de-6a44-50ce-68388c89febc@redhat.com \
    --to=david@redhat.com \
    --cc=fengtiantian@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qiuxishi@huawei.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®