From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB8DC04E69 for ; Thu, 27 Jul 2023 10:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232688AbjG0KwJ (ORCPT ); Thu, 27 Jul 2023 06:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbjG0KwH (ORCPT ); Thu, 27 Jul 2023 06:52:07 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E118F2688; Thu, 27 Jul 2023 03:52:02 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36R6Kkdu019067; Thu, 27 Jul 2023 10:51:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=C5RYwUGjBtTl+5dNSpZ5G/v7elv+x3Dv1cSvaxxti00=; b=CEs4QFqqlOSJIZ2XHwnxKUKPFwfqKl5jqZ5uO4D+FZd261MpQdai32vT24itIVqHdyqh m0hwlgm0HDtripDdVIOBR8mUoOL8tCnD+PtFUdKSAHJU9qSgXJD/FnJiSe++GoQaC8hF ChyJ8LeHMo5NeSn/TNVajeKIbDxkum2ebYsUc/ht7EeVeMZLPdSYUCmU2l1TIZlcFNdT je+59zTqzozd0iwXE4MEXqHhpC1LRVVMK7SaLiD1U8I+Cp1yPEmF85iXxXae6VS3hYfo 1XGx+cEfZnd5jL4uy4/Dz4ujQ+URC9qyWf/T3Ow7ddj2+jNMbmVkHxgnsOigu4bz3mmB Og== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s3k7u0kpp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 10:51:52 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36RApS5S031807 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 10:51:28 GMT Received: from [10.253.74.152] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 27 Jul 2023 03:51:24 -0700 Message-ID: Date: Thu, 27 Jul 2023 18:51:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Content-Language: en-US To: Krzysztof Kozlowski , , , Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Torokhov , "Rob Herring" , Krzysztof Kozlowski , , CC: , , , , References: <20230718062639.2339589-1-quic_fenglinw@quicinc.com> <20230718062639.2339589-2-quic_fenglinw@quicinc.com> <4cb9f443-bdea-695a-f1b7-3963747e9a17@quicinc.com> <5b7e624b-5d06-826d-92d1-2a721b7c83b7@quicinc.com> <4210b137-2d5d-a467-ea8c-d047701fdcc2@quicinc.com> <2fa3f27d-ff08-b923-2fb1-cf7cc888e5d5@linaro.org> From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: mVup8Z_5NoWlGBgLcsqKSsJupBSPeNZN X-Proofpoint-ORIG-GUID: mVup8Z_5NoWlGBgLcsqKSsJupBSPeNZN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-27_06,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307270097 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/2023 4:29 PM, Krzysztof Kozlowski wrote: > On 27/07/2023 09:54, Fenglin Wu wrote: >>>>> + - enum: >>>>> + - qcom,pm7550ba-vib >>>>> + - const: qcom,pm7325b-vib >>>>> >>>> >>>> Yes >>> >>> I wonder why this approved change turned out to something incorrect in >>> your v3 patch... >>> >> Since I got review comments in the driver change and I was told to >> refactor the driver before adding new HW support. I added the HW type >> logic in the driver and I was thinking it might be good to add some >> generic compatible strings to match with the HW type introduced in the >> driver change. >> >> Anyway, I will update it to what you suggested in next patch. > > Drivers are not really related to bindings, so whatever HW type you add > in driver, is not a reason to change bindings. Reason to change bindings > could be for example: because hardware is like that. > Understood. Sorry, I forgot to mention, in v3, I added the 'reg' value to the register offset and no longer hard code the 16-bit register address, that makes the vibrators inside PMI632/PM7250B/PM7325B/PM7550BA all compatible, and that was another motivation of adding a generic compatible string and make the others as the fallback. This will be still the case in v4, I might keep it similar in v3 but just drop "qcom,spmi-vib-gen1" > Best regards, > Krzysztof >