From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18D32125A4 for ; Sat, 27 Jan 2024 03:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706325798; cv=none; b=uifaKoc8RJPjpY7EO8jISSAzdgdISBEE757cpNty0MBw1OZVhDIf69F0D9E39LVUy118qJO5N9AGuMndFb5f7eRoUPcQ9gIM+b5RnPZMO1BADghOazCowoH36vgcHhWhC0f0ko8fj9q7arUjO9VFwzTmNGATsFZh9Az+0jVsj4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706325798; c=relaxed/simple; bh=Kb0XMqSBUcpz6qCJguisWNEL00WzSXbRz6iVTAk3Z4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ozE0Ad0y2S1Jnz9In3Nl4vphEPNWYaysBhsL+ynoq5cHRhLkjW25s5hEoxYjoSJFJTggEkE6c7Aqj+1WCnhUZQ8P18r00qp9+/CNkska5Ix0Tdvs7puLdCmNEV/i6DKORErZqXGIjT+jRiuP71/wyoKgaJMhy/muG6yxWNtdamI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HnLpS/g3; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HnLpS/g3" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-55a8fd60af0so502328a12.1 for ; Fri, 26 Jan 2024 19:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706325795; x=1706930595; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pt47LbLd5z/icSoUqr3eyo65hOYLLZvgWj5xScb81fE=; b=HnLpS/g3rqqcra9NKVs88Ns/LOIEvDRWwJX0yfnE8tm9GzTy3nUccS9BML6SYQOKm7 55jS4QD/iRTjvY1M9sDw7Ub1SQ1zA9XmFvwjnvcpsn15preeo8klIDUB+yVNaYy6UEE7 ysdf9BEqB1r29iTq3rEoGbGu0BbDeDPk8mdvVN37dVLmS/17LkDknmZd03z6HCejTdPh z+L7QGulm20Tne79EyRJM+pldxWnTT6o+s0pF31CMzRmpxV+haxkzrgs+JfC2038+cge Gt2Dg8DekJyRHmlESt28wC7/tN5UEO/X335Vjk4qpkQbAHPZ3iFxHyP2OM8mH5ndoyVG yfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706325795; x=1706930595; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pt47LbLd5z/icSoUqr3eyo65hOYLLZvgWj5xScb81fE=; b=hLO9rR5CQDiJQcnqAqcY67V7B/97WIYgbCZYcvuZxsCBmEYb13mppIa9X1zGtCLoIc j0kJkiAY5hNg6AHsSTYAhhmZ6sjdp7HaksvHC8iUKh0SVA5rCJazhdQErl0vkVteLWMy LAtrqcTstGDkg6bjSd997h/TXDsDXitj9v1sOsWtl2KgJI8Nzt8r3cijIB6rthI8jtDe FkBf3SufiW0cF4oLpKUELipSmToKMVd+9uJBV73A0TJ+CTcYPm4aBDKmalqZqBG/ZJJq I5/XfwfSMz6ONWlmZ30hU2f40iEBfXKudxPSEQ/9BsGE5F6PVpEojMjZZnsOZMLMBwGu D7WA== X-Gm-Message-State: AOJu0Yy8/+donyzAOB14qu/PM19/QrRIKpFwtZrn1ZU8tsLz0dPOr3/b urg9a6PBVhA7nB9qYIsUz1gk/DzinxLhzrC2tnnWJd+z09N1X3vpyQB5bzwYAfw= X-Google-Smtp-Source: AGHT+IGIL5nJBcg2ZAg068RZ/riuZeOED27pzyh23D0SIlAzm4sXluQ3G9MAwIwKWvP1vJpMBl267w== X-Received: by 2002:a17:906:6716:b0:a2e:998b:775 with SMTP id a22-20020a170906671600b00a2e998b0775mr338522ejp.5.1706325795076; Fri, 26 Jan 2024 19:23:15 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id sf5-20020a1709078a8500b00a3543718f5bsm111358ejc.221.2024.01.26.19.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 19:23:14 -0800 (PST) Message-ID: Date: Sat, 27 Jan 2024 03:23:12 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 17/17] spi: s3c64xx: use bitfield access macros To: Sam Protsenko Cc: broonie@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, jassi.brar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com References: <20240126171546.1233172-1-tudor.ambarus@linaro.org> <20240126171546.1233172-18-tudor.ambarus@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Sam, Thanks for the review feedback! On 1/26/24 20:12, Sam Protsenko wrote: >> - val |= S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD; >> - val |= S3C64XX_SPI_MODE_CH_TSZ_HALFWORD; >> + val |= FIELD_PREP(S3C64XX_SPI_MODE_BUS_TSZ_MASK, >> + S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD) | >> + FIELD_PREP(S3C64XX_SPI_MODE_CH_TSZ_MASK, >> + S3C64XX_SPI_MODE_CH_TSZ_HALFWORD); > Two people complained it makes the code harder to read. Yet it's not > addressed in v3. Please see my comments for your previous submission > explaining what can be done, and also Andi's comment on that matter. I kept these intentionally. Please read my reply on that matter or the cover letter to this patch set. > Also I think new patch series are being submitted a bit too fast, > people might not have enough time to provide the review. This patch set contains patches that are already reviewed or too simple to being lagged. Cheers, ta