From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdG1O14 (ORCPT ); Fri, 28 Jul 2017 10:27:56 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:36470 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbdG1O1i (ORCPT ); Fri, 28 Jul 2017 10:27:38 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero() To: Fabian Frederick , Andrew Morton Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net References: <20170130184755.18569-1-fabf@skynet.be> From: Corey Minyard Message-ID: Date: Fri, 28 Jul 2017 09:27:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170130184755.18569-1-fabf@skynet.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I missed this until now, and I see it hasn't been applied yet. It's queued for the next release. Thanks, -corey On 01/30/2017 12:47 PM, Fabian Frederick wrote: > instead of atomic_add_unless(value, -1, 0) > > Signed-off-by: Fabian Frederick > --- > drivers/char/ipmi/ipmi_msghandler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 9f69995..961d677 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -3851,7 +3851,7 @@ static void handle_new_recv_msgs(ipmi_smi_t intf) > * If the pretimout count is non-zero, decrement one from it and > * deliver pretimeouts to all the users. > */ > - if (atomic_add_unless(&intf->watchdog_pretimeouts_to_deliver, -1, 0)) { > + if (atomic_dec_not_zero(&intf->watchdog_pretimeouts_to_deliver)) { > ipmi_user_t user; > > rcu_read_lock();