From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Atish Patra <atish.patra@wdc.com>,
Russell King <linux@armlinux.org.uk>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: Fix topology setup in case of CPU hotplug for CONFIG_SCHED_MC
Date: Wed, 20 Nov 2019 12:30:11 +0000 [thread overview]
Message-ID: <b5f99e82-0640-72e6-2499-16e99b1aeae0@arm.com> (raw)
In-Reply-To: <20191120110911.GA31600@bogus>
On 20.11.19 11:09, Sudeep Holla wrote:
> Hi Dietmar, Lukasz,
>
> Thanks for digging this bug and fixing it.
>
> On Wed, Nov 20, 2019 at 10:42:12AM +0000, Dietmar Eggemann wrote:
[...]
>> @@ -231,14 +230,14 @@ void store_cpu_topology(unsigned int cpuid)
>> cpuid_topo->package_id = -1;
>> }
>>
>> - update_siblings_masks(cpuid);
>> -
>> update_cpu_capacity(cpuid);
>>
>> pr_info("CPU%u: thread %d, cpu %d, socket %d, mpidr %x\n",
>> - cpuid, cpu_topology[cpuid].thread_id,
>> - cpu_topology[cpuid].core_id,
>> - cpu_topology[cpuid].package_id, mpidr);
>> + cpuid, cpuid_topo->thread_id, cpuid_topo->core_id,
>> + cpuid_topo->package_id, mpidr);
>> +
>
> [nit] The above is a clearly cosmetic cleanup and shouldn't be part of
> this fix as they will be backported automatically. So I prefer to drop
> this or make it separate patch if required.
I can get rid of this cleanup in v2. Thanks for the review!
next prev parent reply other threads:[~2019-11-20 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 10:42 Dietmar Eggemann
2019-11-20 11:09 ` Sudeep Holla
2019-11-20 12:30 ` Dietmar Eggemann [this message]
2019-11-20 11:16 ` Lukasz Luba
2019-11-24 21:47 ` Ondřej Jirman
2019-11-26 10:42 ` Dietmar Eggemann
2019-11-26 21:45 ` Ondřej Jirman
2019-11-27 14:31 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f99e82-0640-72e6-2499-16e99b1aeae0@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=atish.patra@wdc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukasz.luba@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®