From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC2A729CB39 for ; Thu, 31 Jul 2025 07:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753946146; cv=none; b=fkl53cAKj7tFWxP/yc4CkB6QGBqEEjBxtzTt/3YBp+1oQgIIU59d5tYGsjfrBNNd+mqa5j9F7yYNWDj3J4Wbs4bzwLq0AjJNLS2+dBRzG+WRps1GtrkVFHd6iZCefkkkD4ccbq3/8JM+ntHBl50ldW9YT02aM30puj203DasgMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753946146; c=relaxed/simple; bh=xAhr3IhxbmvATqSsJjmQU+m6BkqQqwxIECx4XJa9adg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f+PBHldCT60cxWkVHeeZv80R/wgncfReMncHC9wMftlhF545BqcZPqlzhRq3EDmY5HVL8xyIXxlfWvnrHO0Rfiv6JwODCBs086LtrVNsKZfN818/BYAy9oW3GXpE6A0Kr/fgbKx71Wx5wAyLGtt5UPn8ZK0N4SmZZDpDLP7iTNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jHIxBMJE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jHIxBMJE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753946143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RawxxfpyMyuGADa6bsr2uGYdFSt+x4/OF9m+6fZhIG0=; b=jHIxBMJEczR+duOzRL6I9RUkCB+jZqmwmXWEqW3be4e2VCnyB5n465DEVKlKYWk5ZbbxUp bAmM7dN7QDHmwtsYw5bPo2GJTxTqyADZkBGmw7qvv5athCQOg8xmWFgmkzkZi3hvnys7ZK k1+eUlQo/BLupzPwQ6ZG871C6qnpiTA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-rd7jp6FUN86bETVUoLc16g-1; Thu, 31 Jul 2025 03:15:41 -0400 X-MC-Unique: rd7jp6FUN86bETVUoLc16g-1 X-Mimecast-MFC-AGG-ID: rd7jp6FUN86bETVUoLc16g_1753946140 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45600d19a2aso3984955e9.1 for ; Thu, 31 Jul 2025 00:15:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753946140; x=1754550940; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RawxxfpyMyuGADa6bsr2uGYdFSt+x4/OF9m+6fZhIG0=; b=qApPG3k4QP5Y4wSXnBCJXPaWqATD2kAnH10apUJKde7NES4O3zTKtQlh7nXISqsOF9 qhov+yYEAgyWvFUGCp56rBfI1v+yiLpfjk958UpLzk9m+4TJdtdQRG62Rtd+913qheHw DgIcZkZsTM9CYUbYb6JAaDuSXcZYSiwovO7xo3lXFWrHuOjDJM+MiZ9aO8daZ4AExLTm XwSX2hspxrXrTxWQORX+jrHtNNZF0TPVhm9ORbLKQLUzdS17qhxcnkfd6MhcJltPskES ma/4G9XWy5Bu6e0dWXbpOSmVm/yfEj5Qqqj1oQpFAPOZu4JhrBB3Yd8ZLbMCmO0H0weK LXAA== X-Forwarded-Encrypted: i=1; AJvYcCXtjSZagpcNPZ3TPhs4MkFg2KuvnfvFFcBsQeJKYAvKIsih7We4iQ4JRNQuNt+ftg75V5sUBsKociZauS8=@vger.kernel.org X-Gm-Message-State: AOJu0YzsUPUMVRVwPB21pjBnyf5YtlG9kSmLvyoTwewxFlSNvQpFn75x QTVNAoa9D0YviV8C4I+WQzI1SMd4yzQv6AVCg9LcQrheSVTroo4PBGBQndEV0IMSzSky0K8IOzq kKDmpg6xdea+a5kmAYvYBMdVyIcOrOY4Cli2uVbWxJVC0HeRoF1SdHdi7BhagqOHnaA== X-Gm-Gg: ASbGncuashOEHmlZwJJKnfwtZY7I+Q6bgWxAfNzbQ7cOJm1RQhc2idq6v2OCdlWYKi0 LsaiCr7f5Fj8cnQNMFXaE5J0kxicYED3sqb1llMK7U8zNdaijTaRN6OwvwSGTwMHLfvcc4y+j3s SnC7iMlcxucpdbIJrBXbet80mo7Gkxm80Si7aYYgZzCjGdCQbtck5743akysAJF/HNU3gNhnxts Nj2YSNZ6HCNOjGv+XKhbiD1GflSpZdtgh/WT0mmNjxJhsDi0kLi16UVHahNORmACtK+4J8oJsWo uEW4oPJWBF1p5itL+yKdwHR1Bkk+HGiq6/pfsY6TCtSYr6Yl/y6Gxoyuz3cP8lDYjKPgTNDcl+3 JGUBYpn024obZAV9LaSL8KCw7s4eZMdygacrH7DbZu+95MlwzxnhqLtqsQsntwJh61d8= X-Received: by 2002:a05:600c:4450:b0:456:1442:86e with SMTP id 5b1f17b1804b1-45892bc5fecmr53890835e9.21.1753946140266; Thu, 31 Jul 2025 00:15:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvO9EQTDfetaDZ/IOkenlXpiTLTHtn2OQfXIVfiUGimQndVHp19prtzhTSQCtI3ggEZ4VuwQ== X-Received: by 2002:a05:600c:4450:b0:456:1442:86e with SMTP id 5b1f17b1804b1-45892bc5fecmr53890405e9.21.1753946139743; Thu, 31 Jul 2025 00:15:39 -0700 (PDT) Received: from ?IPV6:2003:d8:2f44:3700:be07:9a67:67f7:24e6? (p200300d82f443700be079a6767f724e6.dip0.t-ipconnect.de. [2003:d8:2f44:3700:be07:9a67:67f7:24e6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c469b4csm1360576f8f.56.2025.07.31.00.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 00:15:38 -0700 (PDT) Message-ID: Date: Thu, 31 Jul 2025 09:15:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2 02/11] mm/thp: zone_device awareness in THP handling code To: =?UTF-8?Q?Mika_Penttil=C3=A4?= , Zi Yan Cc: Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Shuah Khan , Barry Song , Baolin Wang , Ryan Roberts , Matthew Wilcox , Peter Xu , Kefeng Wang , Jane Chu , Alistair Popple , Donet Tom , Matthew Brost , Francois Dugast , Ralph Campbell References: <20250730092139.3890844-1-balbirs@nvidia.com> <20250730092139.3890844-3-balbirs@nvidia.com> <22D1AD52-F7DA-4184-85A7-0F14D2413591@nvidia.com> <9f836828-4f53-41a0-b5f7-bbcd2084086e@redhat.com> <884b9246-de7c-4536-821f-1bf35efe31c8@redhat.com> <6291D401-1A45-4203-B552-79FE26E151E4@nvidia.com> <8E2CE1DF-4C37-4690-B968-AEA180FF44A1@nvidia.com> <2308291f-3afc-44b4-bfc9-c6cf0cdd6295@redhat.com> <9FBDBFB9-8B27-459C-8047-055F90607D60@nvidia.com> <11ee9c5e-3e74-4858-bf8d-94daf1530314@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <11ee9c5e-3e74-4858-bf8d-94daf1530314@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30.07.25 18:29, Mika Penttilä wrote: > > On 7/30/25 18:58, Zi Yan wrote: >> On 30 Jul 2025, at 11:40, Mika Penttilä wrote: >> >>> On 7/30/25 18:10, Zi Yan wrote: >>>> On 30 Jul 2025, at 8:49, Mika Penttilä wrote: >>>> >>>>> On 7/30/25 15:25, Zi Yan wrote: >>>>>> On 30 Jul 2025, at 8:08, Mika Penttilä wrote: >>>>>> >>>>>>> On 7/30/25 14:42, Mika Penttilä wrote: >>>>>>>> On 7/30/25 14:30, Zi Yan wrote: >>>>>>>>> On 30 Jul 2025, at 7:27, Zi Yan wrote: >>>>>>>>> >>>>>>>>>> On 30 Jul 2025, at 7:16, Mika Penttilä wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> On 7/30/25 12:21, Balbir Singh wrote: >>>>>>>>>>>> Make THP handling code in the mm subsystem for THP pages aware of zone >>>>>>>>>>>> device pages. Although the code is designed to be generic when it comes >>>>>>>>>>>> to handling splitting of pages, the code is designed to work for THP >>>>>>>>>>>> page sizes corresponding to HPAGE_PMD_NR. >>>>>>>>>>>> >>>>>>>>>>>> Modify page_vma_mapped_walk() to return true when a zone device huge >>>>>>>>>>>> entry is present, enabling try_to_migrate() and other code migration >>>>>>>>>>>> paths to appropriately process the entry. page_vma_mapped_walk() will >>>>>>>>>>>> return true for zone device private large folios only when >>>>>>>>>>>> PVMW_THP_DEVICE_PRIVATE is passed. This is to prevent locations that are >>>>>>>>>>>> not zone device private pages from having to add awareness. The key >>>>>>>>>>>> callback that needs this flag is try_to_migrate_one(). The other >>>>>>>>>>>> callbacks page idle, damon use it for setting young/dirty bits, which is >>>>>>>>>>>> not significant when it comes to pmd level bit harvesting. >>>>>>>>>>>> >>>>>>>>>>>> pmd_pfn() does not work well with zone device entries, use >>>>>>>>>>>> pfn_pmd_entry_to_swap() for checking and comparison as for zone device >>>>>>>>>>>> entries. >>>>>>>>>>>> >>>>>>>>>>>> Zone device private entries when split via munmap go through pmd split, >>>>>>>>>>>> but need to go through a folio split, deferred split does not work if a >>>>>>>>>>>> fault is encountered because fault handling involves migration entries >>>>>>>>>>>> (via folio_migrate_mapping) and the folio sizes are expected to be the >>>>>>>>>>>> same there. This introduces the need to split the folio while handling >>>>>>>>>>>> the pmd split. Because the folio is still mapped, but calling >>>>>>>>>>>> folio_split() will cause lock recursion, the __split_unmapped_folio() >>>>>>>>>>>> code is used with a new helper to wrap the code >>>>>>>>>>>> split_device_private_folio(), which skips the checks around >>>>>>>>>>>> folio->mapping, swapcache and the need to go through unmap and remap >>>>>>>>>>>> folio. >>>>>>>>>>>> >>>>>>>>>>>> Cc: Karol Herbst >>>>>>>>>>>> Cc: Lyude Paul >>>>>>>>>>>> Cc: Danilo Krummrich >>>>>>>>>>>> Cc: David Airlie >>>>>>>>>>>> Cc: Simona Vetter >>>>>>>>>>>> Cc: "Jérôme Glisse" >>>>>>>>>>>> Cc: Shuah Khan >>>>>>>>>>>> Cc: David Hildenbrand >>>>>>>>>>>> Cc: Barry Song >>>>>>>>>>>> Cc: Baolin Wang >>>>>>>>>>>> Cc: Ryan Roberts >>>>>>>>>>>> Cc: Matthew Wilcox >>>>>>>>>>>> Cc: Peter Xu >>>>>>>>>>>> Cc: Zi Yan >>>>>>>>>>>> Cc: Kefeng Wang >>>>>>>>>>>> Cc: Jane Chu >>>>>>>>>>>> Cc: Alistair Popple >>>>>>>>>>>> Cc: Donet Tom >>>>>>>>>>>> Cc: Mika Penttilä >>>>>>>>>>>> Cc: Matthew Brost >>>>>>>>>>>> Cc: Francois Dugast >>>>>>>>>>>> Cc: Ralph Campbell >>>>>>>>>>>> >>>>>>>>>>>> Signed-off-by: Matthew Brost >>>>>>>>>>>> Signed-off-by: Balbir Singh >>>>>>>>>>>> --- >>>>>>>>>>>> include/linux/huge_mm.h | 1 + >>>>>>>>>>>> include/linux/rmap.h | 2 + >>>>>>>>>>>> include/linux/swapops.h | 17 +++ >>>>>>>>>>>> mm/huge_memory.c | 268 +++++++++++++++++++++++++++++++++------- >>>>>>>>>>>> mm/page_vma_mapped.c | 13 +- >>>>>>>>>>>> mm/pgtable-generic.c | 6 + >>>>>>>>>>>> mm/rmap.c | 22 +++- >>>>>>>>>>>> 7 files changed, 278 insertions(+), 51 deletions(-) >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>> +/** >>>>>>>>>>>> + * split_huge_device_private_folio - split a huge device private folio into >>>>>>>>>>>> + * smaller pages (of order 0), currently used by migrate_device logic to >>>>>>>>>>>> + * split folios for pages that are partially mapped >>>>>>>>>>>> + * >>>>>>>>>>>> + * @folio: the folio to split >>>>>>>>>>>> + * >>>>>>>>>>>> + * The caller has to hold the folio_lock and a reference via folio_get >>>>>>>>>>>> + */ >>>>>>>>>>>> +int split_device_private_folio(struct folio *folio) >>>>>>>>>>>> +{ >>>>>>>>>>>> + struct folio *end_folio = folio_next(folio); >>>>>>>>>>>> + struct folio *new_folio; >>>>>>>>>>>> + int ret = 0; >>>>>>>>>>>> + >>>>>>>>>>>> + /* >>>>>>>>>>>> + * Split the folio now. In the case of device >>>>>>>>>>>> + * private pages, this path is executed when >>>>>>>>>>>> + * the pmd is split and since freeze is not true >>>>>>>>>>>> + * it is likely the folio will be deferred_split. >>>>>>>>>>>> + * >>>>>>>>>>>> + * With device private pages, deferred splits of >>>>>>>>>>>> + * folios should be handled here to prevent partial >>>>>>>>>>>> + * unmaps from causing issues later on in migration >>>>>>>>>>>> + * and fault handling flows. >>>>>>>>>>>> + */ >>>>>>>>>>>> + folio_ref_freeze(folio, 1 + folio_expected_ref_count(folio)); >>>>>>>>>>> Why can't this freeze fail? The folio is still mapped afaics, why can't there be other references in addition to the caller? >>>>>>>>>> Based on my off-list conversation with Balbir, the folio is unmapped in >>>>>>>>>> CPU side but mapped in the device. folio_ref_freeeze() is not aware of >>>>>>>>>> device side mapping. >>>>>>>>> Maybe we should make it aware of device private mapping? So that the >>>>>>>>> process mirrors CPU side folio split: 1) unmap device private mapping, >>>>>>>>> 2) freeze device private folio, 3) split unmapped folio, 4) unfreeze, >>>>>>>>> 5) remap device private mapping. >>>>>>>> Ah ok this was about device private page obviously here, nevermind.. >>>>>>> Still, isn't this reachable from split_huge_pmd() paths and folio is mapped to CPU page tables as a huge device page by one or more task? >>>>>> The folio only has migration entries pointing to it. From CPU perspective, >>>>>> it is not mapped. The unmap_folio() used by __folio_split() unmaps a to-be-split >>>>>> folio by replacing existing page table entries with migration entries >>>>>> and after that the folio is regarded as “unmapped”. >>>>>> >>>>>> The migration entry is an invalid CPU page table entry, so it is not a CPU >>>>> split_device_private_folio() is called for device private entry, not migrate entry afaics. >>>> Yes, but from CPU perspective, both device private entry and migration entry >>>> are invalid CPU page table entries, so the device private folio is “unmapped” >>>> at CPU side. >>> Yes both are "swap entries" but there's difference, the device private ones contribute to mapcount and refcount. >> Right. That confused me when I was talking to Balbir and looking at v1. >> When a device private folio is processed in __folio_split(), Balbir needed to >> add code to skip CPU mapping handling code. Basically device private folios are >> CPU unmapped and device mapped. >> >> Here are my questions on device private folios: >> 1. How is mapcount used for device private folios? Why is it needed from CPU >> perspective? Can it be stored in a device private specific data structure? > > Mostly like for normal folios, for instance rmap when doing migrate. I think it would make > common code more messy if not done that way but sure possible. > And not consuming pfns (address space) at all would have benefits. > >> 2. When a device private folio is mapped on device, can someone other than >> the device driver manipulate it assuming core-mm just skips device private >> folios (barring the CPU access fault handling)? >> >> Where I am going is that can device private folios be treated as unmapped folios >> by CPU and only device driver manipulates their mappings? >> > Yes not present by CPU but mm has bookkeeping on them. The private page has no content > someone could change while in device, it's just pfn. Just to clarify: a device-private entry, like a device-exclusive entry, is a *page table mapping* tracked through the rmap -- even though they are not present page table entries. It would be better if they would be present page table entries that are PROT_NONE, but it's tricky to mark them as being "special" device-private, device-exclusive etc. Maybe there are ways to do that in the future. Maybe device-private could just be PROT_NONE, because we can identify the entry type based on the folio. device-exclusive is harder ... So consider device-private entries just like PROT_NONE present page table entries. Refcount and mapcount is adjusted accordingly by rmap functions. -- Cheers, David / dhildenb