From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29C5938A726 for ; Mon, 16 Mar 2026 09:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654227; cv=none; b=XPhyr6JbtygcI2PrSfaQNeD2Vz92rAXzpillKpBW9uFdAieCbjYwwfk2Zp5dGo8OZUloeCEJDq0QbQtTnvoVbWz/QG06SbBrm9nmUTY3oyULolyTS5SmOUFV0S836EUH59E3AP85+MLzhfGZsydYvFETJbMpYIpNPJUAfDgB7V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654227; c=relaxed/simple; bh=m3J8Ggq7feejQvUq9IXDmbMXJ1en09zunM2kuDvpUIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pyKJsXHpHNf/mvQLuVpiabrDVPyB6Fcx1uXrAAQZF+8mL0L/iVTCuT2evCEz+lbAixLcUw4EYYFgBIdkAhOjZP0G1UBfCux/OSksIri1GtbUV9iD7vY0saexcafRWhTcDTAPh3/YcEtOh74gVcQpPrEAZRNwQb6Sg8qqBGlTmNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NXgSijOp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R+o6z4Hr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NXgSijOp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R+o6z4Hr" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64hR81724716 for ; Mon, 16 Mar 2026 09:43:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GzTMin4P82QqW3Y2Ob2ad2lbllt1U3DaWcQWJwydyFg=; b=NXgSijOpgGPKu/eI OfjA6pw2Y0M/xoLgOu9UqBiGHYIAm1d88qjUHCRDRUf3MsFMIKJP5S73pOJr3l4C dAWFa+Yw0tWNCF3uGbVgQdKTsIyypVJJvLPkE2zp6diNX688jcC1facr89PXRwne jV/s1EAZSXjDGwdfi/i4USRUoJf07gMDSksFrU2lUw3IL50gGAGTtp1pMwMpcgn6 5nuj3B+LRmZ4LNm/vGP4SqikXF38j3CEfzPp46uZq+lgxekB8G9WO8mfMni/x9WO lPTMtb3w8SEBomlz7QWgAE7Qq6jNBU0oxdNoIXYfNOwRDzQ4eH2vEhaOBr0JTL1J /T6rRw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw0udmysk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 09:43:45 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b04911610fso19218035ad.3 for ; Mon, 16 Mar 2026 02:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773654225; x=1774259025; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GzTMin4P82QqW3Y2Ob2ad2lbllt1U3DaWcQWJwydyFg=; b=R+o6z4Hr4v5HQQnM67Mq95GmLGwZlFGHU+3Z1s3rA6410IyMsIjxXqfI02U3T5H8nt awopZTg3ILEuSa4aYa5A+BtUQWFdytkUejqiCTGFz9Ms/X+bll432GQupewytsYUVSqf WIHtuHiv6B5pckkHfgf/bS7h/B2bw8f7dHtwfQuMLr+Vm/tP7sT2ZR39k4ghxiPk9Lo2 hIl3QQiNDaHIojrAF2iKwJ8KX7bmrR13Dte7HOzj88rpc4+x7UvcGkNBZ7XYqngBE2Ai nTy6aAvcSibvPs+XtbFaRo5Bypl5PipzGCnuS4UPfn8SczYaaNJ/fbLS4d1reDzZPebV 3x1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773654225; x=1774259025; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GzTMin4P82QqW3Y2Ob2ad2lbllt1U3DaWcQWJwydyFg=; b=nRxz6GmKO0142BxPVbX2eXPHkRjM0ubbxqYCJN6GYbqNYopGk3QDR3I+B0UHRRiTId PKh7t8IG+Y/f/UEPF6Q2pYWhWtRNt0ONEZezJgobDEb8yoZQ87TvDn7sDX0creX4I6Pj nunw4wBpY3PuDAJax9DKFrtmyuKh+0we6Ac9snZb58qBwQN8qllIJwJduu+6llSvh9Yn FVO/QoOkjIW4xD22GlEuQcMFKDfkLv6ZHyis982CY4TqsdETUF7drTrAm59/teIthHQp aKtcG8YxBzf5TRUvNj0tS2kguerwNyR6wQ8WQ9DDVhKgBcckyyQQLp5OPcMA9BkNAFbu RzpA== X-Forwarded-Encrypted: i=1; AJvYcCUXjS76+u49tCta+4UeXUIU4nvzbv/axERF7oY3cZghfG805snYuHFi2WHqTVTwiGAjO0xDMJEmJjjK9qk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/+kMwTxWxi5mPJi3IUV/xB/Mk+a6n5NOF/4+jHroskNaRswN/ qnJ0vNOQ03swSQJ0tt2mdDHWroR2J0dJWGx5M4MAEt1XolfeXh+wYmx1M0oOPjtKW4Cb7NKIwyZ aeBLhsBIoaL22w8qy4yr9KPt1jmo1m1h//TMrqm3MuXGDTYXZPX18toJ1+7xpi78WmWg= X-Gm-Gg: ATEYQzyai6OIvrcOP0mpDspKKtgJp20IimbJoCBc/5ArGttuuvshlwUQQhTOsVKN+by nSFx0YSDADbYg2lvEPFLejWADHITZdCcBAgHScnO2UtMQZ7P1tfhu3Ek3ewT8sBg8rr0FPZJK3D xyxlE2r+xyKThEotgNlezkttXc7Hjio0dDaf6IKv05f8JLrfMdz3kNUkrqQ5u0qj+ljd+x3fQfP 8UEnqmWm94eau+wVuuchRlYpaMuXEykNKrHuqMl4jU2tR0/eO34LDQ2rIBXzSwdzM4KZRA++bzk PeSBP2d5GIq2Rq5NlopyP5ClGC12K+StLtmU5kdorRN8u4YCtQ2OpL8ynFT0qJ/2WSWenS0Uvu+ wWHbNwSFQ88rKKTAHmCzJ/ej0Ty0GRjJjzzqgErbDqSLsTBrYFzbsK2h4kb0Pd2IjsIP1Lkc+b6 U84wPU0GWCOglkjxVId4SiaSLaHGD0NwuHGw== X-Received: by 2002:a17:902:ef07:b0:2ad:e02b:4629 with SMTP id d9443c01a7336-2aecac81c73mr147382595ad.50.1773654224729; Mon, 16 Mar 2026 02:43:44 -0700 (PDT) X-Received: by 2002:a17:902:ef07:b0:2ad:e02b:4629 with SMTP id d9443c01a7336-2aecac81c73mr147382295ad.50.1773654224150; Mon, 16 Mar 2026 02:43:44 -0700 (PDT) Received: from [10.79.197.144] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece62bc32sm105145305ad.36.2026.03.16.02.43.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 02:43:43 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 15:13:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Krzysztof Kozlowski , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BJ2+bVQG c=1 sm=1 tr=0 ts=69b7d0d1 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=48movuqWnwKwBUJduE8A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: Y0Fb449EGu3TruUFEayfJpqQmb7Tm0tH X-Proofpoint-ORIG-GUID: Y0Fb449EGu3TruUFEayfJpqQmb7Tm0tH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA3NCBTYWx0ZWRfX1Y0ooMy8Fezh Ji+VVKh88y45KpKQNFMVFqFKgfBag9XmN7x3A7dYQ3UWWET3Cby8UfOfRycZ8HRWjTNr5PDL9GL JSbRgf19Buc6dJqHS1MIUC4UtDM9l8LSTv+SgwQYa3x52aPq0KH2WD3/q1WFxBTX5Bj0bGL9waO Njb5GD0yPPp+5vy0IT10SpWT7zSjvcwA9hPYkl0QLRxQCrkBvZB8ax6cmu9RrUcTIPyvfF7ZonP WzZwTkb2T9owQNPW7YrCXFTEdaVFq7YQ0rXYk+WoKVuUaqDnQJ0evZP8RBWWVZ0i7Fmvn5xrWyo wdSsLoYBCIobmlt9vPy6SFJ4IBbhNPia4z1247G2H+d5PJDuw8fMhG6586eMmI0cFNKoiVNKVoI aNUhWbVf0irS8uHwUEHL7I7xAfnitBqsne8FvnqWRgoL8/M2pSa4K7rPNfBA2eEhCAN2lT4OAth aubKnzc6+WDLztK+C2w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_03,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160074 On 3/14/2026 12:35 AM, Krzysztof Kozlowski wrote: > On 13/03/2026 11:29, Anvesh Jain P wrote: >> + >> +static irqreturn_t qcom_ec_irq(int irq, void *data) >> +{ >> + struct qcom_ec *ec = data; >> + struct device *dev = &ec->client->dev; >> + int val; >> + >> + val = i2c_smbus_read_byte_data(ec->client, EC_SCI_EVT_READ_CMD); >> + if (val < 0) { >> + dev_err(dev, "Failed to read EC SCI Event: %d\n", val); > > ratelimit > >> + return IRQ_HANDLED; >> + } >> + >> + switch (val) { >> + case EC_FAN1_STATUS_CHANGE_EVT: >> + dev_dbg(dev, "Fan1 status changed\n"); > > ratelimit everywhere further. You are in interrupt handler so imagine > same interrupt keep happening because of constant overheat. > Agreed. I will switch to dev_err_ratelimited() and dev_dbg_ratelimited() throughout the IRQ handler to prevent log spam during potential interrupt storms. >> + break; >> + case EC_FAN2_STATUS_CHANGE_EVT: >> + dev_dbg(dev, "Fan2 status changed\n"); >> + break; >> + case EC_FAN1_SPEED_CHANGE_EVT: >> + dev_dbg(dev, "Fan1 speed crossed low/high trip point\n"); >> + break; >> + case EC_FAN2_SPEED_CHANGE_EVT: >> + dev_dbg(dev, "Fan2 speed crossed low/high trip point\n"); >> + break; >> + case EC_NEW_LUT_SET_EVT: >> + dev_dbg(dev, "New LUT set\n"); >> + break; >> + case EC_FAN_PROFILE_SWITCH_EVT: >> + dev_dbg(dev, "FAN Profile switched\n"); >> + break; >> + case EC_THERMISTOR_1_THRESHOLD_CROSS_EVT: >> + dev_dbg(dev, "Thermistor 1 threshold crossed\n"); >> + break; >> + case EC_THERMISTOR_2_THRESHOLD_CROSS_EVT: >> + dev_dbg(dev, "Thermistor 2 threshold crossed\n"); >> + break; >> + case EC_THERMISTOR_3_THRESHOLD_CROSS_EVT: >> + dev_dbg(dev, "Thermistor 3 threshold crossed\n"); >> + break; >> + case EC_RECOVERED_FROM_RESET_EVT: >> + dev_dbg(dev, "EC recovered from reset\n"); >> + break; >> + default: >> + dev_dbg(dev, "Unknown EC event: %d\n", val); >> + break; >> + } >> + > > > ... > >> + >> + ret = devm_request_threaded_irq(dev, client->irq, NULL, qcom_ec_irq, >> + IRQF_ONESHOT, "qcom_ec", ec); >> + if (ret < 0) >> + return dev_err_probe(dev, ret, "Failed to get irq\n"); > > No need for message, just return ret. > Will do. I'll drop the message and just return ret. >> + >> + i2c_set_clientdata(client, ec); >> + >> + ret = qcom_ec_read_fw_version(dev); >> + if (ret < 0) >> + return dev_err_probe(dev, ret, "Failed to read ec firmware version\n"); >> + >> + ret = qcom_ec_thermal_capabilities(dev); >> + if (ret < 0) >> + return dev_err_probe(dev, ret, "Failed to read thermal capabilities\n"); >> + >> + ret = qcom_ec_sci_evt_control(dev, true); >> + if (ret < 0) >> + return dev_err_probe(dev, ret, "Failed to enable SCI events\n"); >> + >> + ec->ec_cdev = devm_kcalloc(dev, ec->thermal_cap.fan_cnt, sizeof(*ec->ec_cdev), GFP_KERNEL); >> + if (!ec->ec_cdev) >> + return -ENOMEM; >> + >> + for (i = 0; i < ec->thermal_cap.fan_cnt; i++) { >> + struct qcom_ec_cooling_dev *ec_cdev = &ec->ec_cdev[i]; >> + char name[EC_FAN_NAME_SIZE]; >> + >> + snprintf(name, EC_FAN_NAME_SIZE, "qcom_ec_fan_%d", i); >> + ec_cdev->fan_id = i + 1; >> + ec_cdev->parent_dev = dev; >> + >> + ec_cdev->cdev = thermal_cooling_device_register(name, ec_cdev, >> + &qcom_ec_thermal_ops); >> + if (IS_ERR(ec_cdev->cdev)) { >> + dev_err_probe(dev, PTR_ERR(cdev), >> + "Thermal cooling device registration failed\n"); >> + ret = -EINVAL; > > Why do you override actual return code? > I'll fix this to propagate the actual error code. >> + goto unroll_cooling_dev; >> + } >> + } >> + >> + return 0; >> + >> +unroll_cooling_dev: >> + for (i--; i >= 0; i--) { >> + struct qcom_ec_cooling_dev *ec_cdev = &ec->ec_cdev[i]; >> + >> + if (ec_cdev->cdev) { >> + thermal_cooling_device_unregister(ec_cdev->cdev); >> + ec_cdev->cdev = NULL; >> + } >> + } >> + >> + return ret; >> +} > > > Best regards, > Krzysztof Thanks for the review. -- Best Regards, Anvesh