From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BAFC433EF for ; Tue, 24 May 2022 16:14:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238339AbiEXQOL (ORCPT ); Tue, 24 May 2022 12:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiEXQOI (ORCPT ); Tue, 24 May 2022 12:14:08 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB627E1DA; Tue, 24 May 2022 09:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=XGDP2IvqeiAPfkB1fEXqR1oCpPgMjf7+++fKTxZ22jU=; b=cJ1yIMVCtQ7ipXSQVLynmD/FfD 486cR3k3hKaBGM4cHLtcE/kP06K/K0wdkObYYS4+dbSlsI0lL2ifA/bnTviOWlnT/J06O28dJHv/x n+QM10yo2srfShlTRLfzcwhBajjgS10V3gN8co2PUwLLf5S3E079W7I5nRbfMh0lYHVncGi0uSN0Z njte8dfnPAmKZh7Q6izRGtR19ngHlVhcT31/5cbE645HGcOO1lzMK1h9lhXufk88p1OAoTQmwTSwU lydgqcnkOQQ7qzaE3vgiA7FBgHbDFW4HstjH+r6wTxXh/Q9di3lcluztfn6da0yKNLFUKRXAVx/4J af1T2Mlg==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ntXAa-006Rce-9A; Tue, 24 May 2022 10:14:05 -0600 Message-ID: Date: Tue, 24 May 2022 10:14:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-CA To: Song Liu , Donald Buczek Cc: open list , linux-raid , Christoph Hellwig , Guoqing Jiang , Xiao Ni , Stephen Bates , Martin Oliveira , David Sloan References: <20220519191311.17119-1-logang@deltatee.com> <20220519191311.17119-13-logang@deltatee.com> <62b09487-9223-db3d-2165-789a51230060@molgen.mpg.de> From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: song@kernel.org, buczek@molgen.mpg.de, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, hch@infradead.org, guoqing.jiang@linux.dev, xni@redhat.com, sbates@raithlin.com, Martin.Oliveira@eideticom.com, David.Sloan@eideticom.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-05-23 12:15, Song Liu wrote: > On Sun, May 22, 2022 at 11:47 PM Song Liu wrote: >> Maybe we should move the definition of r5l_log to raid5-log.h? > > Or we can use READ_ONCE(conf->log) for most cases. READ_ONCE() will still generate sparse errors. Logan