From: Andrew Lunn <andrew@lunn.ch>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2
Date: Mon, 26 Feb 2024 16:52:26 +0100 [thread overview]
Message-ID: <b601e76e-47ac-4670-9ab6-bfec9beedd8f@lunn.ch> (raw)
In-Reply-To: <TY3P286MB2611E440DA1D914C1A0307F7985A2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
On Mon, Feb 26, 2024 at 11:42:49PM +0800, Shengyu Qu wrote:
> Hi Andrew,
>
> So I should describe in commit message that user should set the stick to
> 2.5g/automatic mode and include the link in previous mail? Is that enough?
As Russell pointed out, this sounds racy. We need lots of details in
the commit message to convince us this is safe, and is not going to
cause a regression. If it does break and cause a regression, having
those details will also help us decide what to do, other than just
revert the change.
The further the devices get from well defined standardised behaviour,
the more details are needed.
Andrew
next prev parent reply other threads:[~2024-02-26 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 13:23 Shengyu Qu
2024-02-26 14:04 ` Russell King (Oracle)
2024-02-26 14:16 ` Shengyu Qu
2024-02-26 14:39 ` Russell King (Oracle)
2024-02-26 14:51 ` Shengyu Qu
2024-02-26 15:06 ` Andrew Lunn
2024-02-26 15:20 ` Shengyu Qu
2024-02-26 15:50 ` Russell King (Oracle)
2024-02-26 15:42 ` Shengyu Qu
2024-02-26 15:52 ` Andrew Lunn [this message]
2024-02-26 15:42 ` Russell King (Oracle)
2024-02-26 15:51 ` Shengyu Qu
2024-02-28 10:42 ` Shengyu Qu
2024-02-28 11:15 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b601e76e-47ac-4670-9ab6-bfec9beedd8f@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®