From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD664570FF; Wed, 23 Sep 2026 21:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790199115; cv=none; b=NPS395FlX4LXZhQjUDB2ACfL7PLEoNz/rqDyQGO1t+sGPkVQO/9mUNTIH2X7iK5/3E623jGQoLgn3oxiBkkk/0wvsMdivpGcBfhg/4vElTPr0nI11/62SOaJ61vy67uTaoLTEdhk4cHR1XyLLizGGbRvHo+ZCUy7A0/iys9Y6dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790199115; c=relaxed/simple; bh=5SAVxGmg7GnelrcPsgVtt3W2kFmCd8Tt9b2GZLTh4zY=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=gWkwzSCl8dGSf28b0Bqfk1VHlzPp4s5JT9FLFTRmZyLYTZSuKQYzXYzM2LF7DZI/6QelMNR0vT5t5OfC2WOm8cSMZ4uEOvEv17Jn6mDiBeHEMA00zrICWlrxcsZ5+nnzax6cEJqBByxu8CrMfM9ESTDoRulJWYEEGuwEZSfMNAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LRHixrlv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LRHixrlv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C63031F000FF; Wed, 23 Sep 2026 21:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790199113; bh=5SAVxGmg7GnelrcPsgVtt3W2kFmCd8Tt9b2GZLTh4zY=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=LRHixrlvCqA4DP04Yj/XSkiBYsMMYZlDbXvmoCxrq1HDhPJtk+LVGKjcQSv7tmDqO 4fYu7FUCBiTYhpeMS/6aQbisEdSFCiopAELkp7kujX5ljUdBHIg7ra/pgY6Nb3uNeZ LgvJ+iXkvU8D6SJJSUEboJH6S6ui2qK1RaEyLRzEAHSBh6mcIUJNgybbpnfp4J88ce NoHfjItL+pt4PGXQ6KO1Ix1Jcwo/Y0/SmjC6WGZTwfCf92OYBXA+pauq7J8WzQjXYa b4+rkxY6ZtM6QZqyS6rRdFBv5RhKkBtHHEo4oQ0+2vLuUDgL/byVCRaddIYLm3POVd mcv758lKIjMtA== Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 18D991980059; Wed, 23 Sep 2026 17:31:50 -0400 (EDT) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-02.internal (MEProxy); Wed, 23 Sep 2026 17:31:50 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGpc2w2ufMjmJ0kap8IYjs9DfPrMkSQFlAOzp0sPrwE/vrB6G6LACcNgsecPhcLyl /g20MmAILQDVu0ZlSW7Lo9cigxl3519OTOgyM8UAyR1qlsSJMvP2OLuBuCYEy8vwV9/bNQ WQh7FLbGr62pkxIMcPm4sXkf+skT0hS8S8/4fyusGJg9XxMo6tfZoxf/yeVuvn1UVSKtK+ yjpDxHjNgfv6GXN8E2hYbkrxiDycjOFqxFyHgKgVwyw2yLOS7dg0qc1A0/3PCZ0TVcW9qF a8vS5CuOnbW9yqpETq/JNukDtE0dez70dGFdfo8YR4EcapOfSiMdt0JJhH/CoQYunZXEkx 4y7dbz0FO1BNf2ZSmwjaC1o72nLr4BOeYMmL5fn/EJxQkBS8ykwEjFHn3vNe6FqNtH7zih 4Qo6NHaODC5piVE+bwEL1bQ/GGvg5rPtcRTTRPeIGoCiRmmv4LJIk6tRJVtMquknDVezHJ vWQbLQgtDaQvlrTFNM2YyIStqkeNju5IKd4OSczUWM7kL87z7nG7Z+zbUwMIv7rlagqy1v /jnU8At4jogCsmDlfPrvmrtUXUie/We54VcYHwH0jNEnOLdUNAej1KTGMPyThdfDPqpXE9 L6tBNGaVbNgPTadl+LKcwDhKPMUp35itFGnikWAMDTXsn5WTXQrxO+n6zalA X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 3BD3932A0087; Wed, 23 Sep 2026 17:31:47 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AZl98to-mMhc Date: Wed, 23 Sep 2026 23:31:25 +0200 From: "Arnd Bergmann" To: "Greg Ungerer" , linux-m68k@lists.linux-m68k.org Cc: linux-kernel@vger.kernel.org, "Wei Fang" , "Frank Li" , "Shenwei Wang" , imx@lists.linux.dev, Netdev , "Nicolas Pitre" , linux-can@vger.kernel.org, linux-spi@vger.kernel.org, "Vladimir Oltean" , andrew+netdev@lunn.ch, "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" Message-Id: In-Reply-To: <20260907134037.1855408-3-gerg@linux-m68k.org> References: <20260907134037.1855408-1-gerg@linux-m68k.org> <20260907134037.1855408-3-gerg@linux-m68k.org> Subject: Re: [PATCHv3 2/3] net: smc91x: do not use readw()/writew() on ColdFire platforms Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Sep 7, 2026, at 15:37, Greg Ungerer wrote: > Modify the access macros and functions used to access the smsc hardware > registers when used on ColdFire SoC platforms so they do not use readw() > or writew(), or derived functions like ioread16be() and iowrite16be(). > > The current set of readX()/writeX() access methods for ColdFire have > historically been non-standard, in that they mostly access memory > big-endian instead of the expected little-endian. Before fixing the > ColdFire readX() and writeX() supporting code to properly work with > little-endian data existing driver uses need to be fixed. Convert the > smsc driver ColdFire uses of these to use the raw access macros - which > are well defined to be (native) big-endian on ColdFire. This change > requires some byte swapping at time of access to retain existing correct > behavior. > > Signed-off-by: Greg Ungerer Reviewed-by: Arnd Bergmann