From: David Laight <David.Laight@ACULAB.COM>
To: 'Kuniyuki Iwashima' <kuniyu@amazon.com>,
"edumazet@google.com" <edumazet@google.com>
Cc: "akihiro.suda.cz@hco.ntt.co.jp" <akihiro.suda.cz@hco.ntt.co.jp>,
"akihirosuda@git.sr.ht" <akihirosuda@git.sr.ht>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"segoon@openwall.com" <segoon@openwall.com>,
"suda.kyoto@gmail.com" <suda.kyoto@gmail.com>
Subject: RE: [PATCH linux] net/ipv4: ping_group_range: allow GID from 2147483648 to 4294967294
Date: Fri, 2 Jun 2023 10:51:50 +0000 [thread overview]
Message-ID: <b613cbaf569945e3811609a9f10fe0aa@AcuMS.aculab.com> (raw)
In-Reply-To: <20230531225947.38239-1-kuniyu@amazon.com>
From: Kuniyuki Iwashima
> Sent: 01 June 2023 00:00
....
> > > --- a/include/net/ping.h
> > > +++ b/include/net/ping.h
> > > @@ -20,7 +20,7 @@
> > > * gid_t is either uint or ushort. We want to pass it to
> > > * proc_dointvec_minmax(), so it must not be larger than MAX_INT
> > > */
> > > -#define GID_T_MAX (((gid_t)~0U) >> 1)
> > > +#define GID_T_MAX ((gid_t)~0U)
Doesn't that comment need updating?
I do wonder how much code breaks for gid > MAXINT.
How much testing does it actually get??
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-06-02 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANn89iK13jkbKXv-rKiUbTqMrk3KjVPGYH_Vv7FtJJ5pTdUAYQ@mail.gmail.com>
2023-05-31 22:59 ` Kuniyuki Iwashima
2023-06-01 0:36 ` Akihiro Suda
2023-06-02 10:51 ` David Laight [this message]
2023-06-02 13:03 ` Akihiro Suda
2023-05-31 10:42 ~akihirosuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b613cbaf569945e3811609a9f10fe0aa@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akihiro.suda.cz@hco.ntt.co.jp \
--cc=akihirosuda@git.sr.ht \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=segoon@openwall.com \
--cc=suda.kyoto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®