From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FF4C433F5 for ; Wed, 13 Apr 2022 19:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238452AbiDMTnk (ORCPT ); Wed, 13 Apr 2022 15:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238305AbiDMTng (ORCPT ); Wed, 13 Apr 2022 15:43:36 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB29D78067; Wed, 13 Apr 2022 12:41:13 -0700 (PDT) Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1neirM-000F0N-13; Wed, 13 Apr 2022 21:41:00 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neirL-000Bl2-HH; Wed, 13 Apr 2022 21:40:59 +0200 Subject: Re: [PATCH v4 sysctl-next] bpf: move bpf sysctls from kernel/sysctl.c to bpf module To: Luis Chamberlain Cc: Yan Zhu , andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org, kpsingh@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, liucheng32@huawei.com, netdev@vger.kernel.org, nixiaoming@huawei.com, songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com, yzaikin@google.com, zengweilin@huawei.com, leeyou.li@huawei.com, laiyuanyuan.lai@huawei.com References: <20220407070759.29506-1-zhuyan34@huawei.com> <3a82460b-6f58-6e7e-a3d9-141f42069eda@iogearbox.net> From: Daniel Borkmann Message-ID: Date: Wed, 13 Apr 2022 21:40:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.5/26511/Wed Apr 13 10:22:45 2022) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/22 9:00 PM, Luis Chamberlain wrote: > On Wed, Apr 13, 2022 at 04:45:00PM +0200, Daniel Borkmann wrote: >> On 4/7/22 9:07 AM, Yan Zhu wrote: >>> We're moving sysctls out of kernel/sysctl.c as its a mess. We >>> already moved all filesystem sysctls out. And with time the goal is >>> to move all sysctls out to their own subsystem/actual user. >>> >>> kernel/sysctl.c has grown to an insane mess and its easy to run >>> into conflicts with it. The effort to move them out is part of this. >>> >>> Signed-off-by: Yan Zhu >> >> Acked-by: Daniel Borkmann >> >> Given the desire is to route this via sysctl-next and we're not shortly >> before but after the merge win, could we get a feature branch for bpf-next >> to pull from to avoid conflicts with ongoing development cycle? > > Sure thing. So I've never done this sort of thing, so forgive me for > being new at it. Would it make sense to merge this change to sysctl-next > as-is today and put a frozen branch sysclt-next-bpf to reflect this, > which bpf-next can merge. And then sysctl-next just continues to chug on > its own? As-is my goal is to keep sysctl-next as immutable as well. > > Or is there a better approach you can recommend? Are you able to merge the pr/bpf-sysctl branch into your sysctl-next tree? https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/log/?h=pr/bpf-sysctl This is based off common base for both trees (3123109284176b1532874591f7c81f3837bbdc17) so should only pull in the single commit then. Thanks, Daniel