From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbdBYSWc (ORCPT ); Sat, 25 Feb 2017 13:22:32 -0500 Received: from mail-pg0-f51.google.com ([74.125.83.51]:36205 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdBYSWa (ORCPT ); Sat, 25 Feb 2017 13:22:30 -0500 Subject: Re: [GIT PULL] Block pull request for- 4.11-rc1 To: "hch@lst.de" References: <1D08B61A9CF0974AA09887BE32D889DA0A74F3@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <633d226d-cec3-a01f-a069-ffff307e9715@kernel.dk> <20170220073539.GA17687@lst.de> <1D08B61A9CF0974AA09887BE32D889DA0A8CBD@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <1487957968.2575.6.camel@sandisk.com> <0af4ed69-a9d0-44be-701c-ced76b84bfef@kernel.dk> <0dc039e5-58c5-d328-0b81-bf9e7d782675@kernel.dk> <20170225181704.GB27774@lst.de> Cc: Linus Torvalds , Bart Van Assche , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" From: Jens Axboe Message-ID: Date: Sat, 25 Feb 2017 11:22:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170225181704.GB27774@lst.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2017 11:17 AM, hch@lst.de wrote: > On Fri, Feb 24, 2017 at 01:22:42PM -0700, Jens Axboe wrote: >> Bart, I pushed a fix here: >> >> http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=61febef40bfe8ab68259d8545257686e8a0d91d1 > > Yeah, this looks fine to me. It was broken on blk-mq before, but > basically impossible to hit. I wonder if we should have a debug mode > where we set requests to a known pattern after they are freed to catch > these sort of bugs. tio/md would probably never change for the same set of requests, so it worked by happy accident before. Some of the blk-mq state remains valid after "freeing" a request, but we could selectively fill and definitely fill the entire PDU area with free poison. -- Jens Axboe