From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbcFCPKg (ORCPT ); Fri, 3 Jun 2016 11:10:36 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:24844 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbcFCPKe convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 11:10:34 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=ab57soCY0Ltno2YySk/381eSz6PtYoO3g2klfUFIpQai2uv13cf9XxaA xyoq2JcuAlpv46Z8QufS4hBOk174IRKC4yFojHu2qGuEA1ay+VZaqZti3 b7uID1oQQm1aCelE+avDMoNeULymVY/p+6MPOZqJ/JGszRGTqXbjBJMDD 4=; X-LoopCount0: from 10.170.28.39 X-IronPort-AV: E=Sophos;i="5.26,412,1459832400"; d="scan'208";a="940733088" From: To: CC: , , , , , Subject: RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Topic: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Index: AQHRvO/4qOkaZaVerUSL1iyCPJzWv5/WudCAgAAN+QD//6/tUIAA2feAgACIDCA= Date: Fri, 3 Jun 2016 15:10:32 +0000 Message-ID: References: <1464886687-16284-1-git-send-email-mario_limonciello@dell.com> <1464886687-16284-2-git-send-email-mario_limonciello@dell.com> <20160602174808.GA32131@kroah.com> <2d81e70165b8447d92b873eafeaeded7@ausx13mpc124.AMER.DELL.COM> <20160603020139.GA3668@kroah.com> In-Reply-To: <20160603020139.GA3668@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.11.181.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, June 2, 2016 9:02 PM > To: Limonciello, Mario > Cc: hayeswang@realtek.com; linux-kernel@vger.kernel.org; > netdev@vger.kernel.org; linux-usb@vger.kernel.org; pali.rohar@gmail.com; > anthony.wong@canonical.com > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Thu, Jun 02, 2016 at 06:32:42PM +0000, Mario_Limonciello@Dell.com > wrote: > > > And you want to check this for all Dell devices? Please be model > > > specific, I doubt a bunch of Dell servers wants to run this code... > > > > > > > Tracking model specific is really going to turn into a giant list never ending > list. > > To drill down more specifically, I can match on chassis too. > > Yes, as this is a vendor/platform-specific "quirk", you will have to > update it for each and every individual device you want it enabled as it > is so different from what all other drivers do. > > thanks, > > greg k-h After finding out that there is a characteristic specific to Realtek chip in this USB device, I think it would be best to only run the \\_SB.AMAC lookup when this specific USB device is connected. Realtek is not maintaining a whitelist of systems in their driver for the other OS, they approach it from the other end and only lookup auxiliary MAC if the right device is plugged in.