From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D0304377B7 for ; Thu, 8 Jan 2026 09:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864220; cv=none; b=Ab3iL2LsPNa/3tsAtgofpRQ/EV4JUAQ9/bhgR556JzYZ15eOobDfdphSVLK87iBLFLUEv5c6WDwahq4Pic5bkLG891Nu/mZrk6BzhQUmr1Y039mua2L8jADs86KEpPwLuP8E0KwWt4c+df01tIbIHaU0Pmj0Y+hqyBa6nVGgxM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864220; c=relaxed/simple; bh=EzZbmWi0Ae3MR5seeMt67qb7nX2NVZq6FalMDcWCzJI=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ltMvO/FCDy6IGhac/oeb9RaJFIzBiGiLVsD5PU2mKc+h0qHiVuhZ+PTLt6g4k8MPz6TW/juidGXfLBytgYkGvD28nF7L03JcU9pHA1Ia+mcfj/35CEmFnVWkzeFX9wCsp2anuPtRDp+SByyIV+yLRdalir8kHhEUEcUfTjteAx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tfbPC6M1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tfbPC6M1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04F93C116C6; Thu, 8 Jan 2026 09:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767864219; bh=EzZbmWi0Ae3MR5seeMt67qb7nX2NVZq6FalMDcWCzJI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=tfbPC6M1BkWyupJkKknJTyGvVa1NZ8OFAUUItB5Y/D+eKvL4WFQv4wbDMAAejsxbH +fXZh3Q58xJKE5XbSCAhht5SkwiS4G5NHFVEf3zRPMu1O//Ea9KPu+GilwzS2VUv9O 6W5UZiMdFPldDThPtkbLCRJcsCIQHAZKcg0KEn+v90aC56r3fDTsVLSnjJXU3+5L0e hBppqIdvZSETHYILQKhY3cYKnWZY9Aq5HbKGy/V97HmB1zqtVr46RF3ZyBlWq7qeqn BWwZ8I/ZArNoli2Sk0njwSnPbWL+d0knRcg4ABoMupDUr3W5K6lrW2BWh3FQCtdnOu J+D8vDG3r/MAw== Message-ID: Date: Thu, 8 Jan 2026 17:23:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Barry Song <21cnbao@gmail.com>, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/5] f2fs: fix large folio read corner cases for immutable files To: Nanzhe Zhao , Jaegeuk Kim References: <20260105153101.152892-1-nzzhao@126.com> <10088351.1d0d.19b9b64c92b.Coremail.nzzhao@126.com> Content-Language: en-US From: Chao Yu In-Reply-To: <10088351.1d0d.19b9b64c92b.Coremail.nzzhao@126.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/8/2026 10:17 AM, Nanzhe Zhao wrote: > Hi Kim, > At 2026-01-07 11:08:50, "Jaegeuk Kim" wrote: >>> Hi Nanzhe, >>> >>> fyi - I applied the beginning two patches first. >>> >>> Thanks, >>> > > Thanks for applying my small changes. > > By the way, I’d like to discuss one more thing about testing for large folios. > It seems the current xfstests coverage may not be sufficient. Would it be > welcome for me to contribute some new test cases upstream? Great, please go ahead, new testcase can be added into tests/f2fs/ directory. > > Also, I think large-folio functionality might also need black-box testing such > as fault-injection, where we force certain paths to return errors and verify > behavior under failures. I’d appreciate your thoughts. It's fine to introduce a new help f2fs_fsverity_verify_page() and inject error there. Thanks, > > Thanks, > Nanzhe > > > > > > > > > >