From: Dan Murphy <dmurphy@ti.com>
To: <mkl@pengutronix.de>, <wg@grandegger.com>
Cc: <linux-can@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH can-next 1/2] can: tcan4x5x: Rename parse_config function
Date: Wed, 23 Sep 2020 13:06:23 -0500 [thread overview]
Message-ID: <b61b1a65-90c6-5380-d4ba-d8efcdb42094@ti.com> (raw)
In-Reply-To: <057bc43f-7db5-de7e-dbf5-8bfe324a973e@ti.com>
Mark and Wolfgang
On 4/28/20 2:48 PM, Dan Murphy wrote:
> Marc
>
> On 2/27/20 12:38 PM, Dan Murphy wrote:
>> Rename the tcan4x5x_parse_config function to tcan4x5x_get_gpios since
>> the function retrieves the gpio configurations from the firmware.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> drivers/net/can/m_can/tcan4x5x.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/can/m_can/tcan4x5x.c
>> b/drivers/net/can/m_can/tcan4x5x.c
>> index 9821babef55e..37d53ecc560b 100644
>> --- a/drivers/net/can/m_can/tcan4x5x.c
>> +++ b/drivers/net/can/m_can/tcan4x5x.c
>> @@ -381,7 +381,7 @@ static int tcan4x5x_disable_state(struct
>> m_can_classdev *cdev)
>> TCAN4X5X_DISABLE_INH_MSK, 0x01);
>> }
>> -static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>> +static int tcan4x5x_get_gpios(struct m_can_classdev *cdev)
>> {
>> struct tcan4x5x_priv *tcan4x5x = cdev->device_data;
>> int ret;
>> @@ -507,7 +507,7 @@ static int tcan4x5x_can_probe(struct spi_device
>> *spi)
>> if (ret)
>> return ret;
>> - ret = tcan4x5x_parse_config(mcan_class);
>> + ret = tcan4x5x_get_gpios(mcan_class);
>> if (ret)
>> goto out_power;
>
> I noticed this series never was reviewed and applied. They are still
> applicable and were requested changes.
>
Did you need me to combine all the patches on a m_can-next branch and
submit a PR after test?
There are quite a few patches out there and they all seem relevant.
Dan
> Dan
>
prev parent reply other threads:[~2020-09-23 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:38 Dan Murphy
2020-02-27 18:38 ` [PATCH can-next 2/2] net: m_can: Fix freeing of can device from peripherials Dan Murphy
2020-04-28 19:48 ` [RESEND PATCH can-next 1/2] can: tcan4x5x: Rename parse_config function Dan Murphy
2020-09-23 18:06 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b61b1a65-90c6-5380-d4ba-d8efcdb42094@ti.com \
--to=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®