From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792569860; b=AGMz5zr31YpB7XI36B2YRg0aQ8QtvO1GkTtsjK/0Ic8YLnGHaf19oeCAN8g4xtgrq/34 xXLgRfFNZp02wPSZZEW3KfBCAY6LX1jrZ+35LBFaBU7SGtiEN+ldNyQv94Y4cip1Er/9T SKMk9b6dZup6FNCtFSEcv9mR9rm3otgkby0RXeKJtzB0thdU8MpG8L91x2xMs1+g0Lw/J C1PdpDyeMOXNU+MwNuBwRiGIR/WCua/IfjG9Xmt3Tg/pK3ladJSU4sm0p5YgN/WDFMGDV VXPKk3ApWW4PcGhYHtC7VR4M1mQAyoPfZXRviQJO0XzyDJgJ2AaR81HDVyNsdiJDsJw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792569860; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=376e3NZ04AYvXJ05krt9Fdz8ClOb73elsktpTuyFrOM=; b=24IW5F6wLlaDLG3Luk62NdQHkcFIHwbPKV6MFh2+hKnafBy7XkaHc15eYv3hMBwt6Ikg 6b0hrYlZbSSwmoQmA2t88AnYenFQc/GbvIVK5GZEl72XRrvvRVRlERXxQ3HvFi9svG9Zs 6N3mo2areUZivYZMUcuMF5qCP2KxnuoG2TVlX/Z7/8F2YDHWFoWiWjiElNFCAYWDUOYeC jh1Hbzsf/HfK/Kpsq2TUgPE7QhQ1K67q3ikCwyldDJnZ8vABDNzZRXauQS7Iq6PwWGmfa CngCFtECwcrhFOThN+E6qtO6wjetJ8UBpf/oS8A1G5zl5pPouxh/YtlTlvrAv1ytblw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mrO1mXf7; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kRyQHIqR; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F049E606A31C for ; Wed, 21 Oct 2026 08:04:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F049E606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mrO1mXf7; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kRyQHIqR Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69L5jI742848123 for ; Wed, 21 Oct 2026 08:04:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 376e3NZ04AYvXJ05krt9Fdz8ClOb73elsktpTuyFrOM=; b=mrO1mXf7S9FLD5rt zKEStQDCnxwR4ZDxHSlqz3JTMFtg3oROyZU5AEL+R3ooq3uwBCRJeyqdJLHRCRRI Yje7ETm+9urgF9k2KzPwRzNV+cbyV+Vi9zXzVPtHdBmydn3WLjN1cXLOUY5oYp7l 0sYyvlI5KgIqc5PhEtyXtcVoBtlbnpGa6v5XuOZfjjOPcNE8fHV2jQSb8LaYUz1b louPFnH5RuizqSBpbwmd6CdWh1i9ucm1fIkNULWBrbKBUsDUeyGwKYQR8p65/Pei RPMD7S8ks94DhKIL3V3hNZk3s5yPSG6vWFXq7SALTpBpz49CknchAmL0pwvnTZJh 0wcElQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4heeb9aggu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 21 Oct 2026 08:04:18 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93f3960dca5so15142985a.0 for ; Wed, 21 Oct 2026 01:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792569858; x=1793174658; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=376e3NZ04AYvXJ05krt9Fdz8ClOb73elsktpTuyFrOM=; b=kRyQHIqRh1abyHBwXj9qN2pXyLNMPAdpUqEUtNyDDOpWat1pwCbj5e5fi7saFrlfoB 9rWuvqhzxXAh33b8cp2x0Q/fanZk+wiGjANin+99KwOGv3gp9noJVsiorJM/YwMDNvkj xsemtIrF9CwsML1IjYBByuppZpAe3GeArCYWgt8S7iPl5P3UGRlDgeWbwdSyKKmLMxo0 ouDZ5yZU0cWVUSMm8VvNlHomYfjlDxb4zx35a0UpkE/Uv+4nR4njWOUp4IQWTsyFYWzB KDB0H+o+XrC9mSbCBlYD6W0lIMNvGaCdEiTuSa85vet8RgWohJqLFmQn/7OtS6UbpbUB JHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792569858; x=1793174658; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=376e3NZ04AYvXJ05krt9Fdz8ClOb73elsktpTuyFrOM=; b=M1DRbyneckqdIdaNDR0AUzr/I/4ORDkZlEjYec4qU7imzr14EQLUoyDn/47Xqlyd+S KX8pqwoifaOcgAjBfEj+uGz6EQ9UmZSFhfPHRcnT2BwksUVQasy525BQbKgZAGFna/A6 xsc3gfUZlRthdrHzlbmv0DuS/9OWaXiCKe/Dt24OZNZYML0Y+O6VQJojv+9KJ2OqLJAs if/zfdfUgiKcdnBH1Wx7+2LdXexxcJRBju4deBpnSJLbjVljWjcHalvJhPNqitZvCSfV 0QyIyIbpjy6PMmgW6eNPzSSGKFKH6fk75M6ShCrX1DZGnhAtkIxbo+UGXFSfpSa2jI4H hZ5w== X-Forwarded-Encrypted: i=1; AKwUvBxpCEeCHsz09TlZnj6lGQh/xSn1Ck508edl9/OnpM2PWYvonKiqQwJHT+KOt12jB7oVJh7+w+iB83V/dU0=@vger.kernel.org X-Gm-Message-State: AFq9FYJl2NB3j1KM1Df/zMUBl/nM1qircojuEMjfM2vidaaYCU5ff0a2 3miadkJHGrjZGNYJ+l4lwdhWFg5OZPVkyW9JEGocciAhlL6ijXrwxix2MTmJQn+olgUh0TWI+oh 6bhIvkrloG6cUPWppMVUzV/6VaUQI4K/0p9WqyrUTbb+oVap+NEKBQLwT+5JYPfggqpQ= X-Gm-Gg: AYBFou0ka9h0CqAjh795WRFESooOGoaQMD7ydzwLmwJ21RYEWHtZ9oWQxiBrweYShs0 yO1lYjJSpoc72yxUc4CyeFSS/PZPs/kxkAgE23hpu22z4iBuAoSffIejmtgjN5Zv0mlZro4b/lv uUpRqdUNDja+nBLwhTRRIEXbLVmqtcXQrlEdRX7fEymKhfwTk8xDuYSjerZxZc+vUOhx2yLT0iJ mC3lKl5CFpMgzQd/mabVN56FckK7jEI3AGut/JhF2cKjgbydJXUqutGUuBn29z7YfKwhlCvxM/T HXXmHq/ZvGpwGdJF6LBDOmY2KX0lRP8YxozT70BDLBrydUAw+4iW+qPE6QNjn1gW1RYCueseiNr Zt07K14enUkwsGzqBHOQVww== X-Received: by 2002:a05:620a:45aa:b0:939:9205:4d78 with SMTP id af79cd13be357-93f57f96010mr324547685a.3.1792569857918; Wed, 21 Oct 2026 01:04:17 -0700 (PDT) X-Received: by 2002:a05:620a:45aa:b0:939:9205:4d78 with SMTP id af79cd13be357-93f57f96010mr324544285a.3.1792569857519; Wed, 21 Oct 2026 01:04:17 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b4030daf5bsm547898a12.6.2026.10.21.01.04.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2026 01:04:15 -0700 (PDT) Message-ID: Date: Wed, 21 Oct 2026 10:04:10 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] clk: qcom: cpu-8996: move off the ACD leg while the PLL speeds up To: Dmitry Baryshkov Cc: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Joonwoo Park , Imran Khan , Rajendra Nayak , Jeffrey Hugo , Maxime Ripard , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Ilia Lin , Loic Poulain , Konrad Dybcio , Yassine Oudjana , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Christopher Obbard References: <20261019-msm8998-fix-clocks-v1-0-370949e4d8a0@oss.qualcomm.com> <20261019-msm8998-fix-clocks-v1-5-370949e4d8a0@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIxMDAzMSBTYWx0ZWRfX6l4x+GgBw+sf Wg6teJGKa7EdpdiJF8bHS7EbYzOsExRWQmLFwis4IShcNyace7cLigAFNJV42axg9lL8yb4vcaQ Fds9t2EOMRR/Yje/4nsC5gf0yGwzyKg= X-Proofpoint-GUID: Jf4v2kOwWKnkFlFBKka_aBn3NFzQ0QU_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIxMDAzMSBTYWx0ZWRfX+85CJEfO6jmm S723ACOIHt1NfFAHpDKwczhjBmBnVrL1BL78VsNG0snTtJ5TU8Qfb3R33LlMIQD/ovbH4fysI1q FpNkJIbY8mVv8k5KE8s7ztrnHYW3c1pFzkUhB6pT/sWBsknZf9xWPYzDXyLq4ULIrJSDVh/H+LH rSLPiNspCubgBllT8SAIcMEpNCT8GUh1uHBb9YJgWUwTsFq7ZOtyEfFUZvzIQvgddXk5nNKVK1h km/ed4B4J1o1JpQsOoqWji1e8+ELizWldJwynpLkiEIM/W7E6c3ZH0EHFP8dgonnR8n91aywCnn 4/deB6FgM335bll67D6GaHMySMWyOsB5vt0tJlwlN/KjTV6N2NJ85p5yz8x/cK3r59sa2xHDRzJ fuVvlJAFGblqXRD08BRQVKXiF8kKeVqUCfZMJd940kWId8G4Yt0iMAKg5Tprd4IcmTKQfX6n5Ub O23gABVKBdFpzFNUmcw== X-Authority-Analysis: v=2.4 cv=R42WitRX c=1 sm=1 tr=0 ts=6ad87202 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=zcdO2QGPM5nA-iYd0ZEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: Jf4v2kOwWKnkFlFBKka_aBn3NFzQ0QU_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-21_02,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610210031 On 10/20/26 12:10 PM, Dmitry Baryshkov wrote: > On Tue, Oct 20, 2026 at 08:52:49AM +0200, Konrad Dybcio wrote: >> On 10/19/26 3:41 PM, Dmitry Baryshkov wrote: >>> The MSM8996 CPU clusters sometimes run at half the rate they report >>> after going up between two frequencies above 600 MHz, and stay there >>> until the cluster drops below 600 MHz. The PLL, the muxes and the rest >>> of the cluster clock registers are all as expected: it is the ACD that >>> latches at half the rate when the PLL is reprogrammed to a higher rate >>> underneath it, and selecting the ACD leg again clears it. The driver >>> only moves off the ACD leg when going below 600 MHz. [...] > Downstream isn't keeping the main output below 1190.4 either. After > pre_set_rate(), cpu_clk_8996_set_rate() asks the HF mux for the target > rate, which makes mux_set_rate() set the PLL rate and then switch the mux. > So the main output follows the PLL up to new/2, e.g. 1075.2 MHz on the > way to 2150.4 MHz, on every increase above 1190.4 MHz. > > The main difference is where the cluster waits before the PLL moves: downstream > first lowers the PLL to 1190.4 MHz and parks the output at 595.2 MHz, while > this patch parks it at old/2. Both are lower than the target rate. Following > the downstream approach would mean reprogramming the PLL from inside the pmux > notifier while CCF is changing the rate of the same tree, which feels incorrect > to me. Also it wouldn't lower the peak. Acked-by: Konrad Dybcio Konrad