From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D117227A91D for ; Tue, 20 Jan 2026 14:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768920627; cv=none; b=s0lJKJhTSx9i7mWvSkKe/koP7dfq/bzWr5tb8AvUUSK5TLBamFuOAZxcafr3W4ZnBzNOS1HQH62GZ9UDfbe1grrdIPY/A+AvGL+2FY6jdokPfj2mpBXpsJ8Hpn2I8bOdsa/+2iQpgmQ0uW9ucauUv2+f2w8S+tXDMa6tzq93htI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768920627; c=relaxed/simple; bh=upXj6WWTZKNboRmBMXf5QV2E1JkSHSdpi5l9R919880=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QrToE46Ee59RAqDnO8VSwhL7ELqvkQc+SF7+Kh8pDJNczxfDXYKn87lfip6ZeUz1hy6sfHcrBug5WG23Dw90v1wcjVRpubInR2ns90yJVzxR5qFnUTaxS+/MJojPCqbph3tc6xAsHscOCEwzaP+32GkhQzOPLF4av0QdaZbocec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lRUQ5VaJ; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lRUQ5VaJ" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-81f3fba4a11so5278861b3a.1 for ; Tue, 20 Jan 2026 06:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768920625; x=1769525425; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bIm0elalg2KtUJFISn8Zrfv+qOvCEqd9XEPFzu+c7x8=; b=lRUQ5VaJyrkzrPjKz17VdTTlly0eLn1s4I52f/rx/T2S2de8URs60LZHop0jPIWHWH jSEA361jh0G5VIRD7bG2G1+mosFn9QYMVQIwkIvFmKe63eZnGsP7cwxzzYMCbtdZ2WXd qYcaEPLkcLicpgjGQiKw7HpdBgsqeTK7jsFLa5QcXzx+UR5Ahmo7gAK0ufZc0BkdXw2+ 1ncKsoNTMAShMJWuMG1lNqKhrY+jQ4Yt4gE0CoS9CMAjnY3Hk26BoDLiaZ1AojAll+YQ M/mmtUxM/DAgLm5alIa4bAPLtdmbvZ0+tFU8l8eyshRWW4pTBjgANtPJEyv4QPDvEkPh deQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768920625; x=1769525425; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bIm0elalg2KtUJFISn8Zrfv+qOvCEqd9XEPFzu+c7x8=; b=uJPA7eBVdJkCHHhyk1GllfmhQeSlJAFMFFja8YOEPj9GXfx9yUTLnttElHa3SbEaQT nHGqCaGkmoW5A2xVaY4ADBNZXafjWEOmFS77ERmmRBrFUONa3I95jNElO5FaTziYN+xc kB9JvdQXhDqyzgcBFJRbDSwDzxayIWXLjRmN2Vjt5K0pWGSF2RgCFSGPy9min0Yjby9l xhAYFvCHLw+y1B2nVq4H2AQYG5xKeG4g6rNnd7QaLtNPuuYRgX25y/jiVdo7VHhViNzI Qi4T0oOqG4W22ep8y2R9fP15mPKvkoUhP6MNSCTdlknV63t0ZcrhVmYy7fLEurAE6qSv EaZg== X-Forwarded-Encrypted: i=1; AJvYcCVPXpVmISQuZinl495gro3aIHpo4jN7TkKuKLOGkt6kND98/cCAE4Vs0MTcs6No2lJqPnA12hpeQNPcLM0=@vger.kernel.org X-Gm-Message-State: AOJu0YzvQY+vErHEI3toMLYdZ3kOz+jWSvzXFYDv9zAnGfdhqUt837MY 2lPv9LSbgk3MWl3YG9M0SEjAZLZLWvzSVEybTEmhsWGuA4roMOgaWqTN X-Gm-Gg: AZuq6aJPNjVKnmilVS0AxT5bNRiIHLcvLJl+rG3+HtW19X+Ko5E3Cnj/PStb8M4Ck7V sukzD1X8f9ojtcIAy039yG9+Ay2gdKWUnq5B+VsV80+0REZCYI/dIjXehZUAUDWxgfiTyeSJFD4 qz9J3SYD3vVFaXHWO7/zOvBpdvIxn8ar6ynJz0W734lNErMw4udk1g78dkK6nd0pp30bw2lqKsJ QWxunoYk0cyjnO3JdNMMzRr+VQDMDNXvBzmCXqcYPEQJw89e/r6U4TmS3Tw4q628RK8f/MhV20j hV/v/Z2JsBGvuOTDHGVsoCQgk+rlmS6HxhJPUMRATEblKufkivzDf3CUUvU88MHx8w2prqw6M6R kPBcJ3qf4f84O1ZPAcTFlku9KweQ8eCWLa2wlkFtWWyG9QYu4EkcpgknCbBRS4wag8L89ECMj+h NbyUbeK8bCOGwO/YI/PSn3jQPmTrB8tzcjhqM= X-Received: by 2002:a05:6a00:1bcc:b0:7b8:ac7f:5969 with SMTP id d2e1a72fcca58-81fe87b2942mr2099646b3a.4.1768920624786; Tue, 20 Jan 2026 06:50:24 -0800 (PST) Received: from [192.168.1.7] ([115.99.251.203]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa108c4dbsm12573861b3a.5.2026.01.20.06.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 06:50:24 -0800 (PST) Message-ID: Date: Tue, 20 Jan 2026 20:20:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: phy: ti,phy-usb3: convert to DT schema To: Rob Herring Cc: Vinod Koul , Neil Armstrong , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260107-ti-phy-v2-0-a1ec27401fff@gmail.com> <20260107-ti-phy-v2-1-a1ec27401fff@gmail.com> <20260115144541.GA3319937-robh@kernel.org> Content-Language: en-US From: Charan Pedumuru In-Reply-To: <20260115144541.GA3319937-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15-01-2026 20:15, Rob Herring wrote: > On Wed, Jan 07, 2026 at 04:11:15PM +0000, Charan Pedumuru wrote: >> Convert TI PIPE3 PHY binding to DT schema. >> Changes during conversion: >> - Define a new pattern 'pciephy' to match nodes defined in DT. >> - Drop obsolete "id" property from the schema. >> >> Signed-off-by: Charan Pedumuru >> --- >> .../devicetree/bindings/phy/ti,phy-usb3.yaml | 127 +++++++++++++++++++++ >> 1 file changed, 127 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml b/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml >> new file mode 100644 >> index 000000000000..41b3828723ae >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml >> @@ -0,0 +1,127 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/ti,phy-usb3.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI PIPE3 PHY Module >> + >> +maintainers: >> + - Kishon Vijay Abraham I >> + >> +description: >> + The TI PIPE3 PHY is a high-speed SerDes (Serializer/Deserializer) >> + transceiver integrated in OMAP5, DRA7xx/AM57xx, and similar SoCs. >> + It supports multiple protocols (USB3, SATA, PCIe) using the PIPE3 >> + interface standard, which defines a common physical layer for >> + high-speed serial interfaces. >> + >> +properties: >> + $nodename: >> + pattern: "^(pciephy|usb3phy|phy)(@[0-9a-f]+)?$" > > Again, don't define your own patterns. Either update the .dts files to > use the established patterns (pcie-phy, usb3-phy, phy) or leave it > undefined here. Sure, I will try to update them in dts. > > Plus the unit-address is not optional as 'reg' is not optional... Okay. > >> + >> + compatible: >> + enum: >> + - ti,phy-usb3 >> + - ti,phy-pipe3-sata >> + - ti,phy-pipe3-pcie >> + - ti,omap-usb3 > > Alphabetical order please. Sure. > >> + >> + reg: >> + minItems: 2 >> + maxItems: 3 >> + >> + reg-names: >> + minItems: 2 >> + maxItems: 3 >> + items: >> + enum: >> + - phy_rx >> + - phy_tx >> + - pll_ctrl > > Do this really need to be any order? Looks to me like this works for all > users in tree: > > minItems: 2 > items: > - const: phy_rx > - const: phy_tx > - const: pll_ctrl This will work, I tested it now. > >> + >> + "#phy-cells": >> + const: 0 >> + >> + clocks: >> + minItems: 2 >> + maxItems: 7 >> + >> + clock-names: >> + minItems: 2 >> + maxItems: 7 >> + items: >> + enum: [wkupclk, sysclk, refclk, dpll_ref, >> + dpll_ref_m2, phy-div, div-clk] >> + >> + syscon-phy-power: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: >> + Phandle/offset pair to system control module register for PHY >> + power on/off. > > Needs constrants on the size: > > items: > - items: > - description: phandle to ... > - description: offset of ... Sure, I will change for the other properties too. > >> + >> + syscon-pllreset: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: >> + Phandle/offset pair to CTRL_CORE_SMA_SW_0 register containing >> + SATA_PLL_SOFT_RESET bit (SATA PHY only). > > Same here. > >> + >> + syscon-pcs: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: >> + Phandle/offset pair to system control module for writing PCS delay value. > > Same here. > >> + >> + ctrl-module: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle of control module for PHY power on. >> + deprecated: true >> + >> +dependencies: >> + syscon-pllreset: >> + properties: >> + compatible: >> + contains: >> + const: ti,phy-pipe3-sata > > Usually we express this the other way around: > > if: > properties: > compatible: > contains: > const: ti,phy-pipe3-sata > then: > required: > - syscon-pllreset > else: > properties: > syscon-pllreset: false > > But that's slightly different as syscon-pllreset is optional for > ti,phy-pipe3-sata in your case. Seems like it should be required if > ti,phy-pipe3-sata? I checked the DTS, it is not a required property. So, I will not change the format. > > >> + >> +required: >> + - reg >> + - compatible >> + - reg-names >> + - "#phy-cells" >> + - clocks >> + - clock-names >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + /* TI PIPE3 USB3 PHY */ >> + usb3phy@4a084400 { >> + compatible = "ti,phy-usb3"; >> + reg = <0x4a084400 0x80>, >> + <0x4a084800 0x64>, >> + <0x4a084c00 0x40>; >> + reg-names = "phy_rx", "phy_tx", "pll_ctrl"; >> + #phy-cells = <0>; >> + clocks = <&usb_phy_cm_clk32k>, >> + <&sys_clkin>, >> + <&usb_otg_ss_refclk960m>; >> + clock-names = "wkupclk", "sysclk", "refclk"; >> + ctrl-module = <&omap_control_usb>; >> + }; >> + >> + - | >> + /* TI PIPE3 SATA PHY */ >> + phy@4a096000 { >> + compatible = "ti,phy-pipe3-sata"; >> + reg = <0x4A096000 0x80>, /* phy_rx */ >> + <0x4A096400 0x64>, /* phy_tx */ >> + <0x4A096800 0x40>; /* pll_ctrl */ >> + reg-names = "phy_rx", "phy_tx", "pll_ctrl"; >> + clocks = <&sys_clkin1>, <&sata_ref_clk>; >> + clock-names = "sysclk", "refclk"; >> + syscon-pllreset = <&scm_conf 0x3fc>; >> + #phy-cells = <0>; >> + }; >> +... >> >> -- >> 2.52.0 >> -- Best Regards, Charan.