mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: realxxyq@163.com, shuah@kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yiqian Xun <xunyiqian@kylinos.cn>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1] selftests/user_events: Fix failures caused by test code
Date: Fri, 21 Feb 2025 08:46:31 -0700	[thread overview]
Message-ID: <b62b6dbf-eeb1-495d-a86b-38f05a17d60e@linuxfoundation.org> (raw)
In-Reply-To: <20250221033555.326716-1-realxxyq@163.com>

On 2/20/25 20:35, realxxyq@163.com wrote:
> From: Yiqian Xun <xunyiqian@kylinos.cn>
> 
> In parse_abi function,the dyn_test fails because the
> enable_file isn’t closed after successfully registering an event.
> By adding wait_for_delete(), the dyn_test now passes as expected.
> 
> Signed-off-by: Yiqian Xun <xunyiqian@kylinos.cn>
> ---
>   tools/testing/selftests/user_events/dyn_test.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> index bdf9ab127488..54c9412f8dee 100644
> --- a/tools/testing/selftests/user_events/dyn_test.c
> +++ b/tools/testing/selftests/user_events/dyn_test.c
> @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
>   
>   	close(fd);
>   
> +	wait_for_delete();
> +
>   	return ret;
>   }
>   

Adding Steve for review.

Steve, please review the patch. If you are happy with it
give me Ack or Reviewed-by if you want to take this through
my tree.

thanks,
-- Shuah



  reply	other threads:[~2025-02-21 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  3:35 realxxyq
2025-02-21 15:46 ` Shuah Khan [this message]
2025-02-21 17:28   ` Steven Rostedt
2025-02-24 19:21     ` Beau Belgrave
2025-02-24 19:26       ` Steven Rostedt
2025-02-24 23:39         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b62b6dbf-eeb1-495d-a86b-38f05a17d60e@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=realxxyq@163.com \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=xunyiqian@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®