mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: avier Martinez Canillas <javierm@redhat.com>,
	Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: Re: REGRESSION: no console on current -git
Date: Fri, 19 Jan 2024 22:14:44 +0100	[thread overview]
Message-ID: <b6350dac-0be6-45f9-9309-d196ea455dea@gmx.de> (raw)
In-Reply-To: <9e09464a-d58c-4f17-9318-26f0813a3023@kernel.dk>

On 1/19/24 22:01, Jens Axboe wrote:
> On 1/19/24 1:55 PM, Helge Deller wrote:
>> Adding Mirsad Todorovac (who reported a similar issue).
>>
>> On 1/19/24 19:39, Jens Axboe wrote:
>>> My trusty R7525 test box is failing to show a console, or in fact anything,
>>> on current -git. There's no output after:
>>>
>>> Loading Linux 6.7.0+ ...
>>> Loading initial ramdisk ...
>>>
>>> and I don't get a console up. I went through the bisection pain and
>>> found this was the culprit:
>>>
>>> commit df67699c9cb0ceb70f6cc60630ca938c06773eda
>>> Author: Thomas Zimmermann <tzimmermann@suse.de>
>>> Date:   Wed Jan 3 11:15:11 2024 +0100
>>>
>>>       firmware/sysfb: Clear screen_info state after consuming it
>>>
>>> Reverting this commit, and everything is fine. Looking at dmesg with a
>>> buggy kernel, I get no frame or fb messages. On a good kernel, it looks
>>> ilke this:
>>>
>>> [    1.416486] efifb: probing for efifb
>>> [    1.416602] efifb: framebuffer at 0xde000000, using 3072k, total 3072k
>>> [    1.416605] efifb: mode is 1024x768x32, linelength=4096, pages=1
>>> [    1.416607] efifb: scrolling: redraw
>>> [    1.416608] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
>>> [    1.449746] fb0: EFI VGA frame buffer device
>>>
>>> Happy to test a fix, or barring that, can someone just revert this
>>> commit please?
>>
>> I've temporarily added a revert patch into the fbdev for-next tree for now,
>> so people should not face the issue in the for-next series:
>> https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/commit/?h=for-next
>> I'd like to wait for Thomas to return on monday to check the issue
>> as there are some other upcoming patches in this area from him.
>
> Given the issue (and that I'm not the only one reporting it), can we
> please just get that pushed so it'll make -rc1? It can always get
> re-introduced in a fixed fashion. I don't run -next here, I rely on
> mainline working for my testing.

I agree, it would be good to get it fixed for -rc1.
So, it's ok for me, but I won't be able to test the revert short time right now.
If you can assure that the revert fixes it, and builds in git-head,
I can now prepare the pull request for Linus now (or he just reverts
commit df67699c9cb0 manually).

Helge

  reply	other threads:[~2024-01-19 21:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 18:39 Jens Axboe
2024-01-19 20:55 ` Helge Deller
2024-01-19 21:01   ` Jens Axboe
2024-01-19 21:14     ` Helge Deller [this message]
2024-01-19 21:22       ` Jens Axboe
2024-01-20  0:27         ` Helge Deller
2024-01-20  0:32           ` Jens Axboe
2024-01-20 18:11             ` Mirsad Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6350dac-0be6-45f9-9309-d196ea455dea@gmx.de \
    --to=deller@gmx.de \
    --cc=axboe@kernel.dk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=regressions@lists.linux.dev \
    --cc=torvalds@linux-foundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®