From: "Fabio Comolli" <fabio.comolli@gmail.com>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: "Ingo Molnar" <mingo@elte.hu>, "Rafael J. Wysocki" <rjw@sisk.pl>,
"Peter Zijlstra" <peterz@infradead.org>,
"Steven Rostedt" <srostedt@redhat.com>,
dsaxena@plexity.net, LKML <linux-kernel@vger.kernel.org>,
"Dave Kleikamp" <shaggy@linux.vnet.ibm.com>,
toralf.foerster@gmx.de
Subject: Re: TSC not updating after resume: Bug or Feature?
Date: Mon, 22 Dec 2008 23:29:49 +0100 [thread overview]
Message-ID: <b637ec0b0812221429m441b9493q97a7ccb82dfc0334@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0812222315460.3723@localhost.localdomain>
OK, it seems that you got it.
The system survived two hibernation / resume cycles without triggering
the warning and, probably the most important part, the dmesg does not
have any "jumps" before the "Force enable HPET on resume" line as
before:
[ 275.647704] PM: Creating hibernation image:
[ 275.648005] PM: Need to copy 177844 pages
[ 275.648005] Intel machine check architecture supported.
[ 275.648005] Intel machine check reporting enabled on CPU#0.
[ 275.648005] Force enabled HPET at resume
[ 275.648005] ACPI: Waking up from system sleep state S4
[ 275.669038] ACPI: EC: non-query interrupt received, switching to
interrupt mode
[ 275.740697] pcieport-driver 0000:00:01.0: setting latency timer to 64
[ 275.740781] pcieport-driver 0000:00:1c.0: setting latency timer to 64
[ 275.740786] pciehp 0000:00:1c.0:pcie02: pciehp_resume ENTRY
...and so on.
As i mentioned in the bug report, to be sure that the bug doesn't
trigger I have to wait at least on day and > 10 hibernation / resumee
cycles.
But with your first patch the bug triggered at the second cycle, so
I'm optimist :-)
I'll keep you informed. Many thanks in advance,
Fabio
On Mon, Dec 22, 2008 at 11:16 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Mon, 22 Dec 2008, Fabio Comolli wrote:
>
>> Won't apply:
>>
>> fcomolli@hawking:~/software/GIT-TREES/linux-2.6> patch -p1 --dry-run <
>> /home/fcomolli/0009c-tglx-debug.patch
>> patching file kernel/sched_clock.c
>> patching file kernel/time/timekeeping.c
>> Hunk #1 succeeded at 49 with fuzz 2 (offset 3 lines).
>> Hunk #2 succeeded at 100 with fuzz 2 (offset 5 lines).
>> Hunk #3 FAILED at 309.
>> 1 out of 3 hunks FAILED -- saving rejects to file kernel/time/timekeeping.c.rej
>>
>> Should I revert you previous one?
>
> Oops, yes.
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2008-12-22 22:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 17:27 Deepak Saxena
2008-12-17 17:50 ` Steven Rostedt
2008-12-18 9:24 ` Peter Zijlstra
2008-12-18 12:39 ` Ingo Molnar
2008-12-18 22:19 ` Rafael J. Wysocki
2008-12-18 22:25 ` Dave Kleikamp
2008-12-18 23:39 ` Rafael J. Wysocki
2008-12-21 16:26 ` Thomas Gleixner
2008-12-21 19:43 ` Thomas Gleixner
2008-12-21 22:43 ` Fabio Comolli
2008-12-22 14:48 ` Thomas Gleixner
2008-12-22 15:00 ` Ingo Molnar
2008-12-22 18:47 ` Thomas Gleixner
2008-12-22 20:36 ` Thomas Gleixner
2008-12-22 20:39 ` Fabio Comolli
2008-12-22 21:13 ` Thomas Gleixner
2008-12-22 21:35 ` Fabio Comolli
2008-12-22 22:05 ` Thomas Gleixner
2008-12-22 22:12 ` Fabio Comolli
2008-12-22 22:16 ` Thomas Gleixner
2008-12-22 22:29 ` Fabio Comolli [this message]
2008-12-22 22:33 ` Thomas Gleixner
2008-12-23 0:28 ` Rafael J. Wysocki
2008-12-23 19:42 ` Fabio Comolli
2008-12-24 14:09 ` Pavel Machek
2008-12-26 8:47 ` Peter Zijlstra
2008-12-22 20:19 ` Fabio Comolli
2008-12-21 20:54 ` Thomas Gleixner
2008-12-23 0:47 ` Rafael J. Wysocki
2008-12-23 7:03 ` Thomas Gleixner
2008-12-23 14:15 ` Rafael J. Wysocki
2008-12-21 21:19 ` Thomas Gleixner
2008-12-23 22:03 ` Deepak Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b637ec0b0812221429m441b9493q97a7ccb82dfc0334@mail.gmail.com \
--to=fabio.comolli@gmail.com \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=shaggy@linux.vnet.ibm.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®