From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbcIJHVw (ORCPT ); Sat, 10 Sep 2016 03:21:52 -0400 Received: from mout.web.de ([212.227.17.11]:52045 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbcIJHVu (ORCPT ); Sat, 10 Sep 2016 03:21:50 -0400 Subject: [PATCH 5/5] ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 09:21:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:HqlwDd2fI6mjWJ/l1u6VWN/HMxOt+qUhSni2j2KOuEO0S/zhf/F khVw7/OUMiGVT6WmLdWUfkEUmCbkyNYm7iNU0z3F/EW0T47ksXSDoZnyOFMdMewxBudGYpK KY5tgKzB9Wvp9AHTQp9O3LNCKNu5ek0cQJ7O8Rip4slucJIctMlTy3GI7DVTlb/hoXQyUSM JY7KivBSsjsRMy03RO05Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:HDJSUAdTwMs=:+ySrHFSiwdvyJYuv/6RdFG d3zZcWoPioagueY9HBNWGJqehfAmrt7002dmiNAhz8HAfvlDygZg3do96/OsArhfEoV4dBn0d gHMXwHnY4ar+muxU0TFGT546rrqHnf/d/UBMjR8pt86H4f+4m3//O1Xxu4+xDKrxkeeKyGDti rOQopxPDcoWDxA1tV1jDyfBlrrDWAg+5ER7ad0h9LVTFp+BAA+zUmoTOC7r963FkRuEhLepYB YwlwKKy7WAfiwgp1Khd4AVB0D736aI6twhGCTa5lS+BvpbmCzf+3wZTBUXNA8sSvjLXRrsLIr +8UNlfG0QQqOUNZ7ARAHiVGzDruOnKhYS0GNJRSZ9oDgEYr8/Dhr0VEEP99ZAD2snYwM2AHcF OtF9giruaaeOotHOnurBPAAo8TV6wIKSdRd6c7QdhfO4SSRS5Nbz3wDdbx0PynVZlhytGTVsn M1dAaJbo/WrePjc/5E6RR5hA8smVfkAn27yPHKyg+C5ogtyalP20aYUVdlA39nDbLh020wNqZ namvtYeBWaeP+fuMlCe40vnXHBlcaXGgdp1Ju1ux/KCwCCcd9jgE4R0spcH+gFzlG1h0jsx23 XW0PdWydE5yMh0p6KkN2JQByptdMJGOGBjTGgBPXtDyfVi8h0YbpnlqaMI74vgk5FW+PRpntz zcujP/ebfqJAS5JYr/MLjiuWN0t8gHEX7Z7hKOYVvD/ePv50vjO6k+Rx8f7+jeWgc08A3KJ1s YBp1GFGV7J/wklFIF/tU0FSXGFt3bgG2Dy6UnB3Bg9pXlsjcLwRVwCulbsdQ5CMeKBGnTGB5s 1pelgjv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 08:56:03 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move an assignment for a local variable to a separate statement in this function. Signed-off-by: Markus Elfring --- drivers/atm/nicstar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 04f5781..c7296b5 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -2023,7 +2023,8 @@ static void dequeue_rx(ns_dev * card, ns_rsqe * rsqe) cell = skb->data; for (i = ns_rsqe_cellcount(rsqe); i; i--) { - if ((sb = dev_alloc_skb(NS_SMSKBSIZE)) == NULL) { + sb = dev_alloc_skb(NS_SMSKBSIZE); + if (!sb) { printk ("nicstar%d: Can't allocate buffers for aal0.\n", card->index); -- 2.10.0