mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: vatsa@in.ibm.com
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Mike Galbraith" <efault@gmx.de>,
	"Arjan van de Ven" <arjan@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Balbir Singh" <balbir@linux.vnet.ibm.com>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] CFS scheduler, -v15
Date: Wed, 6 Jun 2007 11:08:07 +0200	[thread overview]
Message-ID: <b647ffbd0706060208i5666f57eoe96215b636617622@mail.gmail.com> (raw)
In-Reply-To: <20070606074317.GB3274@in.ibm.com>

On 06/06/07, Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
> On Wed, Jun 06, 2007 at 09:01:43AM +0200, Ingo Molnar wrote:
> > [...] and my tree already contains the fixes for rt task's
> > exec_start.
>
> Can I have this snapshot pls? I have to deal with the same issue when
> the current task switches groups and I was planning to fix it by
> introducing a set_curr_task() method in fair_sched_class which
> initializes exec_start and other fields for that task.

Hum.. what about accounting 'exec_time' and updating 'exec_start' in
rt_sched :: dequeue_task_rt() instead (like update_curr() does it in
dequeue_task_fair())?

This way, on RT -> NORMAL transition.. some 'delta_exec' ( between
deactivate_task() ---> activate_task() ) will be accounted later as if
the task was 'sched_fair_class' during this time.. which I think makes
some sense. What do you think?

sched_setscheduler()
{
...
        on_rq = p->on_rq;
        if (on_rq)
                deactivate_task(rq, p, 0);
        oldprio = p->prio;
        __setscheduler(rq, p, policy, param->sched_priority);
        if (on_rq) {
                activate_task(rq, p, 0);
...


> --
> Regards,
> vatsa
>

-- 
Best regards,
Dmitry Adamushko

  reply	other threads:[~2007-06-06  9:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-31 15:09 Ingo Molnar
2007-06-06  6:42 ` Srivatsa Vaddagiri
2007-06-06  7:01   ` Ingo Molnar
2007-06-06  7:43     ` Srivatsa Vaddagiri
2007-06-06  9:08       ` Dmitry Adamushko [this message]
2007-06-06 10:37         ` Balbir Singh
2007-06-06 10:59           ` Srivatsa Vaddagiri
2007-06-06 11:19             ` Dmitry Adamushko
2007-06-06 11:37               ` Srivatsa Vaddagiri
2007-06-06 11:46                 ` Srivatsa Vaddagiri
2007-06-14 12:43                 ` Srivatsa Vaddagiri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b647ffbd0706060208i5666f57eoe96215b636617622@mail.gmail.com \
    --to=dmitry.adamushko@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®