mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: tim.c.chen@linux.intel.com
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Volanomark slows by 80% under CFS
Date: Sat, 28 Jul 2007 14:36:54 +0200	[thread overview]
Message-ID: <b647ffbd0707280536q4a7c5da3he3ec6e2a8a19fc00@mail.gmail.com> (raw)
In-Reply-To: <1185573687.19777.44.camel@localhost.localdomain>

On 28/07/07, Tim Chen <tim.c.chen@linux.intel.com> wrote:
> [ ... ]
> It may make sense to queue the
> yielding process a bit further behind in the queue.
> I made a slight change by zeroing out wait_runtime
> (i.e. have the process gives
> up cpu time due for it to run) for experimentation.

But that's wrong. The 'wait_runtime' might have been negative at this
point (i.e. a task is in the negative 'run-time' balance wrt the
'etalon' nice-0 task). Your change ends up helping such a task to
actually stay closer to the 'left most' element of the tree (or to be
it) and not "further behind in the queue" as your intention is.

I don't know Volanomark's details so refrain from speculating on why
this change "improves" benchmark results indeed (maybe some afected
tasks have
positive 'wait_runtime's on average for this setup).

If you want to make sure (just for a test) a yeilding task is not the
left-most (at least) for some short interval of time (likely to be <=
1 tick), take a look at yield_task_fair() in e.g. cfs-v15.

> Volanomark runs better
> and is only 40% (instead of 80%) down from old scheduler
> without CFS.

40 or 80 % is still a huge regression.


>
> Regards,
> Tim
>

-- 
Best regards,
Dmitry Adamushko

  parent reply	other threads:[~2007-07-28 12:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 22:01 Tim Chen
2007-07-28  0:31 ` Chris Snook
2007-07-28  0:59   ` Andrea Arcangeli
2007-07-28  3:43     ` pluggable scheduler flamewar thread (was Re: Volanomark slows by 80% under CFS) Chris Snook
2007-07-28  5:01       ` pluggable scheduler " Andrea Arcangeli
2007-07-28  6:51         ` Chris Snook
2007-07-30 18:49           ` Tim Chen
2007-07-30 21:07             ` Chris Snook
2007-07-30 21:24               ` Andrea Arcangeli
2007-07-28 13:28   ` Volanomark slows by 80% under CFS Dmitry Adamushko
2007-07-28  2:47 ` Rik van Riel
2007-07-28 20:26   ` Dave Jones
2007-07-28 12:36 ` Dmitry Adamushko [this message]
2007-07-28 18:55   ` David Schwartz
2007-07-29 17:37 ` [patch] sched: yield debugging Ingo Molnar
2007-07-30 18:10   ` Tim Chen
2007-07-31 20:33     ` Ingo Molnar
2007-08-01 20:53       ` Tim Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b647ffbd0707280536q4a7c5da3he3ec6e2a8a19fc00@mail.gmail.com \
    --to=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome