From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760937AbYBAVyr@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760937AbYBAVyr (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Feb 2008 16:54:47 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755366AbYBAVyj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 1 Feb 2008 16:54:39 -0500
Received: from wa-out-1112.google.com ([209.85.146.179]:59693 "EHLO
	wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755463AbYBAVyi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Feb 2008 16:54:38 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=shAO4GG3vxa7OoVXNvULPg1MVJDuszD6kiCxSJQxr4uCW1ouOwN59SrsF5VMiutkbXtyVlPG61zlunM6jXrgfLGigpJXSS/6Ho0aKeYDLtk4NCGFbwRaSuNH9AQgIrxolrUinmXyuLOg73BEGq/RBgAFwMxcCvEbOgB0MDhhz5M=
Message-ID: <b647ffbd0802011354ra2b9494ub59475abad4466aa@mail.gmail.com>
Date: Fri, 1 Feb 2008 22:54:35 +0100
From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>,
       "Rafael J. Wysocki" <rjw@sisk.pl>,
       "Steven Rostedt" <srostedt@redhat.com>,
       "Andrew Morton" <akpm@linux-foundation.org>,
       "Linus Torvalds" <torvalds@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20080201171022.GC2159@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200801272229.48955.rjw@sisk.pl> <200801280226.22013.rjw@sisk.pl>
	 <1201795128.32654.22.camel@lappy> <200801312154.33754.rjw@sisk.pl>
	 <1201867497.32654.49.camel@lappy>
	 <b647ffbd0802010711q744f5023mdbfccd9540556b70@mail.gmail.com>
	 <20080201171022.GC2159@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/02/2008, Ingo Molnar <mingo@elte.hu> wrote:
>
> thanks - i cannot reproduce it on my usual suspend/resume testbox
> because e1000 broke on it, and this is a pretty annoying regression.
> We'll have to undo the hung-tasks detection feature if it's not fixed
> quickly. (there's no point in debugging features that _add_ bugs)

I can reproduce it and Peter's patch does fix it for me.

e.g.
root@earth:/sys/devices/system/cpu/cpu1# time echo 0 > online
real    0m6.743s
root@earth:/sys/devices/system/cpu/cpu1# time echo 0 > online
real    0m7.770s

I've observed delays from ~3 s. up to ~8 s. (out of ~20 tests) so the
10s. delay of msleep_interruptible() might be related but
I'm still looking for the reason why this fix helps (and what goes
wrong with the current code).


>
>         Ingo
>

-- 
Best regards,
Dmitry Adamushko