From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Peter Oruba" <peter.oruba@amd.com>,
"Tigran Aivazian" <tigran@aivazian.fsnet.co.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [x86-tip, patch] rework of the microcode splitup
Date: Tue, 16 Sep 2008 23:43:50 +0200 [thread overview]
Message-ID: <b647ffbd0809161443o5b7bf71aw59853d8d6086ee2d@mail.gmail.com> (raw)
In-Reply-To: <20080914125513.GA22281@elte.hu>
2008/9/14 Ingo Molnar <mingo@elte.hu>:
>
> * Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:
>
>> Ingo, Peter,
>>
>>
>> this version is slightly different from the current one in -tip (added
>> missing vfree()).
>
> i've added the delta patch below. I removed the #if 0's as they are
> ugly. (and editing the file to enable debug printouts is easy anyway)
ok, thanks.
>
> regarding this FIXME:
>
> + /* FIXME! dimm: Why not by means of get_totalsize(hdr)? */
> total_size = (unsigned long) (hdr[4] + (hdr[5] << 8));
>
> please just use get_totalsize(hdr) and get rid of the fixme that way :)
The thing is that it looks like there are 2 headers that contain the size.
'hdr' taken by get_totalsize() is not the same as 'hdr' from which
total_size is calculated here. :^)
A quick search didn't reveal any docs describing the AMD microcode
file format, so I'd rather leave it up to Peter.
>
> Ingo
>
--
Best regards,
Dmitry Adamushko
next prev parent reply other threads:[~2008-09-16 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 9:14 Dmitry Adamushko
2008-09-14 9:18 ` Dmitry Adamushko
2008-09-14 12:55 ` Ingo Molnar
2008-09-16 21:43 ` Dmitry Adamushko [this message]
2001-09-16 22:00 ` [PATCH] x86, microcode rework, v2, renaming Peter Oruba
2008-09-17 13:39 ` [PATCH] x86, microcode rework, v2, renaming cont Peter Oruba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b647ffbd0809161443o5b7bf71aw59853d8d6086ee2d@mail.gmail.com \
--to=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.oruba@amd.com \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome