From: Douglas Gilbert <dgilbert@interlog.com>
To: Bodo Stroesser <bostroesser@gmail.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: martin.petersen@oracle.com, axboe@kernel.dk, bvanassche@acm.org
Subject: Re: [PATCH v3 1/4] sgl_alloc_order: remove 4 GiB limit, sgl_free() warning
Date: Wed, 4 Nov 2020 13:26:45 -0500 [thread overview]
Message-ID: <b64de9eb-408f-f618-0db9-731f8823525a@interlog.com> (raw)
In-Reply-To: <2e94f118-1216-b926-a275-2fb325874b04@gmail.com>
On 2020-11-03 7:54 a.m., Bodo Stroesser wrote:
> Am 19.10.20 um 21:19 schrieb Douglas Gilbert:
>> This patch removes a check done by sgl_alloc_order() before it starts
>> any allocations. The comment before the removed code says: "Check for
>> integer overflow" arguably gives a false sense of security. The right
>> hand side of the expression in the condition is resolved as u32 so
>> cannot exceed UINT32_MAX (4 GiB) which means 'length' cannot exceed
>> that amount. If that was the intention then the comment above it
>> could be dropped and the condition rewritten more clearly as:
>> if (length > UINT32_MAX) <<failure path >>;
>
> I think the intention of the check is to reject calls, where length is so high, that calculation of nent overflows unsigned int nent/nalloc.
> Consistently a similar check is done few lines later before incrementing nalloc due to chainable = true.
> So I think the code tries to allow length values up to 4G << (PAGE_SHIFT + order).
>
> That said I think instead of removing the check it better should be fixed, e.g. by adding an unsigned long long cast before nent
>
> BTW: I don't know why there are two checks. I think one check after conditionally incrementing nalloc would be enough.
Okay, I'm working on a "v4" patchset. Apart from the above, my plan is
to extend sgl_compare_sgl() with a helper that additionally yields
the byte index of the first miscompare.
Doug Gilbert
>> The author's intention is to use sgl_alloc_order() to replace
>> vmalloc(unsigned long) for a large allocation (debug ramdisk).
>> vmalloc has no limit at 4 GiB so its seems unreasonable that:
>> sgl_alloc_order(unsigned long long length, ....)
>> does. sgl_s made with sgl_alloc_order(chainable=false) have equally
>> sized segments placed in a scatter gather array. That allows O(1)
>> navigation around a big sgl using some simple integer maths.
>>
>> Having previously sent a patch to fix a memory leak in
>> sg_alloc_order() take the opportunity to put a one line comment above
>> sgl_free()'s declaration that it is not suitable when order > 0 . The
>> mis-use of sgl_free() when order > 0 was the reason for the memory
>> leak. The other users of sgl_alloc_order() in the kernel where
>> checked and found to handle free-ing properly.
>>
>> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
>> ---
>> include/linux/scatterlist.h | 1 +
>> lib/scatterlist.c | 3 ---
>> 2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
>> index 45cf7b69d852..80178afc2a4a 100644
>> --- a/include/linux/scatterlist.h
>> +++ b/include/linux/scatterlist.h
>> @@ -302,6 +302,7 @@ struct scatterlist *sgl_alloc(unsigned long long length, gfp_t gfp,
>> unsigned int *nent_p);
>> void sgl_free_n_order(struct scatterlist *sgl, int nents, int order);
>> void sgl_free_order(struct scatterlist *sgl, int order);
>> +/* Only use sgl_free() when order is 0 */
>> void sgl_free(struct scatterlist *sgl);
>> #endif /* CONFIG_SGL_ALLOC */
>>
>> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
>> index c448642e0f78..d5770e7f1030 100644
>> --- a/lib/scatterlist.c
>> +++ b/lib/scatterlist.c
>> @@ -493,9 +493,6 @@ struct scatterlist *sgl_alloc_order(unsigned long long length,
>> u32 elem_len;
>>
>> nent = round_up(length, PAGE_SIZE << order) >> (PAGE_SHIFT + order);
>> - /* Check for integer overflow */
>> - if (length > (nent << (PAGE_SHIFT + order)))
>> - return NULL;
>> nalloc = nent;
>> if (chainable) {
>> /* Check for integer overflow */
>>
next prev parent reply other threads:[~2020-11-04 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 19:19 [PATCH v3 0/4] scatterlist: add new capabilities Douglas Gilbert
2020-10-19 19:19 ` [PATCH v3 1/4] sgl_alloc_order: remove 4 GiB limit, sgl_free() warning Douglas Gilbert
2020-11-03 12:54 ` Bodo Stroesser
2020-11-04 18:26 ` Douglas Gilbert [this message]
2020-10-19 19:19 ` [PATCH v3 2/4] scatterlist: add sgl_copy_sgl() function Douglas Gilbert
2020-11-03 13:22 ` Bodo Stroesser
2020-11-03 13:26 ` Bodo Stroesser
2020-10-19 19:19 ` [PATCH v3 3/4] scatterlist: add sgl_compare_sgl() function Douglas Gilbert
2020-11-03 13:24 ` Bodo Stroesser
2020-10-19 19:19 ` [PATCH v3 4/4] scatterlist: add sgl_memset() Douglas Gilbert
2020-11-03 13:28 ` Bodo Stroesser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64de9eb-408f-f618-0db9-731f8823525a@interlog.com \
--to=dgilbert@interlog.com \
--cc=axboe@kernel.dk \
--cc=bostroesser@gmail.com \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®