From: Dave Hansen <dave.hansen@intel.com>
To: Brendan Jackman <jackmanb@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Unify __phys_addr_symbol()
Date: Fri, 24 Oct 2025 10:06:08 -0700 [thread overview]
Message-ID: <b650dc79-1dbb-48d8-bc92-cc468e807ad5@intel.com> (raw)
In-Reply-To: <20250813-phys-addr-cleanup-v1-1-19e334b1c466@google.com>
On 8/13/25 08:08, Brendan Jackman wrote:
> There are two implementations on 64-bit, depending on
> CONFIG_DEBUG_VIRTUAL, but they differ only regarding the presence of
> VIRTUAL_BUG_ON, which is already ifdef'd on CONFIG_DEBUG_VIRTUAL.
>
> To avoid adding a function call on non-LTO non-DEBUG_VIRTUAL builds,
> move the function into the header. (Note the function is already only
> used on 64-bit).
... and just for the record CONFIG_DEBUG_VIRTUAL really is a
debug-build-only thing. I don't see it set in any normal distro kernels.
This shouldn't bloat any normal builds, although it will probably make
CONFIG_DEBUG_VIRTUAL=y build bigger. But I don't think we care about that.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
prev parent reply other threads:[~2025-10-24 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 15:08 Brendan Jackman
2025-10-24 17:06 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b650dc79-1dbb-48d8-bc92-cc468e807ad5@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®