From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701E93D3486 for ; Wed, 25 Feb 2026 14:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772029229; cv=none; b=c67fPuNDp9srPTftC5XutLrzHGDhmGF1iaPtFnEW7BUE+Ci9FAk0uyBhYIlqy8TRt43JWLclmavaIWTBIK9qHLmfLJtzfLUY/AQd8Bs/EIgbGT6UfN9XRz5OTHmCPi1o9m2whMSwULVTeils633Fczmj31shZyBV4bGhzZNWscw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772029229; c=relaxed/simple; bh=HoX+77Ou1KVRWuj52NLOpoMqo5t3Lt0ZrveaYtMn2MI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YqGYWFMP9KU0fcnYwnk4Mz72Js4PLFR6S01ciUVnyHH4zJwplGbMChn1+R6KbFS9rfMag+AZ4fFp43p0YYfFHouqwlYqIYJXuYrlxMx1nlSBjGHZAsTIcU1yEGLGRz16Km1nqO67414Guu2V+p1x2/bbVZ+NM0nULownFhsrF7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lCLZuHlf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kY7oHhmE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lCLZuHlf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kY7oHhmE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PB3Q6P1512011 for ; Wed, 25 Feb 2026 14:20:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EtyOE2hUVljy+kbFE5PibxyFcc/R7aXCK4PQrjUFn2o=; b=lCLZuHlf8TyAjJm3 u3rme9fFAEMEi7u536FDPUL5nlAy5jiQp4VpF1GwY2/RJhELgyk1DwwPJRciUo9f G6UtslgOw5RylV8+vIzZxzMkscSgIcWthwhfKep4VCv3qiZH2jlFNOMtWoa46lcX 6KcSkfDa2N+ZoxRrbkVfKOoXzCQaocEd0HhJDFA+sXLsHChPj9nrDPFepT1nqWVI IZ36rErEHBHfnY7GWhBi1tYt4FOiBTs7/fvZPcQLxGXvO1vVknuj6NlwUVlasWB5 3wFujOQ6K2RIpoDNlYCvW7z0Q1Es0jss86QZ/6e/PluRBy/m1UvZ3r/40OqsZ3/M 2XHL/g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chyvf0g32-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 14:20:27 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2adcab21141so10539515ad.2 for ; Wed, 25 Feb 2026 06:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772029226; x=1772634026; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EtyOE2hUVljy+kbFE5PibxyFcc/R7aXCK4PQrjUFn2o=; b=kY7oHhmEVfNKnl2Ets9P9vugOZO24QTV9ZW+gUYqGvz9rPMJQYeTDaPW8gCyQhT5oX kM1eciXC55RcKkfrgz5j0X8PcKzDzlc0EiV4xc21488ryLkx0xZ5sYyfN43v6Tu531Yq wRmK3xov5ROrDgaFVlnmGeURzJKgjSuv9/ghY6/s9/3xeTHecSGoyUnhaZ8KdC1QSJUS huraSwqyLHE18EPjXfzAm4JMJqYA6GOe6qd37ja9GtijGvwyuHQ4RFl2dCxh8DSLEXOR P8Tgv2BreMhHnnXG1KBNcvn0eUBntXMwkuRoFhT2znJ+8GczSN2UDjpoAMKH8ZRmhkbN vCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772029226; x=1772634026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EtyOE2hUVljy+kbFE5PibxyFcc/R7aXCK4PQrjUFn2o=; b=fPv+XbLBw0rca8spELLNso+HowieJdTzjjcDsai56pllfEwoPZoIx/yVVd3qbFSr85 PPhSDYDxVypTOfFsDoiExmehLy+UKfQwtbpiFqcLRxC0f4C6uj8XWHLjFAhwm/5FVvmx dO4MDBKg7Wu/1CQ8fe2w9N8wV/rZv4LdMHWSYd6lbxjHdX5sm8GIB/Z0gEjVBa7sc6cp +/yQIRYL3Vd7TlgdJLJMDFMNaxyq70hzqrQwkEAIS3o4NZBkwvQGsKmUpp6U12vSG3Uc K3eOLlzQqOB3evNhd1XE0yY1Hxc/OovwWmWKUDXXB3TUiIozXph3Nr8WzLZ4MHYB5uqo dYjA== X-Forwarded-Encrypted: i=1; AJvYcCUKrFBw7bY4t7VLLJGBwkZMI9WlDMAC0fr3SiAIsNNHRynHgjbY+oeUMq/SQPohKi6IkmV7ynyB0PLW5+8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx2hJS3sb1v53+iTAOwDT/4euzSOwuVdWX7FganWIex8892BhP lK7qI14eaqL5lfOjZykANdw8sbzhbhA47ADVD8VINOlOf2zCe6YPKIuEfb6tCoFz2fXBJYLC8ow 0hTqN5ecpaPP2UogFrGVupQpavy3ILRalU34WzpwW4hBsPXqp5ZnX7Y6A7JhCB8p0WgI= X-Gm-Gg: ATEYQzy8h1PqwkcnyOLBi8AXRVDdzBHs2VfpJmbKxX5vjVhQVNvh1QcS8eax8cfzX9e UTbeghRfjYCLUW58r/UXPF9yaod8Ctvv1Gj58U1KBwvApfmxiSODD1j+qGwS/aZjV3zvBU85N2j HonljjhLPu558fKecGUigQs81uffSl5rWvY21hMiwJNqLJ/LU4d7mx6pKU648OXhJKVBILA4vnL lis1F8AfE07bylIub+rWESpD9TJxXYwUqo7HB5eVYesuIES80NsDzN/jqaWkeAE4BPD7PrLO3WQ EGlhU+rd4c1QW+gZ2dXIAY4a+HfTBOf9PLzq2SPFtq2yH3NndjqNc6JwIzV7mrzoBAlpXIbw6ZR GMbsrphL6+NWIAps0VAE5njhp8o/fXvYv3za+Uvg0lk3pLcIjW14= X-Received: by 2002:a17:902:d485:b0:2a9:2ab2:e50d with SMTP id d9443c01a7336-2ade9aa21a7mr3608495ad.51.1772029226469; Wed, 25 Feb 2026 06:20:26 -0800 (PST) X-Received: by 2002:a17:902:d485:b0:2a9:2ab2:e50d with SMTP id d9443c01a7336-2ade9aa21a7mr3608015ad.51.1772029225935; Wed, 25 Feb 2026 06:20:25 -0800 (PST) Received: from [192.168.1.5] ([171.61.227.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74f5e55dsm142051345ad.30.2026.02.25.06.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 06:20:25 -0800 (PST) Message-ID: Date: Wed, 25 Feb 2026 19:50:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 02/18] accel/qda: Add Qualcomm DSP accelerator driver skeleton To: Bjorn Andersson Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Dmitry Baryshkov , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-2-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 4_iyHINn3SvLgsMRDc3nhvKgPQhjsz9w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEzNyBTYWx0ZWRfX2mGZfFTeBDMw VSvNnclg8N5N08ZAqyp6UVlxi0lBDlfTpDhuJH475gQmfd+HxaQE8O+6dgmyRMdMg4RjlRN7naB vMYX3eUJgGub2s1x3YG0wR2KdENFa6p33tJDRDPrQbTyrCMZtD1hAat6KP/njoB4njOzVZLJE6C crqyU7sHF5Ynb6G0bxil/e74e8sq0/ZduvC5bDOeCYy0sAYIQVlEt4Zn8oYDQhVQe+Rr+zT2DbJ WQ9uhlHsSWX3AMvgTwcysgMAxcdlj3uZoaj71xFb90JfFx7jNlu/IYLua3kxanvt5qNphlEP2i6 mTBHuwd3O4wVGJb+Uu5dyozDKvypAfMtoN8m5JZ9yfPJ/az7yZy8RkGUQHBYEiY08TgNwBPkJYl jsAvTlHTirp44tSP6BKsNt0gZZYVLgqGKcZh6YLAYbaHSIQQM+TygUYTNeVrrpY2hZl6oFQNO/c TIq2IpXqHr/5A5zzipg== X-Proofpoint-GUID: 4_iyHINn3SvLgsMRDc3nhvKgPQhjsz9w X-Authority-Analysis: v=2.4 cv=dZWNHHXe c=1 sm=1 tr=0 ts=699f052b cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=CLJ8B99oKJtQbdnoKiLypA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=tV0izz4fD985yFSgC6wA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250137 On 2/24/2026 3:22 AM, Bjorn Andersson wrote: > On Tue, Feb 24, 2026 at 12:38:56AM +0530, Ekansh Gupta wrote: > [..] >> diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c >> new file mode 100644 >> index 000000000000..18b0d3fb1598 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_drv.c >> @@ -0,0 +1,22 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> + >> +static int __init qda_core_init(void) >> +{ >> + pr_info("QDA: driver initialization complete\n"); > This print is useless as soon as you make the driver do anything, please > don't include developmental debug logs. > > > In fact, this patch doesn't actually do anything, please squash things a > bit to give it some meat. > > Regards, > Bjorn Ack, will squash the next commit with this one. > >> + return 0; >> +} >> + >> +static void __exit qda_core_exit(void) >> +{ >> + pr_info("QDA: driver exit complete\n"); >> +} >> + >> +module_init(qda_core_init); >> +module_exit(qda_core_exit); >> + >> +MODULE_AUTHOR("Qualcomm AI Infra Team"); >> +MODULE_DESCRIPTION("Qualcomm DSP Accelerator Driver"); >> +MODULE_LICENSE("GPL"); >> >> -- >> 2.34.1 >> >>