From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: SiByte: Fix missing function prototypes
Date: Wed, 18 Nov 2026 17:13:26 -0800 [thread overview]
Message-ID: <b6546264-4c51-45e4-9728-a433527fb355@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2611180154490.54328@angie.orcam.me.uk>
On 11/17/26 17:57, Maciej W. Rozycki wrote:
> On Fri, 13 Nov 2026, Florian Fainelli wrote:
>
>> The SB1250 SWARM build reports missing prototypes for platform time
>> initialization, SoC setup, IRQ and SMP helpers, and both RTC backends.
>
> Thank you for doing this. I've meant to for a long time, but have been
> distracted with higher priority stuff.
>
>> static inline int __maybe_unused bcm1250_m3_war(void)
>> {
>> - if (IS_ENABLED(CONFIG_SB1_PASS_2_WORKAROUNDS))
>> - return sb1250_m3_workaround_needed();
>> +#ifdef CONFIG_SB1_PASS_2_WORKAROUNDS
>> + return sb1250_m3_workaround_needed();
>> +#else
>> return 0;
>> +#endif
>> }
>
> It seems a style regression, why is this change needed?
The declaration is wrapped under #ifdef CONFIG_SB1_PASS_2_WORKAROUNDS,
which would hide the prototype when the option was disabled. The if
(IS_ENABLED() would not compile in that case since we would have lacked
a visible declaration. We could keep this and just make the prototype
unconditionally visible instead.
Thomas, I can send a v3 as an incremental fixup or complete replacement?
--
Florian
prev parent reply other threads:[~2026-11-19 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 19:19 Florian Fainelli
2026-11-17 16:16 ` Thomas Bogendoerfer
2026-11-18 1:57 ` Maciej W. Rozycki
2026-11-19 1:13 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6546264-4c51-45e4-9728-a433527fb355@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®