From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932969AbdAKUn2 (ORCPT ); Wed, 11 Jan 2017 15:43:28 -0500 Received: from mout.web.de ([217.72.192.78]:62449 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932755AbdAKUnZ (ORCPT ); Wed, 11 Jan 2017 15:43:25 -0500 Subject: [PATCH 06/18] mtd-cfi_cmdset_0001: Use kcalloc() in cfi_intelext_setup() To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Wed, 11 Jan 2017 21:41:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:lZrm/fX+A3UhrrbZ2Qmxnzm08+ojl5WgCmkV4KU9yYlfRQzUF6P NFDIF5i65I8w81NZjy1YRKyo8wk+30/7wpRcC3j1x6T9XAc1aHh7K73dU3DkMIE0H9C1uyC Ob2P+6gbriQi28SeN4LiNlzKbhzBlyUWmxIBkw9VB6lLT8NaDjjtZUoun4grQaraGUPfuXq MrNWIfTdkjXyzOOAkVfoQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:kzph8jZljPs=:uTUoh9AqCF7sCfSu2zI6T+ 7JAJH5AYNX0yRx8YIDkOxnBq6xG7dS7VLBOJulFPpY/ysOTffbykRQxCefz2Cnjx1Qs1mkPU/ 4x+xUH9srOtRY6L98o3r4ZlNVMGtq+RTDMd8JKnLdKyfno+7DXC5kO3x8CqX1AEv/6cOLFFNQ picVs7JNgeDx5R7IbXw1nvtIXhpEeqS0BS76jdyY11LBpIODAJSEhkDTecr/ITJs6idIMe+so OwauGmdMuXlGV+2yuV82YDPlqC98C9nzafAUK5KRMtjqZw7UGdir8usCWrZ6yM4CkvjD1NxvK LJomNTssChRPfDASlBwYlKbhJWskWBDGRF9BieTtiwttnlEH9XDB3N9NZkAPrNgm3YzBqta2U qj00XeTm8GIiI35uARAYaTChAXArDLfo+m0KUjm44qxA9eN6q418ek+GuKMb3A5Q0GL1LjVqC Va9rRCiJAnk8JZibGYsXOzOJiUGCIhGT97R9jwPjEzpCe8QNPc9dV7+CXOvwjJZ3oE6Z9gwBt sD7QNmM+gdgnjlR7laEirv+S2+YAqEJ9TQnfXpcey+nQ5KkFb5H0JYb2HLvX+dAbG0bnPXtrm v5jKHPngXm70ifraM/Uxb6P40CHsRLO0SdGp7NTDWdcbpy75xwmSpTNTf66cvLGsKCmqcVAum 6UywIqYSIVFs4xWtXppW1Fe40s3Ca6INONekLXJZuz+yHahKzfLvgC2Zq4MeUarJzDsSyn/gs LOWEzRnRMKuJ8ZksEqIVQsvrjTcYi5FgfdYOg5QY3pbSibqX4zD3NmZLKd8qrjgKv+GkHk/48 um1PXtJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Jan 2017 16:57:38 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/chips/cfi_cmdset_0001.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index 4b134e8beb93..d7d3d398e4d4 100644 --- a/drivers/mtd/chips/cfi_cmdset_0001.c +++ b/drivers/mtd/chips/cfi_cmdset_0001.c @@ -597,8 +597,9 @@ static struct mtd_info *cfi_intelext_setup(struct mtd_info *mtd) mtd->size = devsize * cfi->numchips; mtd->numeraseregions = cfi->cfiq->NumEraseRegions * cfi->numchips; - mtd->eraseregions = kzalloc(sizeof(struct mtd_erase_region_info) - * mtd->numeraseregions, GFP_KERNEL); + mtd->eraseregions = kcalloc(mtd->numeraseregions, + sizeof(*mtd->eraseregions), + GFP_KERNEL); if (!mtd->eraseregions) goto setup_err; -- 2.11.0