From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF2AC43603 for ; Wed, 11 Dec 2019 13:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF5D3208C3 for ; Wed, 11 Dec 2019 13:31:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cPBdqTvu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729471AbfLKNbS (ORCPT ); Wed, 11 Dec 2019 08:31:18 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55572 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727477AbfLKNbS (ORCPT ); Wed, 11 Dec 2019 08:31:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576071077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TV5FAi/Fe1/Rw5238yLkedzxccC6tTFgA5QXvsNOUGA=; b=cPBdqTvuLa+5hY5Gq+QFSAnKX/xGHYS1LbpsxXy4X2+YwUMCP5rC24944WqAfgM5Yrzj/y PPxc0k22cL4nb+AUDIyo3czgkT0hDtJOj1OcE3ZzWW+lQuHSfWGfqKYNIdg7HuchOaaBcB JTTqieErfk8Ha3MU9bSAdEyMie7xg6s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-02HvtilpNImS-uhka5dcQQ-1; Wed, 11 Dec 2019 08:31:05 -0500 Received: by mail-wr1-f71.google.com with SMTP id y7so9707820wrm.3 for ; Wed, 11 Dec 2019 05:31:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TV5FAi/Fe1/Rw5238yLkedzxccC6tTFgA5QXvsNOUGA=; b=CgyRKnpW6ZUVIJBAdHcZzfiQKZPyDGQ+ee/8fOUN9MFgTgx7PFGkYfK+euI4ZROnXW vTTpGUy+fA/dhf487PNUpnH3HsrUYLcMObaf0df8kYkGj1CJ3z6k0wUdBJe49xRDVj36 tGe3o4RUlzms7/3lAURw/TByUqbiHeqPVh0OPQ0pjECzHXFK4IdkcgmeQ6Hr1jCNc2UB nIfAupKsXrnwmnd+nKf2UDnsgOdR4RZ7Sb3AaiGeOhu/Y88a4KF7PL068eiijp5NgJVH JghAEQLCDfGIIqnDhBbogRW0QJqCl1npNDHjdkj2zfadElFrSx2PE2FJO7G/SOxXmt3p Sk3g== X-Gm-Message-State: APjAAAVGumukxYkLXjwqWsoHq9ofVfmVajAivM+4TXequtu1qBNb3pMv y/fMWl0uRwOhiSRpIStASrfY74jEmNRQ6IaaNL49ajueXOwhIsgyEE9/7HZN16yiKTzr7Kc5NSy Lt59Sotb6a5i4/3pj2ZcJKf4C X-Received: by 2002:a1c:5451:: with SMTP id p17mr3617117wmi.57.1576071064468; Wed, 11 Dec 2019 05:31:04 -0800 (PST) X-Google-Smtp-Source: APXvYqymrCgLwNxNOpQF3dxf3OYmi9fdNcxPA2z09i7pimQR443NM/SqTB9zsjyB+GkU7qbeqV3iXA== X-Received: by 2002:a1c:5451:: with SMTP id p17mr3617098wmi.57.1576071064298; Wed, 11 Dec 2019 05:31:04 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id i5sm2281274wml.31.2019.12.11.05.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 05:31:03 -0800 (PST) Subject: Re: [PATCH 0/8] ata: ahci_brcm: Fixes and new device support To: Florian Fainelli , linux-kernel@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com, Jens Axboe , Rob Herring , Mark Rutland , Philipp Zabel , Tejun Heo , Jaedon Shin , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20191210185351.14825-1-f.fainelli@gmail.com> From: Hans de Goede Message-ID: Date: Wed, 11 Dec 2019 14:31:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191210185351.14825-1-f.fainelli@gmail.com> Content-Language: en-US X-MC-Unique: 02HvtilpNImS-uhka5dcQQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10-12-2019 19:53, Florian Fainelli wrote: > Hi Jens, > > The first 4 patches are fixes and should ideally be queued up/picked up > by stable. The last 4 patches add support for BCM7216 which is one of > our latest devices supported by this driver. > > Patch #2 does a few things, but it was pretty badly broken before and it > is hard not to fix all call sites (probe, suspend, resume) in one shot. > > Please let me know if you have any comments. > > Thanks! The entire series looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > Florian Fainelli (8): > ata: libahci_platform: Export again ahci_platform_able_phys() > ata: ahci_brcm: Fix AHCI resources management > ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE > ata: ahci_brcm: Add missing clock management during recovery > ata: ahci_brcm: Manage reset line during suspend/resume > ata: ahci_brcm: Add a shutdown callback > dt-bindings: ata: Document BCM7216 AHCI controller compatible > ata: ahci_brcm: Support BCM7216 reset controller name > > .../bindings/ata/brcm,sata-brcm.txt | 7 + > drivers/ata/ahci_brcm.c | 167 ++++++++++++++---- > drivers/ata/libahci_platform.c | 6 +- > include/linux/ahci_platform.h | 2 + > 4 files changed, 141 insertions(+), 41 deletions(-) >