From: Andrej Picej <andrej.picej@norik.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: "y.bas@phytec.de" <y.bas@phytec.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] watchdog: da9062: reset board on watchdog timeout
Date: Mon, 29 Nov 2021 13:12:14 +0100 [thread overview]
Message-ID: <b65c9c58-485d-1735-bda2-e750ee8d8a8a@norik.com> (raw)
In-Reply-To: <DB9PR10MB4652529FAC6253C266B172EF80639@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
Hi Adam,
On 26. 11. 21 14:28, Adam Thomson wrote:
>
> I'm a little concerned about forcing this change in the driver. There may be
> platforms which don't want the PMIC to perform a full reset through OTP re-read
> and if we hard code this change then that's impacting those platforms. If we
> want/need this then I think it should probably be a DT binding for da9061/2
> which then indicates the behaviour we want.
Ok, I see the impact this might have on the platforms that are relying
on the current default setting. I will start on the DT binding
implementation and submit a new patch.
>
> NRES_MODE bit also plays a part here as it controls whether or not the nRESET
> line state is changed as part of the power-down/up process. I'm assuming for
> your setup this bit is 0?
>
We leave NRES_MODE as it is, 0 by default I guess? So do you want a
separate dt binding for NRES_MODE?
BR,
Andrej
next prev parent reply other threads:[~2021-11-29 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:32 [PATCH 1/2] mfd: da9062: make register CONFIG_I writable Andrej Picej
2021-11-24 8:32 ` [PATCH 2/2] watchdog: da9062: reset board on watchdog timeout Andrej Picej
2021-11-26 13:28 ` Adam Thomson
2021-11-29 12:12 ` Andrej Picej [this message]
2021-11-30 9:41 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b65c9c58-485d-1735-bda2-e750ee8d8a8a@norik.com \
--to=andrej.picej@norik.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
--cc=y.bas@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®