From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1FA41DA2F6 for ; Mon, 6 Jan 2025 09:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736156065; cv=none; b=H1S9TgOFPpQkYUekBN74NUsGHYu7V8v+F7Lit7LV7xfWWlAk5EUjCqTqA+qAbCR2h0JlHdpiFP4j2WQoB7IeHcCZaZMdS5A/8VmVxWE9PDkZombbPgcu4RHFBcHxfTYB4VFGXQpYP+w/APQAZjiIn8GaKp/No3wUzq3swAFoCE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736156065; c=relaxed/simple; bh=84rYiJ0bytOkvFP6AE2Pb0KyEORYgcVxvqwCyN5uROc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RZ+/5U69ieAA/ag3B8k7Kf+TOUA1/XBDTrliqnCzip8Oj8cdoX0LZlIZk15rDp0DCIPQmqrZxakA6xI0z4JCmyuHo8dyJTuxAYQjeJD+XCWo54g5b41L4bjRkhEA98owJ0uyWSe3KeIEa+6wTeNRW8GeN7meXE/dKfTigY+oocY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=AYv8XxWB; arc=none smtp.client-ip=115.124.30.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="AYv8XxWB" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736156058; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=M8lTSA5py1VNeH7wK2Bn79u4g3AsD2U1AjR2tynOIls=; b=AYv8XxWBSAyp4QZMzqL2DYg4d42PWzC0l4hIuz02h3jdzeARXvgCpiSYCpINLIo1HHadNFeFzt1UypwN83mJJ7gsdj8YdQFCSyd44AY0dUNz2dNDUtnWBTMPFGw1wKzIM1ahmyUq2oy21oXcg4hjYOHiA9daiqxgXXwiEcW2Pgw= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WN2FNnI_1736156055 cluster:ay36) by smtp.aliyun-inc.com; Mon, 06 Jan 2025 17:34:16 +0800 Message-ID: Date: Mon, 6 Jan 2025 17:34:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: set folio swapbacked iff folios are dirty in try_to_unmap_one To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com, david@redhat.com, ryan.roberts@arm.com, zhengtangquan@oppo.com, ying.huang@intel.com, kasong@tencent.com, chrisl@kernel.org, Barry Song References: <20250106031711.82855-1-21cnbao@gmail.com> <20250106031711.82855-2-21cnbao@gmail.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025/1/6 17:03, Barry Song wrote: > On Mon, Jan 6, 2025 at 7:40 PM Baolin Wang > wrote: >> >> >> >> On 2025/1/6 11:17, Barry Song wrote: >>> From: Barry Song >>> >>> The refcount may be temporarily or long-term increased, but this does >>> not change the fundamental nature of the folio already being lazy- >>> freed. Therefore, we only reset 'swapbacked' when we are certain the >>> folio is dirty and not droppable. >>> >>> Suggested-by: David Hildenbrand >>> Signed-off-by: Barry Song >> >> The changes look good to me. While we are at it, could you also change >> the __discard_anon_folio_pmd_locked() to follow the same strategy for >> lazy-freed PMD-sized folio? > > it seems you mean __discard_anon_folio_pmd_locked() is lacking > folio_set_swapbacked(folio) for dirty pmd-mapped folios? > and it seems !(vma->vm_flags & VM_DROPPABLE) is also not > handled properly? Right.