From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795017747; b=H2tBcrIvZRiH+x5GKVn1UWLVTJwqb/yiR9wVviOhHbVIVQT6EwYIZF6KABAIXJYYzHKO eDU5XYu9dAQRvDZhwbV+fXGyHqjpBgAZhz7aHBjUgwK8prxHatxRB/u4R5JpPxfsW6dDb JQxWvLnaREAYYuL4vZNAv+z/kWSp0xa6aTSMXJgEq6MQfgJikvau74zf8EVwdKPK+hdok 6udAwQ7dK5oqGBHTAUdfPw+miQZ8vu1ZwK47qyft/6edJOlVAdXGk12gbBOV1iF8L+SLD dHcjQtnT5CfKPK7dsPEr5JZHP8p4rE2OFZjl6bATRcWi7Upr4D6n8a9b3Ky14p9EqYA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795017747; h=Received:DKIM-Signature:Content-Type:MIME-Version:Message-Id: In-Reply-To:References:Subject:From:To:Cc:Date; bh=XrdabjoeKoqZWgiPzIuL3cPjSBYVcnxPS9RnfVz1GGs=; b=HR347RzXF4FMUACgdNiIH3moKNroK7uV41dHqeEtgc2H0t/cxNpflWJi9m8/sZZed5QF 2qs7BtISbyh2kRnFnUMZKtVe2H2fr9L9r6HWhyMQjxfbQx1Q3rdDV0t4lnCTY1cWUl/6r mEAgU7WcLuFWuUqEFwNxyu73GiJbj7FVwVTFOLdbnl7bTQ5rZ3lThHBJKY1OkWTWc3o4u 9y7tDNVxERM9BAiV5Vj3za8xR/e1Oa5i7SAo7tHppFtaQVh43BCqPzd+jr/DoUJrvE3t0 S/d6sCcGVF6vUNAfxqmLN+gOKVSD2V/ihJAppH02cuTWqxeoUxYpod6R2J73NsUKc1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WU1Tfeou; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7900606A320; Wed, 18 Nov 2026 16:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WU1Tfeou Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA9531F000C5; Wed, 18 Nov 2026 16:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795017746; bh=XrdabjoeKoqZWgiPzIuL3cPjSBYVcnxPS9RnfVz1GGs=; h=In-Reply-To:References:Subject:From:To:Cc:Date; b=WU1TfeoutT9TRUjHxlvhGm9LpJKpy+H4cCwsKZ3CtgcKFzxOVt8QTF3OsSPY+3SqT aAdu9dQt8z+RBpbVA/FbYcUwIRmBLVvlyc5kQrdWtafZ6KLOVJTvIPVYFojOIf30AZ 7lgsg7/pnxk15kCBZHn80H92G3q8ZpEvUEzxElp9QZrPkHSaLvjOYd5ZGhHU42H8G4 VyW/r0O/Bq1+6SqgxasiVU+YChY67/DuTQsRwj4ySZ3cbDQSvl1wIaiTAE/9/SSC/J gb1Tik48CySE8lgtyKNxCxwfEza8wnMmpe0Cl9c0+K6Gt1nSwS89PVGSXbdeAhmNjx j2BjueANmd9RA== Content-Type: multipart/mixed; boundary="===============3130468370452098512==" X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Message-Id: In-Reply-To: <20261118152054.999990-1-visitorckw@gmail.com> References: <20261118152054.999990-1-visitorckw@gmail.com> Subject: Re: [PATCH] m68k, bpf: Add initial BPF JIT compiler support From: bot+bpf-ci@kernel.org To: visitorckw@gmail.com,corbet@lwn.net,geert@linux-m68k.org,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,gerg@linux-m68k.org Cc: skhan@linuxfoundation.org,rdunlap@infradead.org,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,marscheng@google.com,eleanor15x@gmail.com,jserv@ccns.ncku.edu.tw,linux-doc@vger.kernel.org,linux-kernel@vger.kernel.org,linux-m68k@lists.linux-m68k.org,bpf@vger.kernel.org,visitorckw@gmail.com,daniel@thingy.jp,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev Date: Wed, 18 Nov 2026 16:02:23 +0000 (UTC) --===============3130468370452098512== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > m68k, bpf: Add initial BPF JIT compiler support TL;DR: Nit only: the "bne.s .+8" style comments in the m68k JIT's 64-bit compare code are off by 2 (should be .+10); the emitted encoding looks correct. > diff --git a/arch/m68k/net/bpf_jit_comp.c b/arch/m68k/net/bpf_jit_comp.c > new file mode 100644 > --- /dev/null > +++ b/arch/m68k/net/bpf_jit_comp.c [ ... ] > + } else { > + emit_16(ctx, 0xb080 | (d_hi << 9) | s_hi); /* cmp.l s_hi, d_hi */ > + > + switch (op) { > + case BPF_JEQ: > + emit_16(ctx, 0x6608); /* bne.s .+8 */ > + emit_16(ctx, 0xb080 | (d_lo << 9) | s_lo); /* cmp.l s_lo, d_lo */ > + EMIT_JMP32(0x6700); /* beq.l */ > + break; [ ... ] > + case BPF_JGT: > + EMIT_JMP32(0x6200); /* bhi.l */ > + emit_16(ctx, 0x6508); /* bcs.s .+8 */ This isn't a bug, but are the "bne.s .+8" style comments accurate? In m68k assembler syntax "." is the address of the current instruction, so "bne.s .+8" would assemble to 0x6606, since the 8-bit displacement is relative to the opcode address + 2. The emitted word 0x6608 has a displacement of 8, so the branch target is ".+10". It skips the 2-byte cmp.l and the 6-byte b.l, so the code looks correct and only the comment is off by 2. The same comment pattern appears for bne.s, bcs.s, bhi.s, blt.s and bgt.s in the other 64-bit compare cases of emit_jmp(). Would ".+10", or something like "bne.s +8: skip cmp.l + b.l", match the encoding better? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44337242298 --===============3130468370452098512==--