From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com,
casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com,
gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org,
jmorris@namei.org, nramas@linux.microsoft.com,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH v7 3/8] IMA: define a hook to measure kernel integrity critical data
Date: Fri, 11 Dec 2020 09:28:11 -0800 [thread overview]
Message-ID: <b65f2a10-037b-0fb7-fe88-5cc8482faedc@linux.microsoft.com> (raw)
In-Reply-To: <20201210230218.GH489768@sequoia>
<snip>
>> + */
>> +void ima_measure_critical_data(const char *event_name,
>> + const void *buf, int buf_len,
>> + bool measure_buf_hash)
>> +{
>> + if (!event_name || !buf || !buf_len) {
>> + pr_err("Invalid arguments passed to %s().\n", __func__);
>
> This is a problem for the developer making use of the
> ima_measure_critical_data() API and shouldn't be logged, IMO, because a
> user/admin can do nothing about it. I think the error message should be
> dropped.
>
Thanks Tyler.
Will drop the message.
next prev parent reply other threads:[~2020-12-11 19:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 19:42 [PATCH v7 0/8] IMA: support for measuring " Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 1/8] IMA: generalize keyring specific measurement constructs Tushar Sugandhi
2020-12-10 22:14 ` Tyler Hicks
2020-12-11 1:14 ` Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 2/8] IMA: add support to measure buffer data hash Tushar Sugandhi
2020-12-10 22:38 ` Tyler Hicks
2020-12-11 1:21 ` Tushar Sugandhi
2020-12-11 2:08 ` Tyler Hicks
2020-12-09 19:42 ` [PATCH v7 3/8] IMA: define a hook to measure kernel integrity critical data Tushar Sugandhi
2020-12-10 23:02 ` Tyler Hicks
2020-12-11 3:26 ` Tushar Sugandhi
2020-12-11 17:28 ` Tushar Sugandhi [this message]
2020-12-09 19:42 ` [PATCH v7 4/8] IMA: add policy rule to measure " Tushar Sugandhi
2020-12-10 23:10 ` Tyler Hicks
2020-12-11 3:28 ` Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 5/8] IMA: limit critical data measurement based on a label Tushar Sugandhi
2020-12-10 23:15 ` Tyler Hicks
2020-12-11 3:28 ` Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 6/8] IMA: extend critical data hook to limit the " Tushar Sugandhi
2020-12-10 23:19 ` Tyler Hicks
2020-12-11 1:29 ` Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 7/8] IMA: define a builtin critical data measurement policy Tushar Sugandhi
2020-12-10 23:22 ` Tyler Hicks
2020-12-11 1:30 ` Tushar Sugandhi
2020-12-09 19:42 ` [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook Tushar Sugandhi
2020-12-11 15:36 ` Tyler Hicks
2020-12-11 15:41 ` Tyler Hicks
2020-12-11 16:27 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b65f2a10-037b-0fb7-fe88-5cc8482faedc@linux.microsoft.com \
--to=tusharsu@linux.microsoft.com \
--cc=agk@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=sashal@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome